Code Monkey home page Code Monkey logo

Comments (6)

delagoya avatar delagoya commented on August 11, 2024

Specifically, any multi-line comment should not be indented to the level of the code that the comment applies to. Given the following Avro IDL

@namespace("com.example")
/**
This is a comment for the whole protocol
*/
protocol Example {
/**
The comment applies to the `NoSpaces` record, but is not indented to the 
level of the record specification.
*/
  record NoSpaces {
    /** This is a single line comment that is indented for readibility,
    and is not effected by indentation. */
    string single_line_comment_property;
/**
This multi-line comment on `mult_line_property` that would be effected by indentation.
This is another paragraph
    
    This is an indented block and should be shown as 
    such.
Here is a code block that apparently does not work for avrodoc. E.g. no [GFM](https://help.github.com/articles/github-flavored-markdown) support.
```ruby
# this is a Ruby code block
def method(arg1, arg2=nil)
  puts "hello world!"
end
```
*/
    string multi_line_property;
  }
}
```

And refer to here for output:

http://angelfiles.s3.amazonaws.com/ga4gh/doc/test2.html#/schema/com.example.NoSpaces

from ga4gh-schemas.

cassiedoll avatar cassiedoll commented on August 11, 2024

@delagoya - I think the preference from the other issue was something more like this:

@namespace("com.example")
/**
comment
*/
protocol Example {
record x {
../**
..paragraph #1

..paragraph #2
..*/
..string y;
}
}

(in other words, the 2-space indent for fields/comments gets us at least some semblance of everything lining up without causing issues)

from ga4gh-schemas.

delagoya avatar delagoya commented on August 11, 2024

Is this issue able to be closed?

from ga4gh-schemas.

cassiedoll avatar cassiedoll commented on August 11, 2024

I think we need a PR to actually update the code indents.

from ga4gh-schemas.

fnothaft avatar fnothaft commented on August 11, 2024

@delagoya @cassiedoll is correct, IIRC; I think we're still waiting on a PR. I can take a shot at that today.

from ga4gh-schemas.

cassiedoll avatar cassiedoll commented on August 11, 2024

Thanks Frank!

from ga4gh-schemas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.