Comments (4)
from ga4gh-schemas.
@andrewjesaitis From previous discussions and the documentation it is actually clear that created
and updated
refer to record specific dates; there is no indication that they have to do anything with record-external time points (like sample collection or such):
// The :ref:`ISO 8601<metadata_date_time>` time at which this Biosample record
// was created.
string created = 6;
// The :ref:`ISO 8601<metadata_date_time>` time at which this Biosample record was
// updated.
string updated = 7;
Also, all the values are (or should be) ISO 8601, which also has been settled before.
We know from many use case discussions and personal experience that such information (i.e. beyond server time stamps etc.) is of practical value. How these attributes are used locally (i.e. if they are linked to audit-grade time stamping) is irrelevant for the API; also, this cannot be solved on a global scale.
There are 2 points which I seem worthwhile for discussion:
- the awkward naming; logically it should be
record_creation_time
&&record_modification_time
, but this is/can be made clear enough in the documentation - the need for a
created
attribute, since modification is probably more relevant; alas, there are always use cases, and the attribute is optional (at least on the schema level)
So my take: keep/implement throughout the schema (not necessary everywhere - a variant or call don't need them, since they would be implemented in the variantset, callset etc.). Obviously ISO; everything else is a violation of the schema docs. I don't mind about name changes (created & updated were actually decided against before, but somehow they stuck then around).
from ga4gh-schemas.
I agree that at a minimum they should be renamed record_created_time
and record_modification_time
and use ISO8601.
I'll let @kozbo, @david4096 and @ejacox chime in with their thoughts as well.
from ga4gh-schemas.
@andrewjesaitis No problem with me, since this is what I wrote back in #568 (comment)
@jeromekelleher While I'm fine with created | updated, this was seen as ambiguous in var. discussions ("updated" could be a Boolean/flag) & so @diekhans switched it to the current. I had started the whole ISO8601 switch & documentation, but very explicitly called those recordCreateTime | recordUpdateTime, originally. ... But as said, all fine with me, since the documentation should make it clear.
So I'll leave the clean-up to whoever feels responsible.
from ga4gh-schemas.
Related Issues (20)
- Package for CRAN
- RNA expression data structure is inefficient HOT 7
- Rename repository HOT 2
- Update Release notes for the v0.6.0a10 release
- Add peer service human readable docs HOT 1
- Document maven release process HOT 1
- Move datamodel to its own repo
- Improve development.rst
- Content Type Negotiation
- Implement updated transcript effects protocol
- Deprecate reference ID in favor of reference name or accession ID HOT 1
- Recreate assay metadata HOT 2
- Update Java Protobuf Dependency to 3.1+
- protobuf java square write code-gen HOT 3
- Change booleans to enums
- Assay Metadata for Analysis object table is broken in documentation...
- GeoLocation attributes names HOT 1
- ListReferenceBasesRequest GET or POST HOT 1
- AnalysisResult scores
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ga4gh-schemas.