fxn / vim-monochrome Goto Github PK

First of all huge thanks for this theme, I've been using it for the past month or so and it really grew on me. I had to tweak a few things but I'm definitely a fan now.

There is one case that I could not overcome and it was the strings inside Pmenu (see the screen shots below). Since the Pmenu bg has the same color as the String guifg the strings kinda blend into the background and it gets unreadable. Personally I'd prefer to overcome this without changing the String fggui in the buffer and to only affect the Strings color inside the Pmenu. Any tip on how to accomplish this is appreciated.

Some people use window compositors (like compton) and put "hi Normal guibg=NONE ctermbg=NONE" into their .vimrc to achieve transparency (this is not just for aesthetics, it lets you read what's behind the terminal – which can be quite useful).

Here's what it looks like with the default colorscheme:

Here's how the current vim-monochrome behaves:

This can be quite trivially fixed by extending the guibg/ctermbg if condition in the hi function like so:

if bg != s:default_lst && bg != s:default_bg
    call add(cmd, 'guibg='.bg[0])
    call add(cmd, 'ctermbg='.bg[1])
endif

Here's the patched vim-monochrome:

I don't see what's the point of setting guibg/ctermbg to default_bg which is black, when "set background=dark" is already there in the top of the file.

If I'm not missing anything here then give me a go-ahead and I'll send in a patch.

As shown in the attached screenshot, monochrome currently looks aggressive:

I propose that the following style is added:

call s:hi('SignColumn')

So that it looks like this:

In the era of dark modes I'm one of those crazy folks that do:

  set background=light

and use a white/white-ish terminal.

Unfortunately this great colorscheme is not quite useable on a light background.

Would it be possible to have it support light mode as well?

After latest update I'm receiving error when try to run vim

Error detected while processing function <SNR>13_hi:
line   18:
E691: Can only compare List with List
E15: Invalid expression: attr != s:default
E691: Can only compare List with List
E15: Invalid expression: attr != s:default

Line 18 is the latest Plugin line in my .vimrc (doesn't meter what exact plugin is there). Once I turn off using monochrome color scheme - it works

Really liking this theme but unfortunately I can't get past the all white with a thin black line vertical window split. Would it be possible to invert this so we have a thin white line instead?

Visual selections and search highlights (set hlsearch) are not visible for me (TERM=xterm).

One of the things that bothers me about this colorscheme is that with :set list active, it's extremely difficult to tell whitespace apart from the characters they use to represent it. I'm talking specifically about

>  used to represent a tab (^I)
-  used to represent a trailing space.

The whitespace characters are very slightly whiter, but, I mean, look at it:

I don't care how much of a purist you are, this is very hard to distinguish and needs more contrast. Maybe make them grey like the :set nu numbers.