fxdeniz / nesync Goto Github PK

Currently database dependency created inside of the constructor. This causes name collision for connection in different threads.
More elegant mechanism is needed.

Replace buttons next to lineEdits to inside of lineEdit.
Example available in tutorial here: KDAB youtube channel

When adding row to the table

1. Check whether folder exist (by old folder name) in db
   1. If file exist in db
      • #62
   2. If file is not exist
      • Ignore file

When adding row to the table

1. Check whether folder exist in db
   1. If file exist in db
      • #61
   2. If file is not exist
      • Ignore file

• Replace hard-coded column indexes of table models with named constants
• Modularize DialogAddNewFile::on_buttonSelectNewFile_clicked() if possible
• Create repository class for color code constants
• Move UI related code into separate method in every window (MainWindow, Dialog or Tab)
• #26
• Provide factory method for TableModelNewAddedFiles::TableItem
• #47
• #48
• #67
• #66
• #82

Provide a way to user for adding new file into system.

Steps of use case

1. Open dialog and allow user for selecting file which is about be added into db.

   • fxdeniz/XdBackup#3
   • fxdeniz/XdBackup#5
   • When adding new file check for these cases:
   • #6
   • #7
   • #8
   • #9
   • #10

2. Addition must be done through background task

   • #14
   • #13
   • #15

3. If addition successful:

   • #17
   • #76
   • #33

4. If addition failed:

   • #18

5. Group added files

   • #78

Steps of use case

1. Open dialog and allow user to enter name of new folder

   • #21

• When adding new folder check for these cases:
  • #22

2. If new folder added successfully:

   • #23
   • #24

3. If new folder adding failed:

   • #25

When adding row to the table

1. Check whether file exist in db
   1. If file exist in db
      • #52
   2. If file is not exist
      • #54

When adding row to the table

1. Check whether file exist in db
   1. If file exist in db
      • #55
   2. If file is not exist
      • Ignore file

When adding row to the table

1. Check whether file exist (by old file name) in db
   1. If file exist in db
      • #57
   2. If file is not exist
      • Ignore file

Run clang tools for linting. Messages from these tools were ignored at the beginning. Warnings must be handled comprehensively.

Few warnings I remember:

• FileStorageManager.cpp gives warning in range based for loops. It's related with reference counting when accessing smart pointers.

When adding row to the table

1. Check whether file exist in db
   1. If file exist in db
      • #59
   2. If file is not exist
      • #60

This happens whenever FileStorageManager::addUnRegisteredFile() is called.
Memory consumption is related with file size.
Problems comes from this statement QString fileHash = this->getHashOf(sourceFile.readAll()); call to sourceFile.readAll() must be replaced something more efficent.

Steps of use case:

1. FileMonitoringManager have to receive paths to files from FileStorageManager

2. When file event occurred, this event should be listed in table view of File Monitor
   Some types of events may require these checks from database.

   There are few type of events that can be displayed:

   1. When file from prediction list not found in user's file system:
      • #64
   2. When unpredicted folder detected in user's file system:
      • #37
   3. When unpredicted file detected in user's file system:
      • #38
   4. When user created folder in user's file system:
      • #39
   5. When user created file in user's file system:
      • #40
   6. When user deleted folder in user's file system:
      • #41
   7. When user deleted file in user's file system:
      • #42
   8. When user moved (including renaming) folder in user's file system:
      • #43
   9. When user moved (including renaming) file in user's file system:
      • #44
   10. When user modified file in user's file system:
       • #45
   11. When user modified and moved (or vice versa) file in user's file system:
       • #46

3. After each event, table view should be refreshed

   • #63

for example calling FileStorageManager::addNewFile() on .gitignore or .sample_file.txt returns false.

• I first detected this bug in Windows. But did not check the other platforms.
• When I checked the database, I saw that, FileEvent record stays in database.

Steps of use case:

1. All request to back-end must be done through always running background task

   • Task must provide interface for getting path list to files and folders contained in given directory

2. File explorer must start root folder opened

   • #28
   • #29

3. File explorer must allow user viewing user content

   • #30

4. User must navigate using back and forward buttons

   • #31
   • #32

FileMonitoringManager::addTargetsFromPredictionList() designed to emit some signals, when item from prediction list is not exist on user file system. These signals are:

• signalPredictedFileNotFound()
• signalPredictedFolderNotFound()

And pseudo code for catching this scenario is here:

QFileInfo info(currentPath);

if(info.isFile())  --------------->   // Check 1
{
    if(info.exists())
        processFile();
   else
        emit signalPredictedFileNotFound(currentPath);
}
else if(info.isDir())  --------------->   // Check 2
{
    if(info.exists())
        processDir();
    else
        emit signalPredictedFolderNotFound(currentPath);
}
else --------------->   // Else condition
    emit signalPredictionTargetNotRecognized(currentPath);

But this logic has an error. That is, we first need to check whether QFileInfo info(currentPath) exist or not. Then, we need to run Check 1 and Check 2. When QFileInfo info(currentPath) not exist, Check 1 and Check 2 always fails. And this makes, signalPredictedFileNotFound() and signalPredictedFolderNotFound() invalid. Since they are never going to be emitted.

New logic should be:

QFileInfo info(currentPath);

if(info.exist())
{
    if(info.isFile())  --------------->   // Check 1
        processFile();
    else if(info.isDir())  --------------->   // Check 2
        processDir();
}
else --------------->   // Else condition
    emit signalPredictionTargetNotRecognized(currentPath);

Therefore, these signals are unnecessary:

• signalPredictedFileNotFound()
• signalPredictedFolderNotFound()

There is a typo in the first line of this function which is QSqlQuery query(this->getTableName()); typo is this->getTableName() it should be replaced with this->getDb()

This was a very subtle yet critical bug. It went under radar until FileStorageManager used in multi-threaded context.

I encountered very weird bugs and debug messages such as "Database driver is not loaded". LoL

Underlying problem was that, when FileStorageManager run in a multi-threaded environment, every connection requires unique name. But this typo caused database dependency to not properly delivered to RowInserter instance. As a result, QSqlQuery used fallback mechanism to use default connection. But, there was no default connection.

It was a very critical bug, caused unexplained catastrophic failures in the system.
Now it's solved.

[Insert more coffee here for sleepless nights]

This is needed for making FileMonitoringManager movable inside of QThread objects.

Two statements below

QString fileHash = this->getHashOf(sourceFile.readAll());

and

bool isFileCopied = sourceFile.copy(internalFilePath);

can be run inside QtConcurrent::run() as lambdas