Code Monkey home page Code Monkey logo

nodejs-dnsimple's People

Contributors

anderly avatar fvdm avatar greenkeeperio-bot avatar weppos avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

nodejs-dnsimple's Issues

Complete v1 release

  • Restructure module
  • Rewrite test script
  • Rewrite readme
  • Run tests
  • Tag commits
  • Create releases
  • Move changelog to Github Releases

Build Status
Code Climate

Not working with api v1

I'm trying to use your package with a new command line interface for dnsimple (http://ander.ly/1eSUh). However, I've found it doesn't work with the current version of the api.

The host name should now be api.dnsimple.com and the path should be prefixed with /v1/.

A couple of other issues I've run into are the callback signature doesn't follow the standard function(err, callback) convention.

For instance, instead of:

callback( result, status );

I'd like to change it to:

callback( status, result );

or:

callback( null, result );

and include status as a property on the result.

I have forked your repo and could submit these back as a PR, but didn't know if you were tied to that model.

Let me know.

Implementing checker function to index page

Hello,

I'm trying to use your module to check domain availability on my index.js page. However, I don't have much experience in node.js and I'm having hard time getting the the checker function to work.

My setup is running express as framework, sporting jade. This is what I have in the server-side so far:

var express = require('express')
  , routes = require('./routes')
  , dnsimple = require('./node_modules/dnsimple') 

....

// Configuration

dnsimple.api.email = 'j****@mail.com';
dnsimple.api.token = '*******************';

.....

So basically what I have tried to do is adding following into client side .jade file, inside script tags:

dnsimple.domains.show(domain);

where domain is post data of form. This however runs me into error saying "Uncaught ReferenceError: dnsimple is not defined ", which makes me confused where and how should I declare dnsimple function.

My current index.js looks like this:

exports.index = function(req, res, dnsimple){
  res.render('index', { title: 'Backnorder' })
};

I understand if you don't want to help a newbie, but any attempts to help would be really appreciated!

Massive clean up

note to self

I'm considering to redesign the whole interface, making it all much much easier to code and maintain.

Add tests with Travis CI

  • Write test script in seperate branch: /Tests
  • Connect to Travis CI
  • Set up DNSimple Sandbox account
  • Run successful basic test
  • Add tests for individual methods

Part of v1 release (#5)

Windows support

  • Does the test script run?

Update:
In Windows 7 I needed to install Git for Windows and run the command below from git bash to at least install from the dev tree.

npm install git+https://github.com/fvdm/nodejs-dnsimple

Thanks for writing this, but please adhere to the node.js conventions

First of all, thanks for publishing this. It is very helpful and saves me an hour or two. That is much appreciated.

However, please provide an update (with a significant new version) that changes the callback syntax from yours to the official node version, where the err is always the first parameter.

Thanks
Martin

Multiple instances

Please wrap the API with config into an object so I can create multiple instances.

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.