fuzss / diagonalblocks Goto Github PK

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19

Mod Version (Required)

4.0.1

Notes (Required)

Steps to reproduce the behavior:

1. Add mod file mcw-fences-1.0.5-mc1.19.jar and diagonalfences-v4.0.1-1.19 to .minecraft/mods
2. Launch game & open world
3. Game becomes unbearably laggy

I tested this with MrCrayfish's Furniture mod and it doesn't produce the same effect. Macaw's Fences and Walls works fine without Diagonal Fences installed, unfortunately.

latest.log (Optional)

No response

Suggestion (Required)

Would it be possible to create a voxel shape that looks less messy?
I ask since the vineblock class does a fancy thing where it adds all the shapes together and then makes the visual box, making the hitbox of the block not overlap (I assume that's what it does)

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.18.2

Mod Version (Required)

V3.1.0

Notes (Required)

1. launch game
2. load pack
3. crashes before loading screen completes.

Crash Report (Required)

https://gist.github.com/paustin123/2d602f809d7e931d2d3190ee2223098e

latest.log (Optional)

No response

Debug log Render thread/Warn "mod_resources" logs com.fuzs.diagonalfences.resources.RuntimeResourcePack @7443a906 as an Unknown resource pack type. Might be caused by some mod conflicts so take this info with a grain of salt.

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.18.2

Mod Version (Required)

3.1.0

Notes (Required)

The memory usage comparison is as follows

This is more serious in my modpack

latest.log (Optional)

https://gist.github.com/Dr-WeiAL/17a156e8c52be5f8e3de31607ac4f393

Minecraft v1.16.5
Forge v36.1.4
Diagonal Fences v1.0.3
OSV v6.1

When the mod Ore Stone Variants is installed and the config setting overlaysFromRP in OSV-client.toml is set to true, the game will crash on load. It looks to be related to the assets generator.
Crash Report
Logs

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.18.2

Mod Version (Required)

3.1.1 (3.2.0 is still broken for me)

Notes (Required)

The Star Worm Decor Mod adds a bunch of picket fences. They don't show up when connecting diagonally, though the bounding box and collider do exist. I tested it on a fresh pack with only DF, Puzzles Lib and SWDM installed, no shaders involved. Happened on my large modpack as well where I use Oculus and Flywheel compat. The fence never renders correctly, maybe a missing reference?

Please let me know if I should test any other fences! Sure can. I had no issues with other fences so far but I haven't used too many different types so I might be missing something.

If you need any other info, just ask! I try my best to provide so we can figure out what happened :)

latest.log (Optional)

No response

While testing the compatibility for DiagonalFences in FramedBlocks I noticed that the exclusion tag you have added doesn't have any effect.

The log mentions this:
[Server thread/ERROR] [net.minecraft.tags.TagCollectionReader/]: Couldn't load block tag diagonalfences:non_diagonal_fences as it is missing following references: assorteddecor:colorizer_fence (from DiagonalFences-v1.1-1.16.5.jar)
To fix this you need to make the tag entries optional as mentioned here: https://minecraft.fandom.com/wiki/Tag#JSON_format
In dev this works fine because all entries mentioned in the tag are actually present in the game when you are testing with these mods.

Versions for good measure:
Forge: 1.16.5-36.1.18
PuzzlesLib: 1.0.1
DiagonalFences: 1.1

Suggestion (Required)

Currently, all three mods are completely functional together. However, it's missing textures; In the given image, these two Lament type fences connect diagonally, but don't appear to be: https://i.imgur.com/tpqhUYJ.png

Similar issue appears with Traverse mod fences.

Suggestion (Required)

(1.19.2) When the structure is placed by world generating, fences inside of the structure do not automatically connect as diagonal. For example:

Would be good to have them connect automatically right away without the need to do a manual update, like this:

I understand I can save the new structrue nbt with fences already connected in it, but I think some support of existing structures would be good to have.
(The structure I used in the above examples is Wabi sabi structures - "llama_sanctuary_plateau" - it contains Llama holding places)

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2.2

Notes (Required)

1. Load minecraft with diagonal fences mod and optifine
2. press play
3. doesnt boot

latest.log (Optional)

No response

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

v4.2.0

Notes (Required)

placing fences with the fabulously optimized modpack makes the diagonal fences invincible.

e

latest.log (Optional)

No response

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.18.2

Mod Version (Required)

v3.2.0

Notes (Required)

Crashes when I launch the game, likely a mod conflict but idk which one. This only happens on version v3.2.0 aka previous version booted just fine.

Crash Report (Required)

https://gist.github.com/mxnmnm/6159506a969db0efb829c43e8cda3cba

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.18.2

Mod Version (Required)

v3.1.0

Notes (Required)

Current behaviour: When you break a diagonal fence, way more break particles appear as compared to break particles from a "normal" fence (see image).

Steps to reproduce;
1, Open up a world with Diagonal Fences installed.
2. Place down a diagonal fence by placing two fences diagonally.
3. Break it and observe the difference between the particles coming from the vanilla fence and the diagonal fence.

Expected behaviour: The diagonal fence's break particles should be in-line with the "normal" amount of break particles occurring from the vanilla fences.

latest.log (Optional)

https://gist.github.com/GeorgeOrwell1/0c4db3716169e9aa4f29aad2a4b35794

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.1

Mod Version (Required)

all so far

Notes (Required)

When the mod wasn't updated I added a texture model to my personal pack that made some of the fences and walls arch when put at a corner (no where as satisfying as your mod. I am trying to purge those out again for the most part but even one appears to conflict and cause the mod to not display, Is there a model JSON for your fences that I can experiment with the pack with? I like both models and would like to see where the conflict is. I am updating to the newest in hopes that may fix it.

latest.log (Optional)

No response

When Diagonal Fences is installed in the same game as "Snow! Real Magic!" anytime a fence gets snow'ed over it loses the ability to connect diagonally.

Snow! Real Magic!

In testing, it'd appear that my game crashes when a structure is generating in the nether that uses Quark's Gold Bars crashes when the following exception occurs

java.lang.IllegalArgumentException: Cannot set property BooleanProperty{name=north_east, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in Block{quark:gold_bars}
at net.minecraft.state.StateHolder.func_206870_a(SourceFile:114) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:babel.mixins.json:StateHolderMixin,pl:mixin:APP:META-INF/diagonalfences.mixins.json:accessor.IStateHolderAccessor,pl:mixin:A}...

crash-2021-10-19_13.15.53-server.txt

This crash can be replicated by trying to enter the nether on v1.11.4 of Nutmeg that uses version v1.1.1 of Diagonal Fences, and version r2.4-319 of Quark, it is unknown if other mods are needed to recreate this issue, so the mod pack has been provided if that helps where the crash can be replicated.
https://www.curseforge.com/minecraft/modpacks/nutmeg-casual-pack

Environment: Magma 1.16.5
Issue: Crash on start up
Description: After updating my server software to its latest build puzzleslib stops my server from starting, tried v1.0.3 and up with no results, removing the mod for now enables my server to work like normal but id still like to use diagonalfences which requires this mod, is this a simple fix?
Error:

Exception in thread "main" [00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1050]: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1050]:       at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:39)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1050]:       at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1050]:       at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1050]:       at cpw.mods.modlauncher.Launcher.run(Launcher.java:82)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1050]:       at cpw.mods.modlauncher.Launcher.main(Launcher.java:66)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1050]:       at net.minecraftforge.server.ServerMain$Runner.runLauncher(ServerMain.java:85)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1050]:       at net.minecraftforge.server.ServerMain$Runner.access$100(ServerMain.java:82)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1050]:       at net.minecraftforge.server.ServerMain.main(ServerMain.java:79)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1059]: Caused by: java.lang.reflect.InvocationTargetException
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1059]:       at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1059]:       at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1059]:       at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1059]:       at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1059]:       at net.minecraftforge.fml.loading.FMLServerLaunchProvider.lambda$launchService$0(FMLServerLaunchProvider.java:51)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1059]:       at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1059]:       ... 7 more
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]: Caused by: java.lang.IllegalAccessError: Update to non-static final field net.minecraft.state.StateHolder.field_235893_d_ attempted from a different method (setCodec) than the initializer method <init>
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.state.StateHolder.setCodec(StateHolder.java)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.block.FenceBlock.mda3943a$lambda$init$1$0(SourceFile:637)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Streams.java:411)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:734)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.block.FenceBlock.handler$zee000$init(SourceFile:637)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.block.FenceBlock.<init>(SourceFile:33)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.block.Blocks.<clinit>(Blocks.java:237)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.world.gen.surfacebuilders.SurfaceBuilder.<clinit>(SurfaceBuilder.java:12)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.world.gen.surfacebuilders.ConfiguredSurfaceBuilders.<clinit>(SourceFile:11)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.util.registry.WorldGenRegistries.func_243674_g(WorldGenRegistries.java:33)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.util.registry.WorldGenRegistries.func_243668_a(WorldGenRegistries.java:89)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at java.base/java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.util.registry.WorldGenRegistries.<clinit>(WorldGenRegistries.java:88)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.util.registry.Registry.<clinit>(Registry.java:464)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.util.registry.Bootstrap.func_151354_b(Bootstrap.java:41)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    at net.minecraft.server.Main.main(Main.java:138)
[00:24:11] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:648]:    ... 13 more

Suggestion (Required)

Heya! Currently MrCrayfish's Furniture Mod's fences don't work with this, but it would be fun to see compatibility with them if that's a possibility for the future!

Suggestion (Required)

Please, add support for Domum Ornamentum. Diagonal fences made from modded blocks in Domum Ornamentum are displayed as plain wood.
Fences made from other modded blocks that I saw so far are displayed well and work great!

On the below image, to compare:

• bottom-left - Framed Blocks fences filled by raw gold block
• bottom-right - BYG mod wood fence
• top - Domum Ornamentum fence with Starlit log
  (Note: original Starlit log fences from Blue Skies mod also work well, so its surely related specifically to Domum Ornamentum)
  

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2.6

Notes (Required)

When you Mod is installed i have a wiered stuff happening. Whenever i place blocks which are connected (fences, walls or placing blocks with effortless building) they became (when i play on server side) completly differnt blocks. I need to reload the chunk or rightclick them with my hand that they become the correct one.
After i delete your Mod this will not happening any more.

here you see i have a fence and place it and it becomes iron doors and waterlogged fences.

here i rightcllicked few of them and place on new down and it became a jukebox.

When i deinstall your mod i can place new added modblocks completly free of any bugs

latest.log (Optional)

No response

Mod Loader (Required)

Quilt

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2.3

Notes (Required)

when on a server, certain blocks change into other random blocks. doesnt happen in singleplayer

with the mod:

without the mod:

latest.log (Optional)

https://mclo.gs/LEpKnsL

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2

Notes (Required)

Crashing

Crash Report (Required)

https://mclo.gs/r1g4COk

latest.log (Optional)

No response

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2.3

Notes (Required)

I recently was playing on a server I had created with friends, and everything was fine

After about a week we decided to make a quite large village using the diagonal fences for villager hotel rooms

We found that we would get an INSANE amount of TPS drops on a 5800x server, and it was insane, like 5tps

We couldn't point a finger to exactly what was causing it

I found that an entity was trying to navigate through a diagonal fence and the lag was fixed by breaking the fence that villager was trying to nav through

It was hard to replicate but I was able to by placing a bed next to a diagonal fence, and when the villager awoke the villager was almost in the diag fence but not entirely, and tried to path find through it

That's when the TPS drops ensued, none of the players experienced a actual FPS drop, just TPS

I apologize for not attaching the latest.log file from my server, as I am currently not able to access it in person, but wanted to at least put this on your radar, I will try to get a proper latest.log when I am able to create another quick test server with friends to purposely re-create the issue

latest.log (Optional)

No response

Hey !
I found a conflict between Diagonal Fences and Kiwi.

The game simply crash at startup.

Crash report:
https://pastebin.com/A7TB2Epe

Logs :
https://pastebin.com/KHGWgnVg

Debugs :
https://pastebin.com/MmVWhfRm

Informations :

Minecraft 1.16.5
Forge 36.1.4
Diagonal Fences1.0.1
Snow Real Magic 2.5.4
Kiwi 3.5.0

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.16.5

Mod Version (Required)

1.1.1

Notes (Required)

The following ConcurrentModificationException can be thrown if the runtime resource pack is accessed by multiple threads concurrently:

Caused by: java.util.ConcurrentModificationException
	at java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1585) ~[?:1.8.0_372]
	at java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:742) ~[?:1.8.0_372]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) ~[?:1.8.0_372]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) ~[?:1.8.0_372]
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708) ~[?:1.8.0_372]
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:1.8.0_372]
	at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566) ~[?:1.8.0_372]
	at fuzs.diagonalfences.resources.RuntimeResourcePack.getAllResourceLocations(RuntimeResourcePack.java:156) ~[diagonalfences:1.1.1]
	at fuzs.diagonalfences.resources.RuntimeResourcePack.func_195764_b(RuntimeResourcePack.java:99) ~[diagonalfences:1.1.1]
	at net.minecraft.resources.FallbackResourceManager.func_199004_b(FallbackResourceManager.java:102) ~[?:?]
	at net.minecraft.resources.SimpleReloadableResourceManager.func_199004_b(SimpleReloadableResourceManager.java:75) ~[?:?]

As far as I know, Minecraft resource packs are expected to be thread-safe, as there are multiple threads that load resources at once.

latest.log (Optional)

No response

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.20

Mod Version (Required)

1.20

Notes (Required)

Hi, when I use the diagonal fence mod it makes blocks like carpet, player head items, stained glass and stairs look like fences. When i delete diagonal fence mod its gone. The fences look like its 2 fences stacked together in one block space (like a regular fence and diagonal fence in one block entity).

latest.log (Optional)

No response

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2.5

Notes (Required)

First, I have to say it's not a fatal bug, just visually missing.

So, similarly to issue #36, the diagonal parts of the fence don't show up, but this time it involves "coverable" ("framed", "illusion") fences from BlockCarpentry. Due to the nature of these fences, I have no idea if you can do anything about this, but I still wanted to let you know.

If it's not fixable, one might suggest to disable diagonals for these (2) fences.

PS: BlockCarpentry's dev is currently over-stressed by their studies so not reachable for a long time, so I'll have to wait if the fix should be done on their side.

latest.log (Optional)

No response

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2.3

Notes (Required)

When using Snow! Real Magic! parts of the fence texture darkens when a diagonal fence post is near a block

latest.log (Optional)

No response

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19

Mod Version (Required)

DiagonalFences-v4.0.0-1.19-Forge

Notes (Required)

Crash during startup. Excerpts from output log:

Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered

Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [diagonalfences.common.mixins.json:FenceBlockMixin] from phase [DEFAULT] in config [diagonalfences.common.mixins.json] FAILED during APPLY

Caused by: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: @shadow method connectsTo in diagonalfences.common.mixins.json:FenceBlockMixin was not located in the target class net.minecraft.world.level.block.FenceBlock. Using refmap diagonalfences.refmap.json

Crash Report (Required)

https://pastebin.com/6D3WfK8h

latest.log (Optional)

No response

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.20.1

Mod Version (Required)

v8.0.0

Notes (Required)

When I play on a server, any server, the mod turn the kelp under water into fence columns.
When I remove the mod the kelp is back.
When I add the mod again it's fence.
It also turns glowstone and command blocks into fence.

It only happens when I play on servers, not single player.
Every time I want to play on servers I have to remove the mod.

The game also get really laggy when I play on servers.
When I remove the mod it's back to normal.

latest.log (Optional)

No response

Suggestion (Required)

Would it be possible to add stone walls to the mod, either as a default, or toggleable/addable via config? If not, maybe a separate mod for 'em?

Like fences

Hi! Wasn't sure how else to reach you. Given this is currently released under MPL, and what not, would you be opposed to me taking a snapshot of your current release and backporting it to 1.18.1 for my private server? I would not distribute it in that way to anyone other than my 4-5 players, and I would not allow them to submit bug reports to you (I will field any reports and test them in 1.18.2 before submitting them to you).

Is that alright by you?

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.16.5

Mod Version (Required)

1.1.1

Notes (Required)

Does not work with fences from Hal's Exploration mod

latest.log (Optional)

No response

Suggestion

I realize this is not a fence (unless you wanted to add glass fences) but I would love to see a diagonal glass panes mod. 🙂

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

v4.2.4

Notes (Required)

Animals in pens constantly walk towards the diagonal portion. Perhaps they perceive it as being open when it's not.

To reproduce, just have a pen and have animals in it.

latest.log (Optional)

No response

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

v4.2.3

Notes (Required)

I am guessing that this is happening because I am using an optifine resource pack. But there are nothing in the resource pack related to fences. Also using lambdabettergrass.

latest.log (Optional)

No response

When i use the mod, it crashes on startup with error code 1, does it need any external mods?

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

v4.2.5

Notes (Required)

getting this crash when trying to switch resource packs in prominence 1 forge

Crash Report (Required)

https://gist.github.com/Fuzss/b2d91ee1ca3193a391a783e87545252f

latest.log (Optional)

No response

Using river fences (Upgrade Aquatic), I made a fence around my house. For some weird reason, one part of it has glitched shade on it:

Not sure what I should include aside from this screenshot, so please tell me if anything is needed.

Diagonal Fences launches perfectly fine with PuzzlesLib 1.0.2, but versions 1.0.3-1.0.6 all crash on startup with the same error message.

latest.log (using 1.0.6 of PuzzleLib)
crash report

Versions:
Minecraft 1.16.5
Forge 36.1.32 (latest as of writing)
Diagonal Fences 1.1
Tested on a clean instance with no other mods.

Mod Loader

Fabric

Minecraft Version

1.19.3

Mod Version

5.0.0

Notes

Steps to reproduce:

1. Place two fences diagonally of each other
2. Stand in-between the fences on top of them
3. Hold sneak
4. Walk off the fence

Expected behaviour:
Player does not fall of the fence like what would happen if the fences were next to each other not diagonally

Actual behaviour:
Player falls off the block as if they were not sneaking

Suggestion (Required)

due to the nature of the modifications i would assume that any mod that allows similar mechanics for elevation connections would cause issues. not that im aware of any mods that have anything like that. as such im making the suggestion for not just vertically diagonal fences but all the missing connection types. i do understand its a tedious undertaking to define the elements for, what is it? 24 directions? would make building sailing ships and banisters easier for sure :D

Suggestion (Required)

Thank you very much! :)

It seems like as of now there are no diagonal fence mods for 1.18.x

Sorry if it's a bother, but i'm sure you can point all the people begging for ports here if they bother you.

Minecraft v1.16.5
Forge v36.1.4
Diagonal Fences v1.0.5
Assorted Decor v2.0.9

I discovered that the colorizer fence from Assorted Decor will not visually connect to each other. (Which can be used with the colorizer wand to change the texture to any block.)

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2.1

Notes (Required)

Got this result using Better MC modpack v4 and Sildur's Vibrant shaders v1.40 Lite... is there any compatibility issue between them? I tried to disable shaders but the problem still persists and they are just spruce fences from vanilla.

Also the resource packs applied are from these mods, adding nothing to the resource packs folder.

latest.log (Optional)

No response

Mod Loader (Required)

Forge

Minecraft Version (Required)

All since 1.18.2

Mod Version (Required)

N/A

Notes (Required)

Diagonal Fences (and Diagonal Windows) inject at the HEAD of uploadTextures to replace fence models. This is not compatible with ModernFix dynamic resources as it makes many changes to the model loading implementation.

It's best to use platform-provided model wrapping hooks (such as Model Loading API v1 on Fabric, or ModelBakeEvent on Forge) but if these are not suitable/available, I would suggest use of a ModifyVariable on cacheAndQueueDependencies instead, like so:

@ModifyVariable(method = "cacheAndQueueDependencies", at = @At("HEAD"), argsOnly = true)
private UnbakedModel replaceFenceModel(UnbakedModel model, ResourceLocation location) {
    
}

and then returning whatever model instance you want to get used. This avoids relying on the assumption that all models are going to be baked after onPrepareModelBaking is called.

The current solution I have been using is a mixin into Diagonal Fences internals but unfortunately the implementation has been changed, breaking the mixin, and this solution also isn't feasible to duplicate for a second "diagonal blocks" mod.

latest.log (Optional)

No response

I noticed this oddity while helping a user diagnose a crash. They had diagonal fences installed, but not puzzles lib, and the game was crashing in a way that failed to show up in the log - best I can tell, this is because your mixin to FenceBlock gets loaded, and causes PuzzlesLib to be loaded, too early in the process for forge to catch what is going on, or even for forge to write useful information to the log (The debug and latest logs contained no information about the issue, ending directly after some mixin information, while the issue was visible from the launcher log). This could be fixed by moving DIRECTION_TO_PROPERTY_MAP out of EightWayBlock, so that loading EightWayBlock does not immediately trigger the load of your library. I will probably put together a pull request for this, as it seems simple enough.