Code Monkey home page Code Monkey logo

combatnouveau's Introduction

combatnouveau's People

Stargazers

 avatar

Watchers

 avatar

combatnouveau's Issues

[Bug]: Impossible to set negative value for attack speed overrides

Mod Loader (Required)

NeoForge

Minecraft Version(s) (Required)

1.20.1

Mod Version(s) (Required)

8.0.3

Minimal Setup (Required)

Just CombatNouveau and Puzzlelib

Notes (Required)

#Format for every entry is "<namespace>:<path>,<amount>". Tags are supported, must be in the format of "#<namespace>:<path>". Namespace may be omitted to use "minecraft" by default. May use asterisk as wildcard parameter via pattern matching, e.g. "minecraft:*_shulker_box" to match all shulker boxes no matter of color.
attack_speed_overrides = ["minecraft:iron_sword,8.0", "minecraft:diamond_sword,-1"]

Expected:

  • ✅ Iron Sword to have +12 Attack Speed (Due Vanilla 4 + 8 Additional from mod)
  • ❌ Diamond sword to have 3 Attack speed (Due Vanilla 4 - 1 Attack speed from mod)

Actual result:

java.lang.IllegalStateException: Data -1.0 at index 0 from source entry minecraft:diamond_sword,-1 does not conform to filter

due filters defined at lines
https://github.com/Fuzss/combatnouveau/blob/main/1.20.4/Common/src/main/java/fuzs/combatnouveau/config/ServerConfig.java#L84-L88

This makes it impossible to make any kind of item slower than 4 (which is very quick already)
This filter seems pointless as Minecraft has no issues supporting negative attributes
Screenshot example produced with give command
image

/give @p diamond_sword{AttributeModifiers:[{AttributeName:"generic.attack_speed",Amount:-4,Slot:mainhand,Name:"generic.attack_speed",UUID:[I;-124123,789,13314,-1578]}]} 1

latest.log (Required)

https://mclo.gs/u4jG1nH

[Suggestion]: Release 1.19.2 Version

Mod Loader (Optional)

Forge

Minecraft Version(s) (Optional)

1.19.2

Mod Version(s) (Optional)

No response

Suggestion (Required)

I see you have a 1.19 version already created. Why is there no release for said version?

I tried building the folder myself, it did not succeed on my end tho, probably due to user error.

Could not open cp_settings generic class cache for settings file 'X:\Downloads\combatnouveau-main\1.19.2\settings.gradle' (C:\Users\...\.gradle\caches\7.6\scripts\clsvq5oupataa5vjkjxfse8l3).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 65

I would be more than grateful if you could offer a release for this version as well ^^

[Bug]: Combat Nouveau crashes with Biome Makeover, JEI is also broken

Mod Loader (Required)

Forge

Minecraft Version(s) (Required)

1.20.1

Mod Version(s) (Required)

8.0.2

Minimal Setup (Required)

Yes

Notes (Required)

  1. Install the 2 mods together with their respective libraries
  2. Load into creative or whatever, look up ite
    ms on JEI (notice they're broken)
  3. If you get a biome makeover item, it crashes sometimes
    2024-02-11_15 27 15

latest.log (Required)

https://gist.github.com/BugmanBugman/67f579ea386943ade3dadc6dccdbd4ed

[Bug]: Weapon attack reach does not work

Mod Loader (Required)

Fabric

Minecraft Version(s) (Required)

1.20.4

Mod Version(s) (Required)

CombatNouveau-v20.4.5-1.20.4-Fabric.jar

Minimal Setup (Required)

Yes

Notes (Required)

Swords, hoes, and tridents do not have the increased reach benefit as intended, they hit mobs just as far as an axe or by hand.

This is tested with the default generated config and in survival mode.

latest.log (Required)

nil

[Crash]: when damage source is fire, game will crash.

Mod Loader (Required)

NeoForge

Minecraft Version(s) (Required)

1.20.1

Mod Version(s) (Required)

8.0.4

Minimal Setup

No

Notes (Required)

  1. held shield on offhand,
  2. got some fire damage like walking on magma block or Blaze's fireball,
  3. the game will crash high probability.

Crash Report (Required)

https://gist.github.com/854342681/4f88dfed251df55e313af35187ab8906

latest.log (Optional)

https://gist.github.com/854342681/bd1a25866edd6b5d84c94d965ce4c4b8

[Bug]: Shield indicator off-center

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.20.1

Mod Version (Required)

N/A

Notes (Required)

image

latest.log (Optional)

N/A

[Bug]: hitbox size

Mod Loader (Required)

Forge

Minecraft Version(s) (Required)

1.20.1

Mod Version(s) (Required)

8.0.3 - 8.0.4

Minimal Setup (Required)

Yes

Notes (Required)

#This only affects targeting an entity, no collisions or whatsoever. Useful for hitting e.g. bats, rabbits, silverfish, fish, and most baby animals min_hitbox_size = true breaks any resource warehouse that has item frames.
Apparently, increasing the hitbox also works on the frames
A banal wall of rotated double chests with frames cannot be opened

latest.log (Required)

It is unlikely that a log is required for this problem

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.