fuzss / bagofholding Goto Github PK

Mod Loader (Optional)

Forge

Minecraft Version(s) (Optional)

1.20.1

Mod Version(s) (Optional)

No response

Suggestion (Required)

I noticed that the recipes don't use the forge:leather, forge:string, and forge:chests tags.

Would be nice if all of them used those tags.

Mod Loader (Required)

Forge

Minecraft Version(s) (Required)

1.20.1

Mod Version(s) (Required)

8.0.2

Minimal Setup (Required)

Yes

Notes (Required)

Bundles should be blacklisted by default.

Also, I think the default blacklist should include the Backpack from Quark (and maybe the Seed Pouch too?) and the Satchel from Thermal Expansion.

I also think having the default blacklists use the config would be good since it gives pack devs a bit more control over the mod.

(I also noticed that the order of each bag in the config doesn't match the tier order, with it being iron -> leather -> gold instead of leather -> iron -> gold. Bit annoying, and it'd be nice if they matched)

latest.log (Required)

I don't think it'd be needed for this, but I can add it if you want.

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.20.1

Mod Version (Required)

8.0.1

Notes (Required)

I had an already working modpack, I added your mod and I crashed. I am just wondering if your mod works for the latest Fabric version. The crash I get is a generic crash that usually has been happening when the mod doesn't work with that version. I have included the log and crash log, it says "lucky" but it is not lucky blocks, hopefully you can assist. Thank you

Crash Report (Required)

https://gist.github.com/Gamerbolts/f70092fdc4871129aa5577f07faa2e93

latest.log (Optional)

https://gist.github.com/Gamerbolts/8de2877f85c5d55fbc446753dcb4ffdc

Suggestion (Required)

Hi, this mod looks amazing! Does it work on 1.19.4, and if not, any plans on updating it (and if-so, when)? Thanks!

Suggestion (Required)

Please provide this, it's unfeasible to do this through tools like KubeJS due to how it's coded (no datapacks).

Mod Loader (Required)

Fabric

Minecraft Version(s) (Required)

1.20.4

Mod Version(s) (Required)

v20.4.1

Minimal Setup (Required)

Yes

Notes (Required)

Requires Puzzles Lib v20.4.31, which is unavailable on Modrinth
Refuses to launch without it

latest.log (Required)

https://pastebin.com/MieDCHtD

Suggestion (Required)

When I play, I often have 1 golden bag of holding for quick access tools (which I call Ryobi or Rigid because those are power tool brands), and then one for a dump pouch to pick up loot while adventuring. The dump pouch is one of many that live in my ender chest, as well as a few other bags that live in my ender chest. All those bags look the same, so it would be nice to have a visual indicator of things that are assigned. I use Shulker Box Tooltip to show the inventory on a mouseover, and it works with your bags too.

Shulker boxes can be dyed, and before I installed Bags of Holding, I used a lime green shulker box (named Ryobi) as my tools chest, and a natural colored one as a sort of dump pouch. I also have several color coded shulker boxes in my ender chest so that I know what's in them based on my color scheme.

Leather can be dyed in minecraft, and we now have a color customization infrastructure with the various armor trims. Either or both systems could be applied to the bags of holding, depending on your preference.

For another example, Reinforced Shulker Boxes wind up with a two tone color based on what color they are dyed and what kind of shulker box they are. I think that might be a good idea for the bags of holding too; an accent color instead of a full color change.

Suggestion (Required)

Since there usually wind up being 5 tiers for things like this (leather, iron, gold, diamond, netherite), I think that would be cool to add 2 more tiers to the Bags of Holding. The recipes might need to change if you do that though. With the Reinforced Shulker Boxes mod, the netherite shulker box has the same size inventory as the diamond one, but a different accent color, and is immune to lava. If you don't want the bags to get larger inventories, for netherite bags of holding, you might offer a similar lava-immunity power instead of increasing the inventory size.

Speaking of special powers for the bags, have you considered making the pags work with shulker box enchantments like EnchantedShulkers? If you extend shulker boxes, which I think you do, they might already work, but I have not tried it yet. I think there are only 1 or 2 different mods that add enchantments to shulker boxes though.

Mod Loader (Required)

Fabric

Minecraft Version(s) (Required)

1.20.1

Mod Version(s) (Required)

v8.02

Minimal Setup (Required)

Yes

Notes (Required)

On our server we wanted the iron and gold bags to be less overpowered since there were so cheap to make, so we reduced the rows to 2 and 3 respectively.

When the bag was opened the rows would still be the same and whatever is in your hot bar, even the bag itself is duped. Only effects the bag which rows were changed.

latest.log (Required)

N/A

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.1.6

Notes (Required)

saw this in my logs, thought you'd want to know. Mod works fine for me but I assume this causes an issue I don't run into

[Render thread/ERROR] [Puzzles Lib/]: Calling client config when it is not yet available! This is a bug! Message: Config data is missing
java.lang.Exception: Config not yet available
	at fuzs.puzzleslib.config.ForgeConfigDataHolderImpl.lambda$testAvailable$1(ForgeConfigDataHolderImpl.java:45) ~[PuzzlesLib-v4.3.12-1.19.2-Forge.jar%23532!/:4.3.12] {re:classloading}
	at com.mojang.datafixers.util.Either$Right.ifRight(Either.java:109) ~[datafixerupper-5.0.28.jar%2393!/:?] {}
	at fuzs.puzzleslib.config.ForgeConfigDataHolderImpl.testAvailable(ForgeConfigDataHolderImpl.java:44) ~[PuzzlesLib-v4.3.12-1.19.2-Forge.jar%23532!/:4.3.12] {re:classloading}
	at fuzs.puzzleslib.config.ConfigDataHolderImpl.getOrCreateDefaultConfig(ConfigDataHolderImpl.java:70) ~[PuzzlesLib-v4.3.12-1.19.2-Forge.jar%23532!/:4.3.12] {re:classloading}
	at fuzs.puzzleslib.config.ConfigDataHolderImpl.config(ConfigDataHolderImpl.java:59) ~[PuzzlesLib-v4.3.12-1.19.2-Forge.jar%23532!/:4.3.12] {re:classloading}
	at fuzs.puzzleslib.config.ConfigHolder.get(ConfigHolder.java:28) ~[PuzzlesLib-v4.3.12-1.19.2-Forge.jar%23532!/:4.3.12] {re:classloading}
	at fuzs.bagofholding.client.BagOfHoldingClient.onRegisterItemDecorations(BagOfHoldingClient.java:40) ~[BagOfHolding-v4.1.6-1.19.2-Forge.jar%23380!/:4.1.6] {re:classloading}
	at etc

latest.log (Optional)

No response

Mod Loader (Optional)

Fabric

Minecraft Version(s) (Optional)

1.20.4

Mod Version(s) (Optional)

No response

Suggestion (Required)

A config option which allows to insert items with inventories (such as shulkerboxes) into bags would be helpful, since some modded containers (extended drawers e.g.) can't be put into the bags, which is kind of annoying, even if the containers are empty.

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

v4.1.6

Notes (Required)

Server config is enabled:
#Allow using the mouse wheel to scroll between slots to choose the next item to extract when hovering over a container item. allow_slot_cycling = true

However, in-game the functionality is not working, the slot is stuck/fixed at the last item in the bag.

Recently updated multiple mods/mod library packages (incl. fabric-language-kotlin). Also updated Fabric loader to 0.14.21

latest.log (Optional)

https://gist.github.com/Trynthlas/f9dfa98df000c2e849169bc8f4e916a2

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.20.1

Mod Version (Required)

8.0.0

Notes (Required)

I think this is a Bedrockify issue, because the behavior is correct with that disabled or downgraded to the previous version. Wanted to include it here in case you want to take a look, though. Details are here: juancarloscp52/BedrockIfy#310

latest.log (Optional)

No response

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.20

Mod Version (Required)

BagOfHolding-v7.0.0-1.20-Forge and PuzzlesLib-v7.0.9-1.20-Forge

Notes (Required)

1. Copy BagOfHolding-v7.0.0-1.20-Forge and PuzzlesLib-v7.0.9-1.20-Forge into the MC Forge 1.20 Server and the MC Forge 1.20 Client Mods folders.

2. Start Server (Server Log attached)

3. Launch OptiFine 1.20-OptiFine_HD_U_15_pre3 Installation from Minecraft Launcher v. 2.4.104-1.2.16

4. Minecraft 1.20 Landing Page is loaded (Image attached)

5. Click on Multiplayer button and load Server List (image attached)

6. Click on MC Forge 1.20 Server to run and get INSTANT "Failed to connect to the server" error message (image attached)

7. Same error on the Server side:
   [13:15:57] [Netty Server IO #2/ERROR] [ne.mi.ne.NetworkRegistry/NETREGISTRY]: Channels [iteminteractionscore:play,bagofholding:play] rejected vanilla connections
   [13:15:57] [Netty Server IO #2/INFO] [ne.mi.se.ServerLifecycleHooks/SERVERHOOKS]: Disconnecting VANILLA connection attempt: This server has mods that require Forge to be installed on the client. Contact your server admin for more details.
   [13:40:51] [Netty Server IO #4/ERROR] [ne.mi.ne.NetworkRegistry/NETREGISTRY]: Channels [iteminteractionscore:play,bagofholding:play] rejected vanilla connections
   [13:40:51] [Netty Server IO #4/INFO] [ne.mi.se.ServerLifecycleHooks/SERVERHOOKS]: Disconnecting VANILLA connection attempt: This server has mods that require Forge to be installed on the client. Contact your server admin for more details.

8. Not sure why this isn't working, it has always worked in the past, however, this is a brand new server, so I'm sure I've done something wrong. Anything you can do to help is much appreciated!

Server Log_06.19.23_1.15 PM.txt
Latest Client Log_06.19.23_1.15 PM.log

Crash Report (Required)

I don't have a Crash-Report Folder (Image attached)

latest.log (Optional)

No response

Suggestion (Required)

Hi there, thanks for the awesome mod

I was wondering, would it be possible to add support for Inventory Tabs mod? https://github.com/Andrew6rant/inventorytabs

Upon using the Bag of Holding as a held item, its inventory seemingly opens like how you'd expect a chest inventory to look
So it made me wonder if it'd be possible to register it into Inventory Tabs mod as an additional tab, thus allowing the bag to simply exist somewhere in player's inventory

Suggestion (Required)

I have a mod that adds a Soulbound enchantment - I'd prefer if I could disable the Preservation enchantment entirely.