fuzss / armorstatues Goto Github PK

Suggestion (Required)

I'm trying to use the 'Armor Stand Shift Swap' alongside your mod but since both rely on shift right clicking the armor stand, and since neither allows to remap the trigger button, it would be nice if you could add a simple way to remap the shift right click to something like alt right click.

Feature request:

• Ability to remap trigger. Example: 'alt + right click'

Mod Loader (Required)

Quilt

Minecraft Version (Required)

1.19.2

Mod Version (Required)

v4.0.8

Notes (Required)

1. place an armor stand
2. go into adventure mode
3. armor stand is still editable

I think armor stands should only be editable in modes, where you can build (e.g. survival and creative).

latest.log (Optional)

No response

Mod Loader (Optional)

Fabric

Minecraft Version(s) (Optional)

No response

Mod Version(s) (Optional)

No response

Suggestion (Required)

being able to cycle through armor stands near you(5 blocks) would be great for projects with many armor stands. A simple left and right arrow in the GUI would suffice

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.0.4

Notes (Required)

According to the discription I am supposed to press shift and right click to open the menu, and an other youtuber said crouch and right click, but non of them work.

latest.log (Optional)

No response

Mod Loader (Required)

Fabric

Minecraft Version(s) (Required)

1.20.1

Mod Version(s) (Required)

v8.0.5

Minimal Setup (Required)

Yes

Notes (Required)

The textures for the armor stand customization screen are literally missing from the jar file. And the customization screen doesn't open up at all. If it did, you would see eye-piercing checkerboards of magenta and black, which is better than HAVING THE ENTIRE F###ING ARMOR STAND CUSTOMIZATION SCREEN MISSING.
I'm actually lying about the "minimal setup" one, because as I mentioned earlier, the entire textures folder is missing from the jar.

latest.log (Required)

https://gist.github.com/MCAlexisYT/c4ef51684a37a1bd1d5523d339ded09e

Suggestion (Required)

The tool tip says "Shift+Right Click" but it should read "Sneak+Right Click" as its bound to whatever your sneak key is even if you changed it from shift.

Suggestion (Required)

Any future updates planned?

Mod Loader (Required)

Forge

Minecraft Version(s) (Required)

1.19.2

Mod Version(s) (Required)

4.0.8

Minimal Setup (Required)

No

Notes (Required)

Unable to test for Minimal setup due to uniqueness of issue

This is somewhat in relation with #32 as he and I are on mutual servers. Not sure why he is having issues though as he is likey using the same pack and I managed to get though boot; odd.

Anyhow besides the point, the issue here is that I crash when trying to interact with the armor stand. The mod is NOT present on the server, but the Vanilla Tweaks Datapack that the mod advertises it having serverside compact for is present; hence why I am unable to verity if this is a minimal setup reproducible. For best Results in the case that this needs to be a 1:1 case, please use the pack https://www.curseforge.com/minecraft/modpacks/create-technical-4 and add the VT addon into a dedicated environment and a client with the mod in question.

latest.log (Required)

S

Suggestion (Required)

or disable the requirement for an item

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

ArmorStatues-v4.0.0-1.19.2-Forge.jar

Notes (Required)

Hi. Recently, I added Armor Statues mod with my on-going modpack with my friends. But when I shift-clicked armor stand, sever immediately crashed. I'm really sucked at reading crash / latest log, so could you help me to find which problem causes the crash? If there're too many mods, I will isolate them when I have enough time. Thanks in advance.

PuzzlesLib-v4.3.10-1.19.2
ArmorStatues-v4.0.0-1.19.2
rubidium-0.6.2.jar
oculus-mc1.19.2-1.2.8.jar
canary-mc1.19.2-0.0.4.jar
pluto-mc1.19.2-0.0.1.jar
saturn-mc1.19.2-0.0.1.jar
+@

Crash Report
https://gist.github.com/RedBeast1959/5ef52e5a26909a1353f90f207a80c2aa

Latest log
Below

latest.log (Optional)

https://gist.github.com/RedBeast1959/2be98af7037571a78a0ba570e254ab46

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.20.1

Mod Version (Required)

v8.0.3

Notes (Required)

Current behavior: When i try to edit the settings of the arms orientation in the server's console i get [Netty Epoll Server IO #4/ERROR] [ne.mi.ne.si.IndexedMessageCodec/SIMPLENET]: Received invalid discriminator byte 3 on channel puzzlesapi-2:play. Also if you rejoin the game or restart the server the armor stand "forgets" what i set on it (i only tried for the orientation settings as the other settings just crash my client - not the server). The only thing it retains its his normal java behavior of keeping armor on it.

Steps to reproduce:

1. Edit armor arms
2. You get the error in the console
3. Rejoin
4. The armor stand is now normal (without what you set on him)

Expected: To be able to set it up and for it to retain the settings, also to not crash my client whenever i try to change other settings from the armor (I only tried "Styles" tab as i was afraid it will crash on the others too.

latest.log (Optional)

https://gist.github.com/FireBoy00/5aee907d48a466c6760837337efa6052

Suggestion (Required)

Hey, just started using this mod along side a pretty heafty modpack and theres a conflict with ctrl/shift+right click and it wont let me access the config screen for the stands, it just places my armor set on the stand (prolly through some mod)
Thanks!

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.20.1

Mod Version (Required)

v8.0.3

Notes (Required)

Crash on initialization
Incompatibility with Combatify more specifically with the Cookey Mod which is a library mod embedded in the .jar of Combatify.

Crash Report (Required)

https://gist.github.com/Afrocntrik/568cb2b3d6a106aa986c397e4945b963

latest.log (Optional)

No response

Suggestion (Required)

I saw a different mod (Armor Stand Shift Swap) now enable shift+r-click to swap your current armor with that in the armor stand.
Not sure if this is an easy feature to implement into the armor statues mod?
Since the editing of an armor statue has been moved to you needing a stick equipped, maybe shift+r-click without a stick could work for such a feature?
Or perhaps a different hotkey even, if shift+r-click clashes with other mods?

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.0.4

Notes (Required)

I start the game via the launcher and after a couple seconds it crashes. The game window itself wont even open.

Crash Report (Required)

https://mclo.gs/9hGETVl

latest.log (Optional)

https://mclo.gs/5eubzJv

Mod Loader (Required)

Forge

Minecraft Version(s) (Required)

1.19.2

Mod Version(s) (Required)

4.0.8

Minimal Setup (Required)

No

Notes (Required)

Unable to test for Minimal setup due to uniqueness of issue

This is somewhat in relation with #32 as he and I are on mutual servers. Not sure why he is having issues though as he is likey using the same pack and I managed to get though boot; odd.

Anyhow besides the point, the issue here is that I crash when trying to interact with the armor stand. The mod is NOT present on the server, but the Vanilla Tweaks Datapack that the mod advertises it having serverside compact for is present; hence why I am unable to verity if this is a minimal setup reproducible. For best Results in the case that this needs to be a 1:1 case, please use the pack https://www.curseforge.com/minecraft/modpacks/create-technical-4 and add the VT addon into a dedicated environment and a client with the mod in question.

latest.log (Required)

https://gist.github.com/Shibva/a626c5b84a03f4cba4a2470a306e1c08

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

v4.0.1

Notes (Required)

Current bug
When configuring an armor stand in-game, the pose previews are covered in black "sectors", making it impossible to see the poses.
While narrowing down the cause of the bug, I discovered that it was FancyMenu that generated this bug, since removing that mod would solve the issue.
The armor stand entities (the poses themselves) seem to render behind those black sectors, as indicated by equipment poking through some of the pose previews when equipped to the armor stand.

Steps to reproduce

1. Have ArmorStatues and FancyMenu installed
2. Place an armor stand in the world
3. Shift-click on the stand and navigate to the Poses tab

Screenshot of the bug

latest.log (Optional)

No response

Mod Loader (Required)

Forge

Minecraft Version(s) (Required)

1.19.2

Mod Version(s) (Required)

v4.0.8

Minimal Setup

No

Notes (Required)

install mod, dependencies, and create
run game, crash

Crash Report (Required)

https://gist.github.com/MR-Spagetty/a1ab6304df614211d706cb47f76b95d3

latest.log (Optional)

No response

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.0.2

Notes (Required)

When having the mod, tablist doent work anymore. client log doesnt throw any errors.

latest.log (Optional)

No response

Mod Loader (Optional)

Fabric

Minecraft Version(s) (Optional)

No response

Mod Version(s) (Optional)

No response

Suggestion (Required)

Being able to open the last edited armor stand would be great. Could attach it to a keybind. It's quite hard to see where an armor stand is moving with a large GUI in the way and this way you could make minor adjustments and close the GUI to check what you were doing without editing all of the other armor stands

Suggestion (Required)

As the title says, if the armor statues datapack by vanilla tweaks is installed into the world, and the user does not have permission to use the /data modify command and the mod is not installed server side, to use the /trigger options from vanilla tweaks.

This will allow for even more useage, however it would mean it might take some time to modify stands as it would have to run several /trigger commands to achive the desired look.

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.0.1

Notes (Required)

I check the small figure, and it looks like the helmet is too big for it. Is this intentional?
Can I get the overall small size?

latest.log (Optional)

No response

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.0.4

Notes (Required)

It looks like the configs for this version of the mod are not generating for either the Client, Server, or Common. I've tried directly editing configs with Forge Config API and I've tried using the /CONFIG command to locate the files, but no such luck.

latest.log (Optional)

No response

Suggestion (Required)

Is it possible to create add a GUI that allows you to put an item onto an Armor Stand - Eg: Red Stained Glass Block on Head
Since when I shift + right click, it just takes off whatever piece of armor it's wearing

Edit:
Was just playing around on Singleplayer
There does appear to be some sort of GUI already built in, however possibly expanding the functionality to work on servers
Possibly by ignoring permissions and doing /modify effectively (idk how stuff works)

Suggestion (Required)

As above, so below

Mod Loader (Required)

Fabric

Minecraft Version(s) (Required)

1.20.4

Mod Version(s) (Required)

20.4.0

Minimal Setup (Required)

No

Notes (Required)

While playing on a server shift right-clicking an armour stand grabs an item off of it at the same time as the GUI opens:

I'm not sure if it's affected by any plugins or datapacks on the server, so I chose "no" to the previous question, but from what I understand there's nothing on the server I'm on that modifies this behaviour. The 2 relevant additions are Advanced Armor Stands and the Vanilla Tweaks datapack. I have the Vanilla Tweaks integration enabled and everything works flawlessly, besides grabbing the items.

The person in #26 experienced the same issue, but didn't specify their server's details.

The issue doesn't happen in single-player so it's definitely something to do with servers. I tried without the mod and in both single-player and multi-player the item is grabbed when sneak right-clicking an armour stand, so maybe the mod fails to prevent that from happening in multi-player for whatever reason?

latest.log (Required)

No relevant logs

Suggestion (Required)

Just a request to update to 1.20.4

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.0.2

Notes (Required)

When trying to interact with an Immersive Paintings Entity (https://github.com/Luke100000/ImmersivePaintings) a suppressed error is thrown, preventing further actions:

java.lang.NullPointerException: Cannot invoke "net.minecraft.class_3966.method_17784()" because "entityHitResult" is null
	at fuzs.armorstatues.ArmorStatuesFabric.lambda$registerHandlers$0(ArmorStatuesFabric.java:30) ~[ArmorStatues-v4.0.2-1.19.2-Fabric.jar:?]
	at net.fabricmc.fabric.api.event.player.UseEntityCallback.lambda$static$0(UseEntityCallback.java:57) ~[fabric-events-interaction-v0-0.4+562bff6e90-12406b410890a6fe.jar:?]
	at net.minecraft.class_3244$1.handler$cln000$onPlayerInteractEntity(class_3244.java:1815) ~[client-intermediary.jar:?]
	at net.minecraft.class_3244$1.method_34219(class_3244.java) ~[client-intermediary.jar:?]
	at net.minecraft.class_2824$class_5909.method_34213(class_2824.java:116) ~[client-intermediary.jar:?]
	at net.minecraft.class_2824.method_34209(class_2824.java:66) ~[client-intermediary.jar:?]
	at net.minecraft.class_3244.method_12062(class_3244.java:1668) ~[client-intermediary.jar:?]
	at net.minecraft.class_2824.method_12251(class_2824.java:53) ~[client-intermediary.jar:?]
	at net.minecraft.class_2824.method_11054(class_2824.java:13) ~[client-intermediary.jar:?]
	at net.minecraft.class_2600.method_11072(class_2600.java:22) ~[client-intermediary.jar:?]
	at net.minecraft.class_3738.run(class_3738.java:18) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.method_18859(class_1255.java:157) ~[client-intermediary.jar:?]
	at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:776) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:159) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.method_16075(class_1255.java:131) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:758) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:752) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.method_18857(class_1255.java:140) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:737) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:669) ~[client-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[client-intermediary.jar:?]
	at java.lang.Thread.run(Thread.java:833) [?:?]

Happening here:
https://github.com/Fuzss/armorstatues/blob/1.19/Fabric/src/main/java/fuzs/armorstatues/ArmorStatuesFabric.java

It seems entityHitResult can indeed be null. I was not able to spot an issue on my side, and I don't think a null check would hurt anyways.

UPDATE: player just appended that it happens with other entities too, it is not directly related to the painting. I assume some mod produces nulls.

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.0.4

Notes (Required)

Installed Mods:
Armor Statues 4.0.4
Straw Statues 4.0.10
JEI 11.6.0.1013
Puzzles Lib 4.3.12
Forge 43.2.6

Issue:
If I try to enable the arms on the statue, or move it with the gui, or press some of the other checkboxes, the server will kick me off, with an error like:
Internal Exception: io.netty.handler.codec.EncoderException: java.io.EOFException: fieldSize is too long! Length is 56320, but maximum is 21
or
Internal Exception: java.lang.IndexOutOfBoundsException: index 4, length: 11839 (expected: range(0,25))
or
Internal Exception: java.lang.IndexOutOfBoundsException: readerIndex(17) + length(8) exceeds writerIndex(21): PooledUnsafeDirectByteBuf(ridx:17, widx:21, cap:21)

No seemingly related errors appear in the log, these errors just appear on the client screen with the button to return to server selection.

I've tried using Connectivity and/or XL Packets to see if they resolve the issue, but they don't seem to. The Straw Statue causes similar problems.

Sometimes, rather than simply booting me off the server, it will crash the client.

latest.log (Optional)

https://mclo.gs/FpYRC0i

Suggestion (Required)

Is it possible for this mod (Armor Statues) to be expanded to use * perms/option to ignore op and just try to run the commands regardless of permission?
I have the * perm in LuckPerms as most servers disable operator itself and rely on the * perm, but it tells me that I don't have permission, even though I have access to /data (and everything else, just not op).