Comments (7)
Replaced WordPress repos plugin with GitHub master and a different error
[12-Jan-2016 07:36:32 America/New_York] PHP Warning: preg_match(): Compilation failed: missing ) at offset 22 in wp-content/plugins/autoptimize/classes/autoptimizeStyles.php on line 650
from autoptimize.
There indeed was a bug in 2.0.0 for those that activated the font-cdn-filter as reported by deny. This has already been fixed here on Github and will be in AO 2.0.1.
from autoptimize.
ah, a missing ), let me quickly check that out..
from autoptimize.
Should "#(background[^;}]*url\(#Ui"
become "#\(background[^;}]*url\(#Ui"
?
If so, will the regex match if there is a space between the '(' and 'background"? Should it match?
from autoptimize.
Still looking, but I think I simply forgot to remove the opening ( in the regex;
preg_match("#background[^;}]*url\(#Ui",$css)
can you try that?
frank
from autoptimize.
OK, the fix is live on this site if you want to look at the css
Sorry my regex skills aren't that great, but it looks like the expression is trying to match a line that is a background declaration ending with a semicolon. Is it going to be a problem for CSS lines that do not end with the semicolon, as is sometimes the case with valid single attribute css statements like
body {
background-image: url("paper.gif")
}
from autoptimize.
no, as it also looks for }
, which it finds (on the next line), cfr. https://regex101.com/r/kU1kA7/1
not a regex-specialist either, but regex101.com is a huge help :-)
from autoptimize.
Related Issues (20)
- Make compatibility configurable HOT 8
- Compatible wih WP 6 and PHP 8.1 HOT 1
- Keep the code base clean HOT 3
- Undefined offset autoptimizeStyles.php HOT 3
- autoptimizecriticalcsscron PHP array key warnings HOT 5
- Avif support broken HOT 6
- Minified JS broken with private class identifiers HOT 4
- Disable emoji dns-prefetch in ClassicPress HOT 1
- PHP8 Warning HOT 1
- Optimized JS and inline script order HOT 3
- Problem with media="print" HOT 3
- Inline "background" not replaced with shortpixel HOT 5
- Security risk reported by Kaspersky HOT 6
- Proposal: stronger default settings HOT 9
- Optimised Google Fonts still blocking for 1.3s according to PageSpeed HOT 2
- Add: option to enable WebP as default output format HOT 1
- PHP Warning in cronjob: Trying to access array offset on value of type int in autoptimizeCacheChecker.php HOT 3
- Creation of dynamic property in autoptimizeProTab.php HOT 4
- Proposal: add Plugin Check workflow HOT 6
- Autoptimize deletes all subfolders in /cache/ HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autoptimize.