Proposal: add Plugin Check workflow about autoptimize HOT 6 CLOSED

re. the output; it's very verbose, but it is missing what seems to be essential; the file and line number for which the warning/ error was thrown?

@futtta That's just the raw console log output. Every warning/error is filed as an annotation directly in-line within each file. Very useful for PRs. See https://github.com/futtta/autoptimize/actions/runs/7432069708 for a list of files and each warning.

By the way some of the checks (e.g. the database query ones) are likely not accurate for your own project, especially when already using PHPCS anyway, so running the same checks twice would be redundant. You could exclude them from running if desired.

from autoptimize.

well, simply merging seems to have triggerer the plugin check :)

thanks for the suggestion, best wishes for 2024 @adamsilverstein !

from autoptimize.

I see the workflow hasn't run, maybe they aren't enabled on the repo?

what isn't enabled on the repo exactly @adamsilverstein ?

from autoptimize.

what isn't enabled on the repo exactly @adamsilverstein ?

Maybe running actions or workflows for the repository?

I was expecting the action I added in the PR to have run, even though it isn't merged yet. Maybe I have something wrong in the workflow file, I will try merging it to my fork to see what happens.

You can see a similar PR I opened in Yoast - Yoast/wordpress-seo#20808 and the resulting plugin checker run - https://github.com/Yoast/wordpress-seo/pull/20808/checks

from autoptimize.

The action does seem to run when I opened the PR against my fork, so it is either account or repo related: https://github.com/adamsilverstein/autoptimize/actions/runs/6897518991/job/18765843941?pr=2

from autoptimize.

No idea why it doesn't seem to work on my end (not into github that way), but wow that's a lot of errors/ warnings ...

Most are due to AO being kind of ancient and thus not using all the newer wordpress-specific alternative functions (e.g. WP_Filesystem functions or wp_json_encode or wp_parse_url), but most of those I'm not eager to change in the context of "don't fix what is not broken" ;-)

Will have to change a lot of _e to _esc_html_e though (and similar) ... ;-)

re. the output; it's very verbose, but it is missing what seems to be essential; the file and line number for which the warning/ error was thrown?

from autoptimize.