WP Filesystem API vs. file_put_contents() about autoptimize HOT 9 CLOSED

Absolutely correct, but will require substantial refactoring, esp. to make sure the links to autoptimized CSS/ JS result in the cached CSS/ JS being fetched from FS/ GAE cloud storage bucket.

Giving this complexity and given the fact this isn't a feature anyone has ever requested (except you, here, now), I'll consider this of low priority.

frank

from autoptimize.

I did quick web-search on "wp_filesystem google app engine" I find no (immediate) confirmation that wp_filesystem automagically solves any filesystem issues. From what I read on https://cloud.google.com/appengine/docs/php/googlestorage/ the way to write files is by using the:

Google Cloud Storage stream wrapper is built in to the run time, and is used when you supply a file name starting with gs://.

While WP's filesystem API tries to write using local filesystem, ftp or ssh.

So although I understand GAE has it's challenges (and AO won't work on there for now), I don't think wp_filesystem is the solution?

frank

from autoptimize.

I think this plugin provides the WP FileSystem API implementation:
https://wordpress.org/plugins/google-app-engine/

from autoptimize.

And WP's filesystem API would support any custom filesytem.
BTW I am planning to use https://github.com/kasparsd/minit/tree/feature/restructure

from autoptimize.

I think this plugin provides the WP FileSystem API implementation:
https://wordpress.org/plugins/google-app-engine/

I checked the code, and no, it does not extend wp_filesystem, it "only" has code to do mail, http-requests and file-uploads using GAE.

And WP's filesystem API would support any custom filesytem.

Had a look at the code (again) and It does not; it "only" supports direct file access, ftp (+ variation for ftp) or ssh, all of which won't work on GAE. This is the very reason why on GAE you actually have to update wp core, theme & plugins on your local machine and then deploy to GAE (as described on this page, under "8.Prepare local site for upload";

Run all available updates, you will not be able to do this when the site is uploaded. To install plugins and updates you have to do it locally and then reupload. Therefor it’s a good idea to keep your local environment to be able to take care about this later on.

So the conclusion; wp_filesystem does not help us to make AO work on GAE. This does not mean using wp_filesystem would be entirely useless, but there's no clear, outspoken advantage in doing so either.

frank

from autoptimize.

Thank you.

but a role of thumb is that caching and minifying plugins won’t work.

😄

from autoptimize.

but a role of thumb is that caching and minifying plugins won’t work.

yeah ... I think I could make it work (writing the optimized files using Google Cloud Storage stream wrapper and injecting links to optimized code of the type wp-content/plugins/autoptimize/gae.php?id=xyz.css with gae.php using the stream wrapper to read the file), but it would introduce some complexity that -given the low amount of WP on GAE- I feel is not really worth it.

anyway, thanks for challenging me, I learned from it :-)

frank

from autoptimize.

I think when a project uses GAE resources are optimized during the build process.

from autoptimize.

Doesn't look like it when checking the HTML source on https://gae-php-tips.appspot.com/...

There used to be mod_pagespeed integration in GAE, but that was turned off late 2015.

from autoptimize.