furkandeveloper / easycronjob Goto Github PK

Summary

Hi! Can you please add the ability to specify seconds in cron expression? Need to run a task every 10 seconds.

Additional context
I saw that for parsing expressions you used Cronos, and in its Parse method there is an overload for include seconds
CronExpression expression = CronExpression.Parse("*/10 * * * * *", CronFormat.IncludeSeconds);

Summary

Must be BaseService for run cronjob.

This service must be abstract class.

Codacy detected an issue:

Message: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread.

Currently on:

• Commit: 5297d05
• File: src/EasyCronJob.Abstractions/CronJobService.cs
• LineNum: 59

Codacy detected an issue:

Message: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread.

Currently on:

• Commit: 5297d05
• File: src/EasyCronJob.Abstractions/CronJobService.cs
• LineNum: 44

Codacy detected an issue:

Message: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread.

Currently on:

• Commit: 5297d05
• File: src/EasyCronJob.Abstractions/CronJobService.cs
• LineNum: 69

Codacy detected an issue:

Message: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread.

Currently on:

• Commit: 5297d05
• File: src/EasyCronJob.Abstractions/CronJobService.cs
• LineNum: 49

Summary

Must be configurable cron jobs. So ICronConfiguration uses object with get cron configuration.

In that must be define;

    /// <summary>
    /// This interface includes base parameter for Cron Job.
    /// </summary>
    /// <typeparam name="T">
    /// Cron Job
    /// </typeparam>
    public interface ICronConfiguration<T>
    {
        /// <summary>
        /// Cron Expression. For Example; '****' Cron.Minutely
        /// </summary>
        public string CronExpression { get; set; }

        /// <summary>
        /// TimeZone Information
        /// </summary>
        public TimeZoneInfo TimeZoneInfo { get; set; }
    }

Describe the bug
I have a very simple Job like this:

public class Test : CronJobService
    {
        public TimTest(ICronConfiguration<TrainingsReminderJob> cronConfiguration)
            : base(cronConfiguration.CronExpression, cronConfiguration.TimeZoneInfo, cronConfiguration.CronFormat)
        {
        }

        public override Task StartAsync(CancellationToken cancellationToken)
        {
            Log();
            return base.StartAsync(cancellationToken);
        }

        public override Task ScheduleJob(CancellationToken cancellationToken)
        {
            Log();
            return base.StartAsync(cancellationToken);
        }

        public async override Task DoWork(CancellationToken cancellationToken)
        {
            await DoMyWorkAsync();
            return base.DoWork(cancellationToken);
        }

I set it up like this:

services.ApplyResulation<Test>(options =>
            {
                options.CronExpression = "* * * * *";
                options.TimeZoneInfo = TimeZoneInfo.Local;
                options.CronFormat = Cronos.CronFormat.Standard;
            });

So it should run every minute. I can see in my logs, that Startasync and ScheduleJob are being called, but DoWork is called never. What am I doing wrong?

public class CronJobUpdateVisitorVisitDay:CronJobService
{
private readonly ApplicationDbContext _ApplicationDbContext;
private readonly UserManager _UserManager;

    public CronJobUpdateVisitorVisitDay(ICronConfiguration<CronJobUpdateVisitorVisitDay> cronConfiguration, ApplicationDbContext applicationDbContext,UserManager<ApplicationUser> userManager) 
        : base(cronConfiguration.CronExpression,cronConfiguration.TimeZoneInfo,cronConfiguration.CronFormat)
    {
        _ApplicationDbContext = applicationDbContext;
        _UserManager = userManager;
    }
    protected override async Task ScheduleJob(CancellationToken cancellationToken)
    {
        await CustomExtension.StoreVisitorVisitDay(_ApplicationDbContext, _UserManager);
        await base.ScheduleJob(cancellationToken);

    }

    
    public override async Task StartAsync(CancellationToken cancellationToken)
    {
        await CustomExtension.StoreVisitorVisitDay(_ApplicationDbContext, _UserManager);
        await base.StartAsync(cancellationToken);

    }

 
}

In this code, StartAsync and ScheduleJob are run consecutively, while according to the settings, they must be run every 25 minutes every hour.

services.ApplyResulation<CronJobUpdateVisitorVisitDay>(options =>
        {
            options.CronExpression = "25 * * * *";
            options.TimeZoneInfo = TimeZoneInfo.Local;
            options.CronFormat = Cronos.CronFormat.Standard;
        });

Describe the bug
Not sure what's causing this, but it sometimes happens and sometimes doesn't happen.

To Reproduce
Steps to reproduce the behavior:
Here is the code I used.

The line in question I believe is the InactiveRemoverService.

Code of AddCronJob

Expected behavior
Job scheduled to run every two hours.

Desktop (please complete the following information):

• OS: Ubuntu 18.04 I believe
• Browser None
• Version latest

Summary

It will be very usefull to have dynamic time configuration, to allow change timers without app restart.
Currently can't seem to find that, or need example.

Advantage

Change jobs timers without app restart

Hi, I’m @obarscan
I noticed that if you use the autoncofigurator the hostservices are in separated scope.

Summary

This library could easily target more that .net5. I successfully tested this in in core3.1 without any problem. Having taken a look in this library I see no reason for this not to work in any version of donet. This could be done by a simple edit in the csproj files. I have personally tested 3.1 so anything newer should be ok.

Advantage

Makes this project usable independently of c# version. The Timers api works since core2.0 and .net standard 2.0.

CodeFactor found an issue: An opening curly bracket must not be followed by a blank line.

It's currently on:
samples\EasyCron.Sample\Startup.cs:30

Summary

Must be IServiceCollection extension for initialize job.

Usage

services.ApplyResulation<DbWriterCronJob>(options =>
{
       options.CronExpression = "* * * * *"
       options.TimeZoneInfo = TimeZoneInfo.Local;
});

Codacy detected an issue:

Message: Change the visibility of this constructor to 'protected'.

Currently on:

• Commit: 5297d05
• File: src/EasyCronJob.Abstractions/CronJobService.cs
• LineNum: 20

Summary

It would be really helpful to load the ICronConfiguration for the appsettings.

Advantage

Services can be updated without recompiling

Additional context
Maybe consider

{
     "CronConfiguration" : [
            "ServiceName" {
                    "CronExpression": "*/10 * * * * *",
                    "TimeZoneInfo": "Local"
             }
      ]
}

CodeFactor found an issue: The code must not contain multiple blank lines in a row.

It's currently on:
samples\EasyCron.Sample\Jobs\ConsoleCronJob.cs:27
Commit 001f7cf

Codacy detected an issue:

Message: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread.

Occurred on:

• Commit: 71ae690
• File: src/EasyCronJob.Abstractions/CronJobService.cs
• LineNum: 75
• Code: await Task.CompletedTask;

Currently on:

• Commit: 6fc5c2b
• File: src/EasyCronJob.Abstractions/CronJobService.cs
• LineNum: 75