Code Monkey home page Code Monkey logo

Comments (7)

iamfunsho avatar iamfunsho commented on August 10, 2024

Please what OS

from godot-git-control.

Keyaku avatar Keyaku commented on August 10, 2024

Sorry about that.

Running macOs Sierra (10.12.1) and Godot from master.

from godot-git-control.

iamfunsho avatar iamfunsho commented on August 10, 2024

The problem is that i didn't test it on OSX cause i don't own a Mac or Hack but can you please run this command in your terminal and tell me what it prints

whereis -b git

from godot-git-control.

Keyaku avatar Keyaku commented on August 10, 2024

I found the problem.

Just swap the line (at command_manager.gd::76):
return self.run_command(["-b", "git"], "whereis")[0].strip_edges();
with
return self.run_command(["git"], "whereis")[0].strip_edges();

OS X does not support the -b flag in whereis.

Also, reminder: don't forget to update the plugin version number in plugin.cfg::7! You forgot the last time

from godot-git-control.

iamfunsho avatar iamfunsho commented on August 10, 2024

What a coincidence :D, I have already change from using whereis to which binary (for searching for git) on both linux and mac (I have already pushed the changes). Please test it to see if there are any issues.

from godot-git-control.

iamfunsho avatar iamfunsho commented on August 10, 2024

You are free to close this issue if everything works fine. Also since it's still in alpha (and there are still some stuffs i will love to add) , i don't really what to change the version, i only did that because of asset-library. Maybe when i push a stable version (hopefully this weekend), i will update it.

from godot-git-control.

Keyaku avatar Keyaku commented on August 10, 2024

I would, but this wasn't yet updated on the AssetLib D:

No matter, I downloaded the changed files and applied them. Works great! Thanks.

from godot-git-control.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.