fullerzz / loamy Goto Github PK

Add response headers to RequestResponse class.

Some basic logging can be added about the request operations.

Overview

Currently, zSession.sendRequests returns an object of type RequestResults.

@dataclass
class RequestResults:
    requestResponses: list[RequestResponse]
    taskExceptions: list[BaseException]

If the caller sets sendRequests(return_exceptions=True), the taskExceptions field will be populated with any exceptions raised during the execution of sendRequests.

Conversely, if the return_exceptions is False, any exceptions raised will immediately cancel all tasks and propagate the exception up to where zSession.sendRequests was called from.

Proposal

The class RequestResponse should be modified to have an additional field for taskException of that is optional:

class RequestResponse(msgspec.Struct):
    requestMap: RequestMap
    statusCode: int
    body: dict | None = None
    taskException: BaseException | None = None

Now, there is no longer a need for the class RequestResults. We can simply return the datatype list[RequestResponse] from zSession.sendRequests.

• Determine lower-bound version for python
• Set python 3.11 as the maximum allowed python version

Python 3.12 will be allowed once aiohttp supports it.

https://peps.python.org/pep-0561/

After testing out loamy myself, I noticed some issues with the log messages. Further requirements gathering is necessary, but here's some initial impressions:

• I only want loamy's logs to appear in stdout if the user has their log level set to DEBUG or lower
• The stack traces produced by loamy are too noisy and don't add any additional benefit currently