fugroroames / chrono.jl Goto Github PK

Nice work! 👍

Would it make sense to implement the zoo of astronomical timescales in this package or should they rather live someplace else, e.g. AstronomicalTimescales.jl?

ToDo

• TT (Terrestrial Time)
• TCG (Geocentric Coordinate Time)
• TCB (Barycentric Coordinate Time)
• TDB (Barycentric Dynamical Time)
• UT1 (Universal Time)

Not that i understand the issue of leapseconds very well, so my understanding could be wrong. In my understanding the UTC Day 2016-12-31 has a duration of 86401 seconds not 86399. As far as i understand TAI currently ticks slightly too fast in relation to something like solar mean time.

utc1 = Chrono.Time(1hours, UTCDate(2016, 12, 31))
utc2 = Chrono.Time(1hours, UTCDate(2017, 1, 1))
utc2 - utc1

gives:

86399//1 seconds

but in my opinion it should give:

86401//1 seconds

This package currently has no unit tests!

using Chrono
t1 = Time(12hours + 3.0seconds, UTCDate(2016,7,25))
t1 + 1seconds

produces the error given in the title.

i think this is due to the fact that in src/time.jl you have:

# Mathematical operations
@inline Base.:+(d::Duration, t::Time) = Time(d + t.duration, t1.clock)
@inline Base.:+(t::Time, d::Duration) = Time(t.duration + d, t1.clock)
@inline Base.:-(t::Time, d::Duration) = Time(t.duration - d, t1.clock)

t1.clock should be replaced by t.clock