frugghi / swiftlcs Goto Github PK

let first = [0,1,1,2,3]
let second = [0,1,2,3] 
let diff = first.diff(second)

print("commonIndexes: \(diff.commonIndexes)")

result in
commonIndexes: [0, 1, 2, 3, 4]

expect: [0, 1, 3, 4] or [0, 2, 3, 4]

Maybe caused by wrong endIndex in prefix func

func prefix(_ otherCollection: Self, count: Int, suffix: Int, by areEquivalent: (Element, Element) -> Bool) -> (Int, [Index]) {
        ...
        let endIndex = self.index(self.startIndex, offsetBy: count - suffix)
       let endIndex = self.index(self.startIndex, offsetBy: count - suffix - 1) // maybe???
       ...
    }

Whenever the length of the text is a bit long (about 510 characters) the algorithm crashes in the following function:

and this line: else if table[i][j] == table[i][j-1]

/// Walks back through the generated table to generate the diff.
fileprivate static func diffFromIndices(_ table: [[Int]], _ x: [Element], _ y: [Element], _ i: Int, _ j: Int) -> Diff {

    if i == 0 && j == 0 {
        return Diff<Element>(results: [])
    } else if i == 0 {
        return diffFromIndices(table, x, y, i, j-1) + DiffStep.insert(j-1, y[j-1])
    } else if j == 0 {
        return diffFromIndices(table, x, y, i - 1, j) + DiffStep.delete(i-1, x[i-1])
    } else if table[i][j] == table[i][j-1] {
        return diffFromIndices(table, x, y, i, j-1) + DiffStep.insert(j-1, y[j-1])
    } else if table[i][j] == table[i-1][j] {
        return diffFromIndices(table, x, y, i - 1, j) + DiffStep.delete(i-1, x[i-1])
    } else {
        return diffFromIndices(table, x, y, i-1, j-1)
    }

}

let first = [0,1,2]
let second = [0,1,2,3,3]
print(first.diff(second).addedIndexes) outputs [3, 3] instead of [3, 4]

SwiftLCS.swift line 116: Conditional downcast from 'Self.Element?' to 'Self.Element' does nothing

It's relating to this downcast:
while let lhs = entry.0 as? Iterator.Element,

Pods/SwiftLCS/SwiftLCS/SwiftLCS.swift:211:28: 'characters' is deprecated: Please use String or Substring directly

For some reason SwiftLCS does not recognize the two collections as containing common indexes. The two arrays being compared are exactly the same, but SwiftLCS removes all indexes and adds them back instead of simply recognizing that they are common indexes.

I essentially have a query that pulls all data, and I have SwiftLCS compare the cached data array to the new, in-coming data array.

Any plans of migrating?