frozenmustelid / pfsb Goto Github PK

The code that calculates a construct's size-based bonus HP has a default case that assumes that any size smaller than Small is a typo. Since the program always thinks that any value for a creature size not accounted for is a mistake, the program will exit.

To reproduce:
Start PFSB
Follow the prompts
Tell the program the creature is a construct
Tell the program the size is tiny, fine, or diminutive
Follow prompts until the program exits. No file will be written, because the program thinks that your creature failed a sanity check.

The OGL isn’t a software license. While it covers much of the content/data you are using, you should have a license for the source code itself as well.

Some inputs produce correct values, some do not. Looking at the function, it's clear that the appropriate calculations are barely even close to what the program is actually doing. A quick glance at the function tells me that low-HD monsters should be more likely to be correct than high-HD ones, and that Undead are likely completely and utterly screwed. Either way, I should stop programming at 6AM.

Until this gets fixed, use a text editor to manually correct the information in the HTML file. Based on the 1 test I did, it seems like the breakdown is correct, though I wouldn't trust it.

The code that creates the ability score modifiers produces incorrect values for odd-numbered scores under 10. For example, 9 CON will be calculated as a +0 mod, 7 WIS will be calculated as a -1 mod, etc.

To reproduce:
Start PFSB
Follow the prompts until you reach the part where you enter ability scores
Give the creature a number less than 10 in any ability score. The more easily visible (like DEX), the better. Note that CON may not be the best choice, as the current version (0.1) of the program calculates HP incorrectly.
Follow prompts until the program exits.
Manually calculate the determined values (example: saves) from the independent values (for the saves example, base saves + ability mod) of the odd-numbered abilities lower than 10. Compare to the output file of PFSB.