frontendnetwork / veganify-api Goto Github PK

Description:
If there are only two non-vegan ingredients in the ingredients list, data.vegan in the response is always true.

How to reproduce:
You can use any 2 non-vegan ingredients in the query. ("chicken, pork" for example).
Vegan ingredients don't affect the results.

Example js code I used.

let response = await fetch(
    'https://api.vegancheck.me/v0/ingredients/egg, milk',
    {
      method: 'GET',
    }
  );

The problem can be reproduced on the https://vegancheck.me/ingredients website as well.

Proposed changes

The BE of the project should be dockerized to be more scalable.
This would could potentially fix our ongoing uptime issues.

Proposed changes

For a better overview of the code as well as better extend ability in the future, we should switch from Pure Express to NestJS.

This is an effort we can now make, since we previously switched to ES6 (better late than never! 😊)

Also, the current logic to scrape the data from Peta for cruelty-free brands (including a cronjob) does not work anymore because of the Docker-Setup.
I think it would be best to extract this logic into a GitHub action (if possible) an then just push the latest file to the repo (which will automatically create a new build).

Acceptance Criteria

• Codebase is updated to NestJS
• Dockerfile is updated to start and build NestJS server
• PetaCron is extracted into a GitHub Action
• Tests are rewritten to the NestJS API
• Tests are extended

frontendnetwork/veganify#437

Bug description

Currently, if VeganCheck.me is given an ingredient that it doesn't recognize, it says that it is vegan -- even if it isn't

Steps to reproduce

Steps to reproduce the behavior:

1. Go to https://vegancheck.me/ingredients
2. Type "cow"
3. See message indicating that "cow" is vegan

Solution

If a query for an ingredient that is submitted to VeganCheck is not known to VeganCheck's backend, then it should respond with an "I don't know" error, instead of a false-positive guess (green checkbox).