Code Monkey home page Code Monkey logo

Comments (5)

sinnbeck avatar sinnbeck commented on May 30, 2024 1

Yeah changing vendor packages directly is bad as they are not under version control. Once you push to live, it will break again :) Instead you could clone it, fix it and use that version instead. Or better yet, make a pull request

from nova-froala-field.

sytheveenje avatar sytheveenje commented on May 30, 2024

Having the same issue.

The fix is to change line 106 in Froala.php from:
public function withFiles($disk = null)
to
public function withFiles($disk = null, $path = '/')

from nova-froala-field.

chatzisnik avatar chatzisnik commented on May 30, 2024

Hi @sytheveenje,

Yeap, that works as stated, but as I didn't dig in the Froala field code further, I don't know what implications may arise from that change. Still would suggest downgrading nova and wait for most people.

Best,
Nick

from nova-froala-field.

sytheveenje avatar sytheveenje commented on May 30, 2024

I understand @chatzisnik. Didn't saw your fix in your post.

I'll wait for the fix.

from nova-froala-field.

slavarazum avatar slavarazum commented on May 30, 2024

Fiexed in 3.2.1

from nova-froala-field.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.