Code Monkey home page Code Monkey logo

galaxy-integration-origin's Introduction

Origin integration for GOG Galaxy

Allows to import your list of games, achievements and time played.

galaxy-integration-origin's People

Contributors

claushofmann avatar friendsofgalaxy avatar nathanaela avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

galaxy-integration-origin's Issues

GOG Galaxy sync issue involving Steam game playable through Origin: Titanfall 2 shown as installed after uninstall

As titled, I bought Titanfall 2 on Steam. This used Origin to play. Galaxy synced to both platforms with no issue and I could install & launch the game via Galaxy. On uninstall of game, it would show as uninstalled in Steam, Windows & Origin, but still be shown as installed in Galaxy. I reinstalled & uninstalled several times (via Windows, Steam & Galaxy). Galaxy still detected game as installed.

I was eventually able to have Galaxy detect the game correctly by desyncing Origin.

To Reproduce
Possibly reproducable by syncing Galaxy with Steam and Origin, installing Steam version of Titanfall 2, and uninstalling.

Expected behavior
Would expect Galaxy to follow Steam and Origin and detect game as uninstalled.

Attached logs
N/a

Games aren't launchable since stuck on 'Install' instead of 'Play'

Describe the bug
Games that I have installed are seen as Owned but not Installed and thus are not launchable as instead of 'Play' it is 'Install'. Clicking on Install just opens Origin and does nothing.

Expected behavior
I expect the plugin to allow me to open the game instead of 'Installing' it.

Attached logs
Link

Crash if ProgramData is undefined in Environmental variables.

Describe the bug
If ProgramData is not defined in the environment the plugin crashes here:

local_content_path = os.path.join(os.environ["ProgramData"], "Origin", "LocalContent")

To Reproduce
Set ProgramData=
Start GOG and see if disconnect immediately and be in a crashed state crashed

Expected behavior
It assumes that ProgramData will always be defined, I expect it not to crash if somehow this isn't set...

Fix
Replace:
local_content_path = os.path.join(os.environ["ProgramData"], "Origin", "LocalContent")
with
local_content_path = os.path.join(os.environ.get("ProgramData","C:\ProgramData"), "Origin", "LocalContent")
As it will allow the normal value to be used if ProgramData is not set...

Relevant Log

Traceback (most recent call last):
File "C:\users\nathanael\Local Settings\Application Data\GOG.com\Galaxy\plugins\installed\origin_7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0\galaxy\api\plugin.py",
line 1140, in create_and_run_plugin
asyncio.run(coroutine())
File "D:\obj\Windows-Release\37win32_Release\msi_python\zip_win32\runners.py", line 43, in run
File "D:\obj\Windows-Release\37win32_Release\msi_python\zip_win32\base_events.py", line 584, in run_until_complete
File "C:\users\nathanael\Local Settings\Application Data\GOG.com\Galaxy\plugins\installed\origin_7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0\galaxy\api\plugin.py",
line 1130, in coroutine
async with plugin_class(reader, writer, token) as plugin:
File "C:\users\nathanael\Local Settings\Application Data\GOG.com\Galaxy\plugins\installed\origin_7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0\plugin.py", line 64, i
n init
self._local_games = LocalGames(get_local_content_path())
File "C:\users\nathanael\Local Settings\Application Data\GOG.com\Galaxy\plugins\installed\origin_7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0\local_games.py", line
247, in get_local_content_path
local_content_path = os.path.join(os.environ["ProgramData"], "Origin", "LocalContent")
File "D:\obj\Windows-Release\37win32_Release\msi_python\zip_win32\os.py", line 678, in getitem
KeyError: 'ProgramData'

EA play membership titles shown after membership ran out (add offers cache invalidation)

when ea play came out i foolishly took the free trial month without realizing it. the membership then ended and i am now stuck with a bunch of games in my library that i cant play https://i.imgur.com/LSXEFLg.png

these titles all show up in gog galaxy with no hint that they arent really owned by me https://i.imgur.com/AnRdyPD.png
syncing games was done way after the membership ran out

i would expect them to not show up in gog galaxy, or at least be marked somehow, but i guess them not showing up would be easier to do?

removing the titles from my origin library does reflect in gog galaxy, so that is a potential solution, but it would be nicer if the plugin just wouldnt sync games that arent playable

Purchasing on Steam and Origin messes up playtime and installable versions

Describe the bug
Purchasing an Origin game on Steam and Origin doubles playtime and adds an installable version to Galaxy that can't actually be installed from Origin.

Expected behavior
I expected my Sims 4 playtime to be around 1,150hrs but it's closer to 2,300hrs. Also, the Windows-only Steam version shows up as installable from Origin, which isn't possible.

I think this happens because, when activating a Steam game through Origin, it adds a special "Steam" version that syncs stats with the Origin version.

Extra Images
Screen Shot 2022-04-07 at 11 29 19 AM
Screen Shot 2022-04-07 at 11 26 48 AM

Attached logs
plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

Achievements no longer appear

Achievements no longer appear on any origin linked game, even the ones that used to be there have disappeared, basically all origin linked games now behave like they don't support achievements, for example in the 'my progress' tab, under achievements it says n/a, otherwise it tracks and imports other data like 'game time' normally.

Tried disconnecting quitting the application then reconnecting, syncing integrations, removing and reinstalling the integration itself, and removing the storage.db file.

Origin Subscription Update

Wondering if the plugin is going to be updated to take advantage of GOG Galaxy 2.0 now allowing for subscriptions to be added.

If it has been updated for this, then I am not seeing any of my Origin Premier games appearing.

origin not showing up ultimate editions or deluxe editions

Before start

Describe the bug
Generally games show up fine with the origin plugin, however if a title owned is the deluxe edition or ultimate edition of a game it dows not show up in thw owned list. For instance I own the deluxe edition of Battlefield 1, which does not show up on the origin tab at all.

To Reproduce
Steps to reproduce the behavior, for example:

  1. Log in with account that has any deluxe edition or ultimate edition origin titles
  2. Check the origin tab to see the game not there

Expected behavior
All games except for those that are deluxe edition or ultimate edition to be present

Origin python background process still running when GOG Beta closed.

I reported this to GOG support as well as here now.

Got my GOG Beta invite and installed the latest version 2.0.5.138 and added the plugins support for my other accounts (Steam, Uplay, Origin) which worked fine.

But when I fully close down GOG there are processes still running that never do unless forced:
GOG Galaxy (32 bit) (2)
----Python (32 Bit)
----Console Window Host

Checked what both these processes are linking to (command line) (as requested from GOG support):

Python
"C:\Program Files (x86)\GOG Galaxy\python\python.exe" "C:\Program Files (x86)\GOG Galaxy\plugin_runner.py" C:\Users\Administrator\AppData\Local\GOG.com\Galaxy\plugins\installed\origin_7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0\plugin.py 21e8cc57-0e00-4877-8683-66efb47baded 50718 C:\ProgramData\GOG.com\Galaxy\logs\plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

Console Window Host
??\C:\Windows\system32\conhost.exe 0x4

Tried a reinstall of the community integrations (only Origin when you press disconnect) always stops and reports Plugin has crashed. Retry. as well as deleted all of the Origin plugin and db file and installed manually the one from Github (v0.28) will the still the same problem.

plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

Origin Access subscription: Viewing uninstalled games.

Hello,

Is there any way to see the available games you can use/install when you have an Origin Access subscription?

It correctly shows games that I have installed, but not the catalog of all the games I can potentially play.

Thanks.

Games are not imported

Before start

Describe the bug
The plugin can't detect any games installed. At the moment it is FIfa 22 from EAPlay Pro

To Reproduce
Steps to reproduce the behavior, for example:

  1. Launch GOG Galaxy 2.0
  2. Sync all the integrations.
  3. the game isn't imported, because there is install button.
  4. Click on install button.
  5. Opens the Desktop App of EA where the game is installed.
  6. Return on the Galaxy 2.0 but nothing happens even after restart the app and pc.

Expected behavior
After the Sync integrations i hope to see the game.

Attached logs
Check how to do it properly: https://github.com/FriendsOfGalaxy/galaxy-integration-origin/wiki/Log-file
plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

Galaxy shows Sims 4 play time as multiple instances of something that is not The Sims 4?

Describe the bug
Galaxy shows Sims 4 play times as multiple instances of other Sims 4 games or demos maybe?

See attached screenshot. Gog shows my play time incorrectly for the Sims 4. It shows a whole bunch of repeated instances of something else connected to the Sims 4, but they are not expansion packs. I think it might be Creat a Sim Demo, which is the only other thing I can think of that I might have put that much time in waaaaay back in the day. Even so, why would it show it some many times and add them together?

Expected behavior
It should just simply show the hours (way too many, it's sad to say LOL) I have logged in The Sims 4.
Screenshot_1

Origin Source is Depreceated. Remove from options if not logged in.

Describe the bug
The Origin Source connector is depreciated and therefore should be phased out. It's taken

Expected behavior

  1. If the Origin break is for all including those already in use it should be removed entirely, possibly just commented out
  2. If the break seems to be for new setups / installations conditional removal where it's recieved no data/games list/login whichever is the primary hook

BF1 is gone

Don't have BF1 in GOG Galaxy 2.0 anymore. Tried to reconnect my Origin account, but still can't see it in GOG

Missing game : Dragon Age Origins Digital Deluxe edition

Hello,

As said in title, this specific game version is not detected by the plugin.

But in log the game seems found :
{"game_id": "DR:151951600", "game_title": "Dragon Age:\u2122 Origins Digital Deluxe Edition", "license_info": {"license_type": "SinglePurchase"}}

Origin games bought from Epic Games store not launching

Describe the bug
When buying an EA game (such as Star Wars Battlefront 2) from the Epic Games store and installing it, the game is recognized by the Galaxy Origin integration as installed on Origin. When trying to launch the game via Galaxy, Origin shows an error message saying that the game needs to be activated and does not launch the game.

To Reproduce

  1. Install an EA game from the Epic Game Store
  2. Try to launch it via the Galaxy Origin integration

Expected behavior
The game should launch correctly

Attached logs
plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

Error message
origin_error

Issue with Origin Plug-in related, to Games bought on Epic and game installed through EAPlay

Describe the bug
Good morning to everyone. In first place a want to congratulate with every creators of this plug-in, I ho you continuing to put effort in this cause. The second things is the problem that I face-of. The first is that a game bought through Epic Games Launcher, after dis installation, is still in the fog library, the second is that Star Wars: Jedi Fallen that I installed through EAPlay, won't show in the Fog library, is tath anything I do for resolve this problem??. I tried the tips that I found in the issue section of this plug-in, but nothing seems to help me. A suggestion is very appreciated, thanks a lot.

Incorrect handling of games no longer owned

Describe the bug
When a game ID cannot be found, the plugin causes an unexpected exception instead of detecting it. Here is the traceback from the log file:

2020-05-16 10:01:34,523 - root - ERROR - Game 'DR:110592000' not found amongst owned
Traceback (most recent call last):
File "C:\Users\Pierre\AppData\Local\GOG.com\Galaxy\plugins\installed\origin_7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0\plugin.py", line 144, in get_unlocked_achievements
achievements_set = context.owned_games[game_id].achievement_set
KeyError: 'DR:110592000'

Expected behavior
You should put a try: except: block around that code (or check game_in in context.owned_game).

Uninstall game goes to Control panel/Uninstall list

Describe the bug
When I choose Manage install/Uninstall uninstaller is not run, but Control panel/Uninstall list is shown.

To Reproduce
Choose any installed Origin game, then Manage install/Uninstall.

Expected behavior
Uninstall game - the same as in Origin.

Attached logs
Relevant log entries:

2019-12-22 20:19:23,299 - galaxy.api.jsonrpc - INFO - Handling notification: method=uninstall_game, params={'game_id': 'Origin.OFR.50.0001892'}
2019-12-22 20:19:23,299 - galaxy.task_manager - DEBUG - Task manager jsonrpc server: creating task 17 (uninstall_game)
2019-12-22 20:19:23,300 - galaxy.task_manager - DEBUG - Task manager plugin external: creating task 24 (uninstall_game)
2019-12-22 20:19:23,410 - galaxy.task_manager - DEBUG - Task manager plugin external: finished task 24 (uninstall_game)
2019-12-22 20:19:23,410 - galaxy.task_manager - DEBUG - Task manager jsonrpc server: finished task 17 (uninstall_game)

Can't disconnect Origin account

I can't disconnect my Origin (and Steam also) account to connect a different account. When I hit "Disconnect", a confirmation window opens. After choosing "Confirm" instead of "Cancel" nothing happens. I can repeat this, restart/reinstall GOG Galaxy and the integration as often as I want, nothing changes.

To Reproduce

Log in with account
Decide to use different account
Open integrations settings
Search for Steam (or Origin)
Click "Disconnect" next to Steam (or Origin)
Hit "Confirm" in the confirm window

Expected behavior
After confirming, the connection should be reset and games should be removed from library.

GOGGalaxy Version: 2.0.16.187

Wing Commander 1 and 2 not showing

Before start

Describe the bug
Wing Commander 1 and 2 are missing from the GOG 2.0 interface, I had a look at the logs but I can't see them shown.
I have tried a forced sync and removing and reinstalling the plugin the games still don't show up

Log attached
plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

Playtime when using EA Desktop doesn't sync to GOG

Describe the bug
I noticed play time when launching games from the newer EA Desktop client doesn't sync with GOG. Using the older Origin Client it keeps updating correctly.

To Reproduce

  1. Launch a game with EA Desktop and play it for a few minutes
  2. Sync integrations in GOG and check the playtime of the game just played.

Expected behavior
The play time of the game just played should've been updated.

Attached logs
plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

Games in Origin are always listed as "Recent"

When I look at the "Recent" tab in GoG, every game in my Origin library is listed as being "recent", despite the fact that I've not purchased a game from Origin in a few years.

To Reproduce

  1. Connect GoG with Origin
  2. Look at "Recent" section

Expected behavior
Only recently purchased games are shown

Can't remove Origin games from Galaxy 2.0 after disconnecting

I disconnected this plugin a while ago and just noticed that the Origin games are still appearing in my Galaxy library. I've installed Galaxy on a new computer that never had the integration or Origin installed, but the games are still showing up as 'Owned' so it seems this data is stored with GOG? I've looked through the right-click menu and 'Manage Installation > Configure' window and did not find any option to remove them from my library. I do have the option to hide them, but I am specifically trying to remove them from the library completely since I disconnected the integration completely. Thanks for any help you can provide on this issue.

Change account email causing infinite loop

So I ran into this issue where I changed my Origin account email which causes the integration to fall into an infinite loop on connecting..

connecting

I thought maybe deleting the origin installed plugin folder would help but all it does is re-downloads the plugin and starts trying to connect again.

Where can I find the config that stores what plugins I had installed to completely clear the Origin integration to be able to install it as a fresh copy...

At the very least might be a good idea to have a function that times out at X mins then requires you to re enter credentials

Playtime counted twice

Describe the bug
I own the deluxe version of Jedi Fallen Order, and the play time is counted twice -- once for the standard version and once for the deluxe version. I do not own the game on any other service.

To Reproduce
Own deluxe version of a game

GalaxyClient_zeiigLqrcH
EADesktop_OBp4tWnGzt
EADesktop_XvX6mXViPv

Expected behavior
I expect my playtime to only be shown once and not doubled

Attached logs
plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.