Synchronous promises don't chain properly about then HOT 9 CLOSED

@piterlouis this is brilliant! Even if we usually use Async code in promises, this definitely is a bug indeed.
I can reproduce it on my end and your fix works like a charm :)
Would you mind creating a pull request for this?
Thank you so much for your help 👍

from then.

By the way I could reproduce the exact same bug with the other syntax below :

promiseA().then { _ -> Promise<Int> in
    return promiseB()
}.then { _ -> Promise<Int> in
    return promiseC()
}.then {  r in
    print(r)
}

which should be the exact equivalent than promiseA().then(promiseB()).then(promiseC()).

Once again it works perfectly if promiseA is Asynchronous but not if A is synchronous. This will need a separate fix though.

from then.

Actually we need to fix this further down, as explained before, the two syntaxes should do the same. so we rewrote the function taking a promise as a parameter like so :

public func then<X>(p:Promise<X>) -> Promise<X>{
    return then { _ in p }
}

Now our fix (yet to be found) will fix the two issues described above :)

from then.

Hey @piterlouis, we just pushed a fix on "dev" branch, could you confirm that it fixes your issue?

from then.

Ey @s4cha, the fix works perfect!. Thanks you a lot for your code and time!!

from then.

I was having this same issue, glad to see it fixed! Any chance the changes will be pushed up to Cocoapods?

from then.

@chetem Indeed this wasn't pushed to CocoaPods. Can you confirm this is fixed?

from then.

Yep! I used the latest source code in one of my projects and everything seems to be working as expected!

from then.

@chetem great !

from then.