Sorry, I probably should've opened this issue before the PR. I'm mostly pasting the in

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

How about such a minimal revision? <div class="highlight highlight-source-swift no

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Swift 5 support about then HOT 6 CLOSED

freshos commented on May 8, 2024

Swift 5 support

from then.

Comments (6)

balecrim commented on May 8, 2024 1

Hi @s4cha, first of all, sorry for the radio silence lately, I haven't had as much time lately to help out. I'll look into your feedback on #51 and try and reproduce the differences between our environments and be sure to let you know ASAP what I find out.

from then.

s4cha commented on May 8, 2024

@bernardowilson First of all thank you so much for taking the time to issue a PR, this is really appreciated :) I've had to relax the timings locally as well when testing with swift 5, it's not a big deal.

Concerning the breaking changes I need to check what's going on, we'll do that on #51.

PS: I'm currently trying to update to the latest Xcode at home with a terrible network connection might take some time ;)

from then.

arden commented on May 8, 2024

When will swift5 be supported ?

from then.

v-ksenofontov commented on May 8, 2024

How about such a minimal revision?

extension Promise where T == Void {
    
    public convenience init(callback: @escaping (
        _ resolve: @escaping (() -> Void),
        _ reject: @escaping ((Error) -> Void)) -> Void) {
        self.init()
        setProgressCallBack { resolve, reject, _ in
            //swift 5 build fix:
            callback({
                resolve(())
            }, reject)
        }
    }
    
    public convenience init(callback2: @escaping (
        _ resolve: @escaping (() -> Void),
        _ reject: @escaping ((Error) -> Void),
        _ progress: @escaping ((Float) -> Void)) -> Void) {
        self.init()
        setProgressCallBack { resolve, reject, progress in
            //swift 5 build fix:
            callback2({
                resolve(())
            }, reject, progress)
        }
    }
}

from then.

s4cha commented on May 8, 2024

@vksenfontov eagle eye, indeed that's what I had on my side that enables migrating without all the changes highlighted on #51
here is mine for reference:

extension Promise where T == Void {
    
    public convenience init(callback: @escaping (
        _ resolve: @escaping (() -> Void),
        _ reject: @escaping ((Error) -> Void)) -> Void) {
        self.init()
        setProgressCallBack { resolve, reject, _ in
            let wrapped = { resolve(()) }
            callback(wrapped, reject)
        }
    }
    
    public convenience init(callback2: @escaping (
        _ resolve: @escaping (() -> Void),
        _ reject: @escaping ((Error) -> Void),
        _ progress: @escaping ((Float) -> Void)) -> Void) {
        self.init()
        setProgressCallBack { resolve, reject, progress in
            let wrapped = { resolve(()) }
            callback2(wrapped, reject, progress)
        }
    }
}

from then.

s4cha commented on May 8, 2024

@arden it is now :)
@bernardowilson Congrats ! Thank you so much for you work 🥇

Release: https://github.com/freshOS/then/releases/tag/5.0.0
Pod: https://cocoapods.org/pods/thenPromise)

Closing this for now, don't hesitate to reopen if needed :)

from then.

Swift 5 support about then HOT 6 CLOSED

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent