frendsplatform / frends.files Goto Github PK

using (var fileStream = new FileStream(input.Path, fileMode, FileAccess.Write, FileShare.Write, 4096, useAsync: true))
{
var memoryStream = new MemoryStream(bytes);
await memoryStream.CopyToAsync(fileStream).ConfigureAwait(false);
}

var memorystream is missing using statement. This bug has been transferred from FrendsPlatform/Frends.File#19

Need to go through all the Tasks and check if cancellationtoken is used and add if not.

Backup task tries to delete the backup directory if there are no file inside. But if the directory has subdirectories the task fails.

The issue remains from Frends.File:

FrendsPlatform/Frends.File#14

TL;DR: "Use given user credentials for remote connections" does not work when targeting core or standard.

Upgrade https://github.com/FrendsPlatform/Frends.File version to .NET 6

Macros could be implemented in the backup directory. This could be done by following how the macros are handled in Frends.SFTP https://github.com/FrendsPlatform/Frends.SFTP or Frends.FTP https://github.com/FrendsPlatform/Frends.FTP tasks or in Cobalt https://github.com/FrendsPlatform/Frends.Cobalt.

Windows-1252 requires a library reference to work and should have an option added to the task.

FrendsPlatform/Frends.File#17
This bug has followed from the old official tasks. Needs to be fixed ASAP.

• Cobalt as example (https://github.com/FrendsPlatform/Frends.Cobalt/tree/master#source)
  • There is a local backup in Cobalt processing steps, which we essentially need to do here
• Needs input (files to be backed up)
  • Dir and file mask
• Needs backup settings
  • Backup dir
  • Switch for cleanup
  • Cleanup setting (visible only when cleanup needed)

NB! SUPPORT BOTH .NET 6 and .NET STANDARD 2.0

The Task is trying to cast the FilePaths input as string[] instead of object[]. This needs to be fixed.

Check comments too

Task will create backup folder automatically with predefined name. There has been reports that this is not a working solution, since they want to have all backups under same directory without any random sub-directories.

Basically if you define the directory as C:\tmp\archive, then the files should be at C:\tmp\archive, not in C:\tmp\archive\{timestamp}-{Guid}.

As implementation proposal the task should always save the files to the given directory. There could also be a boolean where user can select to create directory if the directory does not exist.

Task needs a input field where users can insert the #process.executionid rather that creating a new one. If the field is empty then maybe use the Guiid.NewGuid() method.

Task uses subdirectory in cleanup when the CreateSubdirectories is set and not the backup directory which is set as parameter

At the moment the Task only uses regex to find files which match. When the file includes special characters like parenthesis or brackets the task can't find the file. There should be an option to not use regex or check if the file matches implicitly with the file.

The description of the Task says: Returns: List [ Object { string SourcePath, string TargetPath } ], which is not true.

The Task returns an object with property of Files containing the list of the copied files rather than the current description.

For example c:\temp\file.txt works fine but c:\temp temp\file.txt doesn't.

Task could take a list of filePaths as input like in Cobalt. This would make the backup possible without file mask so the source directory could have other files in it which are not affected.

Hi,

Is there some technical reason why all these tasks are net6.0 only? If you could add at least .netstandard2.0 support it would make the migration from old tasks to these the much easier. Of course if possible add net4 Framework support too.

Task's Cleanup method adds deleted message even if files were not deleted.