frenck / action-addon-linter Goto Github PK

As my addon is a little bit dirty made, I need to supply the image SHA in the build.json. Otherwise, the multi-arch builder uses the same base image for all arches.

Error: {'armhf': 'thomx/fr24feed-piaware:1.18.0@sha256:c21ad18c64a9d6d4f96706fe7504e0b762ecff01f5c71b00bff0a191c0857e14', 'armv7': 'thomx/fr24feed-piaware:1.18.0@sha256:f20d215e40f19dfad24d0f70c070fd89617f38335e82cd713b40c215e7ea2fac', 'aarch64': 'thomx/fr24feed-piaware:1.18.0@sha256:0bf6fb89e0fa983270c36fa8d953ea49b4c3d99a43ec5cc0b178bce7cd2712bc', 'amd64': 'thomx/fr24feed-piaware:1.18.0@sha256:44e5331926921285d6e33ad0bf5a51eea1fb63f2b5b52668591cece6f79bb9c4'} is not valid under any of the given schemas

Besides the ugliness of my addon, shouldn't the regex allow using images by its SHA?

Comparing the following two code passages, it seems action-addon-linter is incorrectly displaying an error in case an addon is specifying IPC_LOCK in the privileged section of its config.json:

https://github.com/home-assistant/supervisor/blob/main/supervisor/docker/const.py#L8-L17

Or do I miss something regarding IPC_LOCK here?

I also have some json schema files for my pet project I publish them to github pages (with custom domain but that doesn't matter).
So my schema file is available from the internet and that means they automatically work in VSCode.

If you would clone sonos-api-docs and edit this file it does the json checking right in the editor. Because I've set the $schema in the json.

https://github.com/svrooij/sonos-api-docs/blob/d1a95207f37146f6b49cba3b5ce796f67dcd2fa8/docs/documentation.json#L1-L2

You can still use your action, which is great for checking, but this small step would allow all addon developers to use the schema files and have much less faults in their addon configuration.

Hey @frenck,

i just started to use your linter and got the following error. I don't know how to get rid of it:

yaml.scanner.ScannerError: while scanning for the next token
found character '\t' that cannot start any token
  in "diyhue/config.json", line 2, column 1

I tested it on this file:
https://github.com/MaxBec/hassio-diyHue/blob/master/diyhue/config.json

Here is the produced error output:
https://github.com/MaxBec/hassio-diyHue/runs/2225768951?check_suite_focus=true

Kind Regards,
Max

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

In the upcoming Supervisor update, it will be possible to store add-on and repository configurations in a YAML format (besides the current JSON format).

The linter needs to be adjusted to deal with that.

home-assistant/supervisor#2645

While developing an addon, I noticed that a slug with a hyphen seemed to break bashio, and reading the addon docs more carefully, an underscore needs to be converted to hyphen for intra-addon comms (as DNS). If these both are true, perhaps this linter should fail either character (or better regex the slug as all lowercase ascii or something?)