caam_hash() crashes after authenticating a signed fitImage with hab_auth_img about u-boot-fslc HOT 5 OPEN

After some debugging, the issue might be introduced by commit 1d756ad. If the hab is disabled and there is no SRKs programmed in the efuse (I think it is the normal case during development), calling hab_rvt_authenticate_image() in imx_hab_authenticate_image() leads to this randomly failure. After I added the following code if (!imx_hab_is_enabled()) goto hab_authentication_exit; before the hab_rvt_authenticate_image() to avoid the call. It succeeded to boot into Linux user space.

from u-boot-fslc.

@freebendy

Please submit your fix via the U-Boot mailing list, with all the folks involved in commit
1d756ad on Cc.

Thanks

from u-boot-fslc.

@freebendy I merged your PR. Thanks for looking at it. Please prepare a PR to fix this error as well.

from u-boot-fslc.

@otavio Thanks. I need a guidance here. The mainline u-boot does not support kernel HAB in bootm command yet, and the imx u-boot adds support of the legacy uImage in nxp-imx/uboot-imx@3b09ef6. I added the support of fitImage HAB on top of the imx commit above. I have 2 change commits on hand:

• support fitImage HAB
• fix the crash issue
  But I am not sure which u-boot (mainline, imx or fslc) should I create the PRs to.

from u-boot-fslc.

@freebendy

I suggest submitting the patches to the U-Boot mainline list first. After it gets reviewed there, then send a PR against u-boot-fslc.

Thanks

from u-boot-fslc.