freekmencke / node-typescript-starter Goto Github PK

Possible create a cli command that we deploy to npm so a starter can be easily generated.

ex.
npx node-typescript-starter create project-name

Update starter dependencies and reevaluate current code.

https://esbuild.github.io/getting-started/#bundling-for-node

Hi,

Great code, man. I've cloned and run you code, and found a little bug.

in package.json, you are setting env.development, for example:

  "scripts": {
    "start": "webpack --progress --env.development --env.nodemon",

but in webpack.config.js, you are checking env.mode, like

      new webpack.DefinePlugin({
        VERSION: JSON.stringify(packageJson.version),
        DEVELOP: env.mode === 'development',
      }),

One of these two file need to be changed. (either --env.mode='development', or DEVELOP: !!env.development).

https://github.com/toxsickcoder/node-typescript-starter/blob/aa1f94d415e4d2034da7f8feea9bff546c6e8de3/webpack.config.js#L46

These are unnecessary since they are included in the strict setting.

https://github.com/toxsickcoder/node-typescript-starter/blob/0d2c2a2024e54d597f4de3c23e86139d03f08cab/tsconfig.json#L8