fredloh / lohner_csci2270_finalproject Goto Github PK

Hey guys couple issues,

1. As stated in the other issue I am having the same probably with the amount of time it takes to run from Terminal. Took about 4 minutes to run the code I was not sure if it was going to work or not. I would suggest putting in your READ.me that it takes a few minutes for the code to run from Terminal.
2. Also it seems that menu option 4 and 7 are doing the same thing. I inserted a new name Bob which occurs one time, checked from option 4. Then I inserted 1 into option 7 and the output was "name not found" but if I input Bob then it gives me the same result as option 4.

Hey guys,

Great project! I like it!

A couple of things about documentation though....

• Include each method's functionality (what it does, how it does it, and an example of what it looks like) inside your ReadMe file and your driver file.
• The ReadMe file is missing some components from the requirements included in the final project writeup. Include those and it should be good!
• Also, I found that when I ran the executable, the program hung for a couple of minutes, and I wasn't sure if it was going to run or not. I'm not sure if that's only me or if that is an issue for you guys too. I had to compile it a couple of times and run the executable before it actually ran.

I think that's it! It's a nice idea, and I liked the way how you guys executed it! Great work!

When you run your program. #7 and #4 call the same function even though they do different things. This is an easy fix, however, as I see that in your NameList.cpp you have an unused function and it so happens to be the correct function for #7. Just changing that should solve this. Otherwise great work on this project!

First off, great program. The purpose is very narrow, but it's function is amazing. The time difference between the two methods of sorting is astronomical! I will say that I struggled to find errors at first, but alas I did:

1. As mentioned before, the compile time is pretty long. Once compiled and running, the program was fairly responsive, so as was already suggested, I would put something in the ReadMe mentioning the initial start up time. I understand that the purpose of this program is to show how long sorting methods take to complete, but that doesn't mean people are expecting the program to take forever to start. Additionally, the executable did not work for me, but manually compiling the program did.

2. The errors that I did find were related to case sensitivity in the names. It could be debatable that "Rory" "rory" and "ROry" are technically different names, but I feel like that's being too picky for a program such as this. I suggest either converting every name on the list to lowercase (as they are) but print them with a capitalized first letter (which it doesn't) then converting all input names to lowercase for checking (which it doesn't) then printing it out with a capitalized first letter (which it doesn't). Of course the easier solution would be to simply state (maybe in the menu) that the names are case sensitive.

Once again, good work guys.