fredericoo / react-router-typesafe Goto Github PK

Hello & thank you for creating this library, its been a blessing.

Just wondering how I can best get the errors that are returned from my useActionData hook if the action had also had a redirect for successful use cases?

For example, here is the type I see in that case:

const actionData: ActionData<({request}: ActionFunctionArgs<any>) => Promise<Response | {status: number, error: string}>>

Coming from this relevant code:

const actionData = useActionData<typeof contactAction>()

export const contactAction = makeAction(async ({request}: ActionFunctionArgs) => {
  const data = await request.formData()
  const submission = {
      email: data.get('email') as string,
      message: data.get('message') as string
  }

  if(submission.message.length < 10) {
      return {
          status: 400,
          error: 'Your message must be at least 10 characters long.'
      }
  }

  return redirect('/')
})

If my understanding is correct, the component will never "see" the Response anyways, so it can be omitted? Thanks in advance.

I have a route that has a nested route.
They both have loaders, and when I try to access the parent route data, I get the child loader data, regardless of the ID that I pass.

    {
      path: '/', // Base URL, here we serve the application. All the other URLs are nested underneath and define their own paths that append to the base URL
      loader: currentUserLoader,
      element: <App />,
      id: 'currentUser',
      children: [
        {
          loader: qualificationsLoader,
          path: `/qualifications`,
...
}

const currentUser = useRouteLoaderData<typeof currentUserLoader>('currentUser');
// Types are correct, but it returns qualifications, not the currentUser

I am following the 30 minute Remix tutorial and have this code that uses your library:

import { LoaderFunction, useLoaderData } from "react-router-typesafe";
import { json } from "@remix-run/node";
import { getContacts } from "./data";

export const loader = (async () => {
  const contacts = await getContacts();
  return json({ contacts });
}) satisfies LoaderFunction;

export default function App() {
  const { contacts } = useLoaderData<typeof loader>();
}

The useLoaderData line has this error:
Property 'contacts' does not exist on type 'Omit<Response, "json"> & { json(): Promise<{ contacts: ContactRecord[]; }>; }'.

What am I doing wrong?

I have a use case where a deeply nested component need access to the data defined in the loader, and for that we need the hook useRouteLoaderData, which this library does not currently support.

Is this something you are willing to add?

I am at version 1.3.0, and while I can see it in the source code, it is not being exported for consumption.
https://github.com/stargaze-co/react-router-typesafe/blob/2a25b3ed19602913d5fdfba19907ef65005d01e9/src/loader.ts#L20C14-L20C32

Can you add support for useAsyncValue similar to the one for Await's render function?