fraunhoferportugal / tssearch Goto Github PK

tssearch/utils/visualization.py, function plot_search_distance_result() doesn't map colors correctly. In particular the minimum and maximum distance colors are incorrectly assigned to out of range values, making the plot misleading.

Line 114 in Scaling of distance for color lookup is incorrect:
d_idx = int((d - min_dist) * cmap.N / delta_dist) - 1 # INCORRECT
correct code shown below.
d_idx = int((d - min_dist) * (cmap.N -1) / delta_dist)

Sample values with incorrect and corrected scaling
tsssearch_plot_bug.txt

Hi there,

I tried to run of the examples but i ran into an issue while loading the ecg sample data with tssearch.load_ecg_example()
I get the following error:

---

ValueError Traceback (most recent call last)
in ()
1 # Load the query, (optional) weight vector and sequence
----> 2 data = tssearch.load_ecg_example()
3
4 # Selects the Dynamic Time Warping (DTW) as the distance for the segmentation
5 cfg = tssearch.get_distance_dict(["Dynamic Time Warping"])

/usr/local/lib/python3.7/dist-packages/tssearch/examples/ecg_example_data.py in load_ecg_example()
8 filename = tssearch.path[0] + "/examples/ecg.pickle"
9 with open(filename, "rb") as handle:
---> 10 data = pickle.load(handle)
11
12 return data

ValueError: unsupported pickle protocol: 5

_

It seems to me that there is some conflict with the pickle version. I solved it by copy the load_ecg_example() definition into my python script and installing pickle5 with pip. Could you please fix this issue for future users?

Cheers,
Alex

Just a quick reminder to please add the novainstruments module to the requirements file, as it is not automatically imported upon setup. Thank you for all of your hard work!