[Feature Request] Add Typescript typedefinitions about charts HOT 11 CLOSED

@achillesrasquinha you misunderstood the request. @rajshrimohanks is asking for type definitions, not an angular wrapper.

from charts.

@achillesrasquinha Thanks. Let me see if I can do it over the weekend.

from charts.

I can take a first crack at the PR and perhaps you can review for correctness?

from charts.

Looking forward! 🎉 We just had @tobiaslins try a React example for the lib.

from charts.

Hello, any update on this? Closing otherwise. Feel free to reopen.

from charts.

I think the primary goal of the author was to stick with zero dependencies. You could still go ahead and create a wrapper for other view libs.

from charts.

Adding definition files will at least give your public api methods/classes some documentation because I didn't see much comment in code regarding the param types, class property types etc.

from charts.

Okay, my bad. We're not much into Angular, but we'd love you to send in a PR and maybe provide support for what you say.

The primary intention of this lib was to be integrated with http://github.com/frappe/erpnext
Never felt the use for it.

from charts.

@rajshrimohanks would you like help?

from charts.

@pspeter3 Would be great if you can. :) I've never written types for a third party library before, so it would be a while before I can figure out how to go about it.

from charts.

@pspeter3 Would be glad to do so. :)

from charts.