Code Monkey home page Code Monkey logo

Comments (7)

pratu16x7 avatar pratu16x7 commented on May 21, 2024 2

@chintan9 Could you elaborate on your changes? It's tough to make out from the build file.

from charts.

sakopov avatar sakopov commented on May 21, 2024 1

IE 11 doesn't support ES6. I don't think there is much you could do here.

from charts.

chintan9 avatar chintan9 commented on May 21, 2024

@sakopov It can work. you may test now http://jsbin.com/guvuvav/1/edit?html,js,output

capturfiles

you need this file https://raw.githubusercontent.com/chintan9/charts/master/dist/frappe-charts.ie11.min.js

from charts.

chintan9 avatar chintan9 commented on May 21, 2024

@pratu16x7 Simply I decompile you code to es6 (es2015) level and add polyfills for ie11.

I think we can do it for rollup also. you have to preset es2015 than ask user to add polyfill to support IE11.

from charts.

achillesrasquinha avatar achillesrasquinha commented on May 21, 2024

How about adding the polyfill into our src/scripts to make this simpler? Closing this for now. Please feel free to reopen.

from charts.

pratu16x7 avatar pratu16x7 commented on May 21, 2024

Will have to agree with @sakopov. About polyfills, from https://babeljs.io/docs/usage/polyfill:
This will emulate a full ES2015+ environment and is intended to be used in an application rather than a library/tool.

We don't intend to go that way; that'd defeat the zero-dep purpose. We'd be happy if there is a more elegant way to achieve this. Closing for now.

from charts.

chintan9 avatar chintan9 commented on May 21, 2024

@pratu16x7 Transpile whole lib to es5 would be solution. Meanwhile We put in docs support IE11 via environment
add only this line in head tag

<script type="text/javascript">
    if(/MSIE \d|Trident.*rv:/.test(navigator.userAgent))
        document.write('<script src="https://cdnjs.cloudflare.com/ajax/libs/core-js/2.5.1/shim.min.js"></script');
</script>

https://jsbin.com/biqoyuxomu/1/edit?html,js,output

It does not require any js changes on charts lib.

from charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.