frappe / bench_manager Goto Github PK

I noticed that new created sites does not reach and we can not access them
I think we need to build Nginx rules

• when button is clicked, show modal for "Select Domain"
• Run bench command

• git fetch a particular branch from master
• checkout to that particular branch
• stashing or commit changes
• git pull --rebase upstream develop

• bench restart to restart the supervisor process
• bench set-nginx-port for the site
• bench disable-production

In SPACE USAGE section, it should indicate the unit (e.g. kilobyte KB, Megabyte MB, Gegabyte GB …

@revant Hello! I have an issue where I can't seem to see the Bench Manager Desk, all I can see is the Frappe module. I'm using Ubuntu 20.4 on a VM running on MAC M1. I can see the Bench Manager App is installed, my Frappe Framework it's v14.x.x-develop.

I hope you can help me, thanks.

Whenever you go to Bench Settings page, run "Sync". Also store the last sync timestamp.
When you go to Bench Settings page again, check if "Sync" was run in the last 10 minutes, if not run "Sync" else dont

• Let bench manager run on a separate port.
• An nginx rule that will proxy that port to the bench manager site
• In common_site_config.json add bench_manage_port, bench_manager_site

I get this error when I open Bench Settings:

Traceback (most recent call last): File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 62, in application response = frappe.handler.handle() File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 22, in handle data = execute_cmd(cmd) File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 53, in execute_cmd return frappe.call(method, **frappe.form_dict) File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 939, in call return fn(*args, **newargs) File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 223, in sync_all sync_sites() File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 63, in sync_sites site_dirs = update_site_list() File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 114, in update_site_list for root, dirs, files in os.walk(".", topdown=True): File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 299, in walk for x in walk(new_path, topdown, onerror, followlinks): File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 299, in walk for x in walk(new_path, topdown, onerror, followlinks): File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 299, in walk for x in walk(new_path, topdown, onerror, followlinks): File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 289, in walk if isdir(join(top, name)): File "/home/frappe/frappe-bench/env/lib/python2.7/genericpath.py", line 46, in isdir st = os.stat(s) UnicodeEncodeError: 'ascii' codec can't encode characters in position 26-30: ordinal not in range(128)

a plane to do batch actions like backup, update,… etc on multiple sites in one click

Documentation

• create a new site + install app after installation
• cleaner screenshots

Bench settings

• Add a colour + icon for the desktop icon
• Rename "Bench Setting" to "Bench Settings"
• Let "Bench Settings" be the home page of the module, links to sites etc via dashboard
• Merge all sync (site + backups in one command)
• No msgprint when sites / backups are synced! (generally avoid messages like "please be patient")

Site

• Password must be of type password!
• In site, add config setting "disable website cache"
• Site delete should be via Command
• New Site -> hide sections by default
• In Site, app list not updated after install-app

Backup

• use naming like 2017-07-01 10:00:08-test.erpnext.dev so backups can be sorted in the list

Example :

https://github.com/frappe/bench_manager/blob/develop/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py#L41

Use os.path.join() to create paths.

We were testing this feature and it is broken for version 13

Define site limits like space and users

Hi every body
i installed bench manager after installing frappe /erpnext
and did the steps of installing .
as in this guid
https://frappe.io/bench-manager
the installation of bench manger is in the frappe-bench folder
after that i tried to access my localhos:8080 as usual which befor the installing bench manager take me to the home of ERPNEXT page login.
but now localhos:8080
take me to this thing in the page

Updating

Your system is being updated. Please refresh again after a few moments

Status: 503

so please guid me how to resolve such issue

Hello,

I have an issue with the console view.
Always stuck in this screen.

I use Chrome and Firefox but no luck, sometimes it show a console but it's not the actually.
What's the problem?

How can I start with the debug if no error shown in browser console.

Thanks a lot.

• Indicator to show whether the bench is in production mode or developer mode

i need bench manager in my apps, how to install bench manager in production env

We are checking the get app button to add new apps to the system but it does not work
We got this message

• self.fieldname can be changed to self.db_set(fieldname, value)
• frm.save can be replaced by frm.call(funcname)

Bench Manager is Awesome !! 👍
Just briefly had overview, and noted some minor fixes, as follows:

1. If user had Setup Multitenancy then at with Bench Manager, at Sites Overview, and "View site" feature, automatically should remove port with sitename.

Example: I have a site named, subdomain.domain.com and I can access website without ports, exactly because I already set up multitenancy earlier. Still, at Bench Manager, it will add ports to url, when it opens up in new tab. It will try to pull subdomain.domain.com:8000, while it will be not fetched and hence, we'll get timeout "This site can’t be reached".

2. Also, I doubt about REDIS and PORTS options, when bench was setup as multitenancy in Bench Settings. Because, there is mentioned URLs as "redis://localhost:12000" there should be server hostname(if someone changed hostname then?).
   

Either this section comes with default settings or we have to manage this accordingly? Also, multitenancy will affect these default settings or not? Just not sure, about the question but still raising for knowledge.

3. [Feature Request] Option to enable or disable DNS based Multitenancy. Might, based on enable or disable option, we can resolve issue reported in option 1("View site with default ports")

4. Download to desktop Backup with "Site Backup" feature.

• In modal, give option "develop,hotfix,staging,master"

I haven't tried out the app, however, it seems that the app allows you to modify the common_site_config.json. However, the config is actually used to generate other config files when the respective bench setup command is run.

For example, the key gunicorn_workers, is used to generate the supervisor config and accordingly set the right value for the number of gunicorn workers.

• remove console_command from whitelisted methods
• remove run_command from whitelisted methods
• ask for admin password for execution of critical commands like drop-site etc
  - [ ] add the command executioner field to run_command
• remove shell = True
• hide passwords from command logs

• list local branches
• ability to create a new branch
• checkout a branch
• make a new branch
• delete a local branch
• git fetch (updates remote branches)

Hi frappe team,
I have installed Bench Manager App in my ERPNext website, I am using Production Image of ERPNext in VirtualBox.
When ever i try to run Bench Manager I am getting below error, and form fields are disabled, also site list is empty.

> Traceback (most recent call last):
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/form/save.py", line 22, in savedocs
>     doc.save()
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 256, in save
>     return self._save(*args, **kwargs)
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 290, in _save
>     self.run_before_save_methods()
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 859, in run_before_save_methods
>     self.run_method("validate")
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 755, in run_method
>     out = Document.hook(fn)(self, *args, **kwargs)
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1024, in composer
>     return composed(self, method, *args, **kwargs)
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1007, in runner
>     add_to_return_value(self, fn(self, *args, **kwargs))
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 749, in <lambda>
>     fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
>   File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 29, in validate
>     sync_all(in_background=True)
>   File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 223, in sync_all
>     sync_sites()
>   File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 63, in sync_sites
>     site_dirs = update_site_list()
>   File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 114, in update_site_list
>     for root, dirs, files in os.walk(".", topdown=True):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 294, in walk
>     for x in walk(new_path, topdown, onerror, followlinks):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 294, in walk
>     for x in walk(new_path, topdown, onerror, followlinks):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 294, in walk
>     for x in walk(new_path, topdown, onerror, followlinks):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 284, in walk
>     if isdir(join(top, name)):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/posixpath.py", line 80, in join
>     path += '/' + b
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xd8 in position 1: ordinal not in range(128)
> 
> Traceback (most recent call last):
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 62, in application
>     response = frappe.handler.handle()
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 22, in handle
>     data = execute_cmd(cmd)
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 53, in execute_cmd
>     return frappe.call(method, **frappe.form_dict)
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 939, in call
>     return fn(*args, **newargs)
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/form/save.py", line 22, in savedocs
>     doc.save()
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 256, in save
>     return self._save(*args, **kwargs)
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 290, in _save
>     self.run_before_save_methods()
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 859, in run_before_save_methods
>     self.run_method("validate")
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 755, in run_method
>     out = Document.hook(fn)(self, *args, **kwargs)
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1024, in composer
>     return composed(self, method, *args, **kwargs)
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1007, in runner
>     add_to_return_value(self, fn(self, *args, **kwargs))
>   File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 749, in <lambda>
>     fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
>   File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 29, in validate
>     sync_all(in_background=True)
>   File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 223, in sync_all
>     sync_sites()
>   File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 63, in sync_sites
>     site_dirs = update_site_list()
>   File "/home/frappe/frappe-bench/apps/bench_manager/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py", line 114, in update_site_list
>     for root, dirs, files in os.walk(".", topdown=True):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 294, in walk
>     for x in walk(new_path, topdown, onerror, followlinks):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 294, in walk
>     for x in walk(new_path, topdown, onerror, followlinks):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 294, in walk
>     for x in walk(new_path, topdown, onerror, followlinks):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/os.py", line 284, in walk
>     if isdir(join(top, name)):
>   File "/home/frappe/frappe-bench/env/lib/python2.7/posixpath.py", line 80, in join
>     path += '/' + b
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xd8 in position 1: ordinal not in range(128)

in Site, add a button "Migrate" calls bench --site sitename migrate

Creating a new site with installing ERPNext option will throw an error in the ui but will create the site eventually!

error: "subprocess.CalledProcessError: Command '['bench', '--site', 'test.local', 'list-apps']' returned non-zero exit status 1."

Note: My console output is not working and maybe that's the reason

request database name form, so we can add custom db name for new site

For example, in the bench repo, there is already a function to update the site config : https://github.com/frappe/bench/blob/master/bench/config/common_site_config.py#L43

And you can use that instead of writing your own function : https://github.com/frappe/bench_manager/blob/develop/bench_manager/bench_manager/doctype/bench_settings/bench_settings.py#L28

If this repo is not maintained, please archive it

Bench Manager in Version 12 is not properly setup to fit in to the new Desk.