Code Monkey home page Code Monkey logo

swarth's People

Contributors

fofajardo avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

swarth's Issues

Under "Manage configured pages", selecting "Simple stylesheet" instead behaves as "Color inversion"

[verified with a fresh & new unmodified copy of Pale Moon Portable v29.4.4]

Simply put, under "Manage configured pages", if you select "Simple stylesheet" for a given website domain, it will instead behave as if you selected "Color inversion"

 

This is particularly problematic on pixiv.net where the artist's works page requires using "Simple stylesheet" (using "Color inversion" makes the text of visited links invisible) but an individual artwork page requires using "Color inversion" (using "Simple stylesheet" makes the actual artwork invisible).

Worse still is that this extension doesn't seem to be able to handle treating "pixiv.net/en/users" and "pixiv.net/en/artwork" with different stylesheet settings (if I add both, one of them just straight-up ignores the individual setting and instead just uses the global stylesheet setting)

For reference, both pages are technically functional with "Stylesheet processor" but it causes you to be blinded by the light. And another art website, deviantart.com only works correctly with "Stylesheet processor"

 

requires "Simple stylesheet" - Example pixiv.net artist's works page:
[anime warning] https://www.pixiv.net/en/users/1079073/artworks

requires "Color inversion" - Example pixiv.net individual artwork page:
[anime warning] https://www.pixiv.net/en/artworks/93980571

requires "Stylesheet processor" - Example deviantart.com gallery page:
[anime warning] https://www.deviantart.com/gigamessy/gallery/all

Stylesheet processor misses background on pixiv's dark theme unless you do a cached reload (i.e. NOT a Ctrl+F5)

This was tested with a completely new copy of Pale Moon portable 31.0.0

And for reference, in order to even access pixiv nowadays, you must first have "dom.webcomponents.enabled" set to 'true' in Pale Moon's about:config. From there, in order to enable pixiv's dark theme, you must be signed into an account on pixiv and then manually enable the dark theme by toggling the according switch in the drop-down menu that appears when you click your profile picture located in the top-right of any pixiv page.

 

Anyway, the issue is quite simple. If your pixiv account is set to use the dark theme then, whenever you first visit a non-cached page (e.g. the first time you navigate to an artist pixiv page), swarth's stylesheet processor won't fully "kick-in" and will miss processing the background unless you manually reload the page a second time. You can tell if this is the case because pixiv's default dark theme uses a dark-ish grey background while swarth by default uses a full-on black background (interestingly, it seems that swarth's colors for text and links are still correctly applied no matter what).

That being said, you can still reliably make swarth's stylesheet processor fail to activate by simply doing a complete uncached reload of the artist's page via Ctrl+F5 (or holding shift while clicking the GUI reload button).

I tested this using the following page, though it seems to occur with any artist:

Unable to Adjust Colours with Palette Selector

OS: Debian
Browser: Palemoon Version 29.4.4 (64-bit)
Swarth Version 1.0.5

Opening Swarth preferences allows me to interact normally with the Swarth preferences window, I can update a colour code in the box manually. However, when I click on a colour to update it via the colour selection window, that window pops up but is completely frozen.

Nothing will close it unless I go back to the Swarth preferences window and close that.

I'm not sure how you invoke this colour selection tool, but I must assume it's a palemoon tool and not something that you have added yourself. Either way I felt it was important for you to know this issue is happening, at least on the Linux version of palemoon.

If you'd like additional information or logs please instruct me on how I can generate that for you.

Stuck with default colors on a fresh installation if you change colors and set "Retain page style" at the same time

  1. do a fresh install of v1.0.4 and restart your browser

  2. load some webpage in a new tab (you can use this very github issue page you're currently reading)

  3. open swarth's preferences and set custom colors for at least (I haven't tried the others) "unvisited links" and "visited links" by manually typing in a value (e.g. I used "#ffcccc" and "#ccccff") - do NOT click "OK"

  4. before clicking OK, set the 'Default color method' to "Retain page style"

  5. click OK.

  6. without loading any other webpage, look at the tab you previously loaded from step 2 (e.g. this current github issue page)

From there, no matter if you then try changing the 'Default color method' setting to anything else, any webpage from any domain in any tab will always be stuck with the default visited and unvisited color links.

This issue only resolves itself if you either change the colors again or restart the browser.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.