Code Monkey home page Code Monkey logo

nano's Issues

Great job!

Great work here, guys!

I was thinking of Nano rewrite in Go, so I gave google a search - led me to here.

I will explore a bit more project in the following days, but can you please:

MessageHeader uses incorrect extensions size?

I was working on parsing the UDP packets being sent on the Nano network (not related to your implementation). I seem to get some malformed package headers, with respect to the extensions field, although it's hard to tell without a clear specification.

Reading the Nano code, specifically https://github.com/nanocurrency/raiblocks/blob/8caed829b461b015141d2dcd57d9b3457ba0f7f0/rai/node/common.cpp#L53, it seems the extensions field uses 2 bytes. But in your code,

Extensions byte
, I see you use 1 byte. Have you tested your code on the actual packets flying around, and did it parse them correctly?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.