francois2metz / steampipe-plugin-gandi Goto Github PK

Hey @francois2metz , we were excited to see you had started a new plugin for Gandi, and even though we are a bit early, we downloaded it and started playing around with it.

The basic structure and results look good so far. While using the plugin, we did come up with a few suggestions based on our best practices:

• In docs/index.md, I think internet would be a more suitable category instead of public cloud
• In config/gandi.sp, any thoughts on renaming the apikey param to key, like the Terraform provider does (https://registry.terraform.io/providers/psychopenguin/gandi/latest/docs)? There are multiple providers, but all of them seem to use key. I'm not sure how Gandi refers to this API key in its own docs or config, but if you wanted to keep the API key name, then a suggestion would be renaming it to api_key.
• At https://github.com/francois2metz/steampipe-plugin-gandi/blob/main/.goreleaser.yml#L22, scalingo should be updated to gandi
• When looking for an environment variable, since go-gandi uses GANDI_KEY, maybe we should use that too, instead of GANDI_API_KEY?
• The ColumnType_DATETIME has been deprecated and replaced with ColumnType_TIMESTAMP (our docs have some examples that are outdated and still use the deprecated one, so apologies if you were following those)
• Some columns in gandi_domain are missing descriptions (not sure if you were planning on adding those later, but figured I'd mention in case not)
• Does the SDK/API support pagination at all?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency go to v1.23.0

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository