Would you like to work on the issue?

-Yes

Describe the bug
The keyboard does not disappear unless the back button is pressed.

Expected behavior
When the user has created the badge needed and pressed the send button, the keyboard should go down automatically. It should pop up again only when the edit text is pressed.

Would you like to work on the issue?
YES.

Current, if the user does not allows permissions, app exit with a toast message. It is not a good user experience to close the whole application.
Show an alert dialog after denying the permission and ask again.

Describe the bug
When there bluetooth is not open and we click on send button, it is showing the toast instead of request for open the bluetooth.

To Reproduce
Step 1. Accept all permissions

Step 2.After entering in the app , turn off the bluetooth of android device

Step 3. Click on send button.

Expected behavior
It should make a request instead of toast.

Smartphone Info:

|Device | Asus Zenfone 2|
|Android Version| marshmallow 6.0.1 |

Would you like to work on the issue?
Yes.

Describe the chore

A older version is used. ext.kotlin_version = '1.2.10'

Would you like to work on the issue?

Yes

There are a number of nice animations possible with LED. Please check out this app and implement animations that work on real devices: https://play.google.com/store/apps/details?id=com.rooftopSpace.Led

Describe the bug
If the user denies Bluetooth permission to the app, there is no option shown in the dialog box for exiting the app.

Expected behavior
There should be an option to exit the app in the dialog if the user wants to deny Bluetooth permission.

Smartphone Info:

Would you like to work on the issue?
YES

Describe the bug
The color of speed and mode text views inside the spinner have become grey instead of black due to a recent commit.

Expected behavior
The color should be black.

Screenshots

Smartphone Info:

Would you like to work on the issue?

YES.

Describe the feature you'd like
A splash screen to improve look and feel of app

Screenshots

Would you like to work on the issue?
yes :)

Currently badges cannot be saved. Please add a save button. It would make it easier if the user does not necessarily has to add a name. However the name of the saved file - it should be possible to change it. Also ensure the user can export the saved file and open it e.g. on another phone.

Describe the bug
When you add a text and click on send button once, it gets disabled and then when we change some settings like speed or add marquee effect, the send button doesn't get enabled. One needs to exit the app and then again press send button

To Reproduce

1. Open app and add text
2. Press Send
3. Change settings like speed
4. Again try and press Send. (here it gets disabled)

Expected behavior
On changing any setting, Send button must be made clickable

Logs
N/A

Screenshots

Smartphone Info:

Would you like to work on the issue?
YES

Please configure the building of the apks in the apk branch as follows:

• Only build and overwrite apks from dev branch once dev branch PRs are merged
• Only build and overwrite apks from master branch once master branch PRs are merged
• The goal is that we see in the apk branch the different dates of the last merge and save build time as there are less apps to be build.

Naming Convention

• BadgeMagic-dev-debug.apk
• BadgeMagic-dev-release.apk
• BadgeMagic-master-debug.apk
• BadgeMagic-master-release.apk

Describe the chore
Migrate to androidX artifacts.
this means we don't have to use same support library version for all support libraries. Every support or better to say AndroidX library will maintain its own versioning . Maintaining support versions could be huge issues in the long run.

Would you like to work on the issue?
Yes

Describe the bug

App Stopped working due to FATAL EXCEPTION: main.

To Reproduce

Install App and allow Bluetooth, with no device connected. With empty field, click on SEND more than 3 times.

Expected behavior

If no device is connected, the device should give a message, may be in the form of Toast that device not connected or Scan could not find any device.

Logs

E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.nilhcem.blenamebadge, PID: 10565
java.lang.IllegalArgumentException: scanner already started with given callback
at no.nordicsemi.android.support.v18.scanner.BluetoothLeScannerImplLollipop.startScanInternal(BluetoothLeScannerImplLollipop.java:61)
at no.nordicsemi.android.support.v18.scanner.BluetoothLeScannerCompat.startScan(BluetoothLeScannerCompat.java:112)
at com.nilhcem.blenamebadge.device.bluetooth.ScanHelper.startLeScan(ScanHelper.kt:57)
at com.nilhcem.blenamebadge.ui.message.MessagePresenter.sendBytes(MessagePresenter.kt:36)
at com.nilhcem.blenamebadge.ui.message.MessagePresenter.sendBitmap(MessagePresenter.kt:25)
at com.nilhcem.blenamebadge.ui.message.MessageActivity$onCreate$3.onClick(MessageActivity.kt:58)
at android.view.View.performClick(View.java:6614)
at android.view.View.performClickInternal(View.java:6587)
at android.view.View.access$3100(View.java:784)
at android.view.View$PerformClick.run(View.java:26125)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6715)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:911)
I/Process: Sending signal. PID: 10565 SIG: 9
Application terminated.

Screenshots

Smartphone Info:

Would you like to work on the issue?

Yes

Build failed in the newer version of NDK 17c due to no toolchains for mips64el-linux-android. Working fine with version 16b. It should mention in the readme file to use an older version of NDK or provide a link to download a zip file for toolchain mips64el-linux-android.

Describe the feature you'd like
Right now, the send button is non-clickable after being pressed once for 10s. Instead it should just be disabled so that even if a user presses it, it appears to be clickable.

Would you like to work on the issue?

YES

Travis is already connected but not yet set up. Please help with that.

Describe the chore
An option of yes or no should be provided in the issue templates.

Would you like to work on the issue?
YES.

Describe the feature you'd like
An indication in form of a Toast message should be shown if no message is shown after scanning is done.

Would you like to work on the issue?
Yes.

Describe the bug
Bluetooth adapter is not turned on error is showing up as there's no check in the code.

To Reproduce
Turn off bluetooth and click send button.

Expected behavior
App should not crash.

Logs
AndroidRuntime: FATAL EXCEPTION: main
Process: com.nilhcem.blenamebadge, PID: 15932
java.lang.IllegalStateException: BT Adapter is not turned ON
at no.nordicsemi.android.support.v18.scanner.BluetoothLeUtils.checkAdapterStateOn(BluetoothLeUtils.java:136)
at no.nordicsemi.android.support.v18.scanner.BluetoothLeScannerImplLollipop.startScanInternal(BluetoothLeScannerImplLollipop.java:57)
at no.nordicsemi.android.support.v18.scanner.BluetoothLeScannerCompat.startScan(BluetoothLeScannerCompat.java:112)
at com.nilhcem.blenamebadge.device.bluetooth.ScanHelper.startLeScan(ScanHelper.kt:57)
at com.nilhcem.blenamebadge.ui.message.MessagePresenter.sendBytes(MessagePresenter.kt:36)
at com.nilhcem.blenamebadge.ui.message.MessagePresenter.sendBitmap(MessagePresenter.kt:25)
at com.nilhcem.blenamebadge.ui.message.MessageActivity$onCreate$3.onClick(MessageActivity.kt:69)
at android.view.View.performClick(View.java:6291)
at android.view.View$PerformClick.run(View.java:24931)
at android.os.Handler.handleCallback(Handler.java:808)
at android.os.Handler.dispatchMessage(Handler.java:101)
at android.os.Looper.loop(Looper.java:166)
at android.app.ActivityThread.main(ActivityThread.java:7529)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:245)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:921)

Smartphone Info:

|Device | Huawei Honor 7x |
|Android Version| Oreo 8.1 |

Additional context
Need to check if the bluetooth is enabled before starting the scan.

Would you like to work on the issue?
Yes.

Describe the chore
Current gradle plugin version is 3.1.4. It should be updated to the latest version i.e., 3.3.0 along with all other dependencies used in the app.

Would you like to work on the issue?
Yes.

Description

currently User clicks send , No visual representation is shown
button becomes non-responsive

ScreenShots

Non Responsive UX when sendBytes() works

Expected UX

1. Details(Or Name) of device where bytes are being sent should be shown to user
2. Progress when bytes are being sent to user
3. failure message when sendBytes() fails
4. Send button should be disabled when bluetooth found

Would you like to work

YES

Add a default template for submitting a new issue or PR.

Add spotless check to improve code quality, optimize imports and format the code with spotless.

Describe the feature you'd like
Navigation Drawer will show if the Bluetooth device is connected or not and also support the About and FAQ section making the app more user friendly

Additional context
It could be somewhat similar to that in case of PSLab app

Would you like to work on the issue?
Yes

Describe the chore
There should be an icon for the app instead of the default android logo.

Would you like to work on the issue?
YES.

I was thinking of making the icon like the badgeyay website. Could you please give your opinions @iamareebjamal @mariobehling of how the app icon should be designed?

1. Please change the app name in the app to Badge Magic. Please ensure strings everywhere in the app are changed.
2. Please change the colors to red similar to pslab.

Describe the feature you'd like
The color of the navigation bar is currently black. It should be made red to match the app theme.

Would you like to work on the issue?
YES.

Describe the bug
Cannot access send button when screen is rotated.

Expected behavior
Send button should be accessible.

GIF

Would you like to work on the issue?
Yes

Describe the feature you'd like
The "Speed" and "Mode" spinners have items that are hard to click, since their width is too less.

Screenshots

Would you like to work on the issue?
Yes!

Describe the bug

The AlertDialog asking for bluetooth permission is being recreated on rotation of the device.

To Reproduce

1 Open the app
2 Bluetooth alert dialog pops up
2 Rotate the device
3 Dismiss a dialog
4 An AlertDialog is still present

Expected behavior

Only one dialog should be present

Logs

Screenshots

Smartphone Info:

Additional context

Would you like to work on the issue?

Yes

Describe the bug
Reverse Engeneering... must be changed to Reverse Engineering...

To Reproduce
Open readme.md file

Expected behavior
Reverse Engineering must be there in the title

Logs
N/A

Screenshots

Smartphone Info:
N/A

Additional context
N/A

Would you like to work on the issue?
Yes

Description
The Badge should react according to the selected animation. Currently it only displays the Text onto the preview.

GIF of How it should work

Would you like to work on the issue?
YES

Describe the feature you'd like
A simple FAQs section which will guide users with simple questions.

Additional context
Dependent on #52

Would you like to work on the issue?
YES

Describe the bug
Some symbols such as cent, yen, or pounds are not yet implemented in the app symbols. When these symbols are typed and preview is pressed, the app crashes.

To Reproduce
Type the cent or yen symbols in the edit text and press preview. The app crashes.

Expected behavior
The app should not crash.

Smartphone Info:

Would you like to work on the issue?

YES.

Describe the bug

Source Code using older versions when newer versions are available for dependencies.

To Reproduce

Clone Source Code and after importing gradle.build will fail.

Expected behavior

Source Code should run and build successfully/

Logs

Screenshots

Smartphone Info:

Would you like to work on the issue?
Yes

There are a number of apps to use the phone as an LED screen. Please take inspiration and implement a preview screen to show how it will look on the actual device on the top. Compare for example to this app: https://play.google.com/store/apps/details?id=com.rooftopSpace.Led

Describe the bug
In GattClient, while connecting to gatt , if characterstic is null, it generates Unhandled Exception

To Reproduce
just try to connect any BLE device

Expected behavior
Handle this exception

Logs

Screenshots

2019-03-09 12:36:48.080 22582-22603/com.nilhcem.blenamebadge W/BluetoothGatt: Unhandled exception in callback
    java.lang.NullPointerException: Attempt to invoke virtual method 'int android.bluetooth.BluetoothGattCharacteristic.getProperties()' on a null object reference
        at android.bluetooth.BluetoothGatt.writeCharacteristic(BluetoothGatt.java:1155)
        at com.nilhcem.blenamebadge.device.bluetooth.GattClient.writeNextData(GattClient.kt:72)
        at com.nilhcem.blenamebadge.device.bluetooth.GattClient.writeDataStart(GattClient.kt:60)
        at com.nilhcem.blenamebadge.ui.message.MessagePresenter$sendBytes$2$3.invoke(MessagePresenter.kt:49)
        at com.nilhcem.blenamebadge.ui.message.MessagePresenter$sendBytes$2$3.invoke(MessagePresenter.kt:14)
        at com.nilhcem.blenamebadge.device.bluetooth.GattClient$gattCallback$1.onServicesDiscovered(GattClient.kt:42)
        at android.bluetooth.BluetoothGatt$1$5.run(BluetoothGatt.java:328)
        at android.bluetooth.BluetoothGatt.runOrQueueCallback(BluetoothGatt.java:770)
        at android.bluetooth.BluetoothGatt.access$200(BluetoothGatt.java:39)
        at android.bluetooth.BluetoothGatt$1.onSearchComplete(BluetoothGatt.java:323)
        at android.bluetooth.IBluetoothGattCallback$Stub.onTransact(IBluetoothGattCallback.java:111)
        at android.os.Binder.execTransact(Binder.java:731)
2019-03-09 12:36:48.138 22582-22603/com.nilhcem.blenamebadge D/BluetoothGatt: onConnectionUpdated() - Device=D3:C3:10:49:09:D8 interval=36 latency=0 timeout=500 status=0

Smartphone Info:
Device : Nokia 6.1
Android Version : 9.0 android pie

Would you like to work on the issue?
Yes

Describe the bug
I have a LED Badge which has its Bluetooth ID: FF:FF:2A:00:19:CA, and app is not able to detect it and send data while other app is able to detect and send data.

Expected behavior
It should detect this device and send data.

Smartphone Info:

Additional context
I tried CoolLED1248 app

Would you like to work on the issue?
YES, if it is a real issue to just an issue with my device. I'm not sure if it is a problem with my badge or with Scanning feature in the app.

The Led's Layout is Uneven

To Reproduce
Open the App in any XXXHDPI Device

Screenshots

Would you like to work on the issue?
YES

Describe the chore
Hardcoded values used must be in dimen.xml file since it is a good practice to follow.

Would you like to work on the issue?
YES

Describe the feature you'd like
A message should show up when there is no bluetooth device connected. For example a toast message or an alert.

Additional context
We could also disable the send button when there is no bluetooth device connected.

Would you like to work on the issue?
Yes

Describe the chore

There is no About or FAQS section in the app to describe it in detail which is present in most other apps.

Would you like to work on the issue?
YES.

@iamareebjamal @CloudyPadmal should I go ahead with this?

Please help to fix failing travis build.

Describe the bug
When the edit text is empty, the keyboard goes down and no alert is shown.

To Reproduce
Keep the edit text empty and press send. The keyboard goes down.

Expected behavior
The keyboard should not go down and an alert should be shown in the edit text.

Smartphone Info:

Additional context
A hint shall also be added to the edit text.

Update: Now the preview button has been introduced. Changes have to made for it also.

Would you like to work on the issue?
YES

Describe the bug
Currently the keyboard closes only when the send button is clicked and bluetooth is on.

Expected behavior
The keyboard should close even when bluetooth is off and the send button is clicked.

Would you like to work on the issue?
Yes

Describe the feature you'd like
Adding bug report or feature request form to get bug reports or requests

Additional context
Dependent on #52 where Navigation Drawer will be added

Would you like to work on the issue?
Yes

Describe the feature you'd like
Some symbols such as cent, yen, pound are not yet implemented in the app. I would like to implement these symbols.

Additional context
I would also implement any other missing symbols that I find.

Would you like to work on the issue?

YES.

Describe the chore
Snackbars should be used instead of toasts for better UI.

Would you like to work on the issue?
Yes

Please implement the possibility to send a Bitmap to the LED badge directly. Since we have a full control over the badge device, we can create a 40x11px bitmap and write some code to convert it into byte arrays we can send to the LED badge.