foray1010 / didyoumean2 Goto Github PK

The devDependency eslint-config-foray1010 was updated from 6.16.0 to 6.17.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-config-foray1010 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

I see in the changelog that you reverted a dependency upgrade for the fact that the upgraded version does not support NodeJS v4. However v4 is by now a very old version of NodeJS with v10 being LTS and that after V8 was LTS already for a very long time.

Should NodeJS v4 really still be supported in the library, especially if that means making compromises elsewhere?

In my opinion it is perfectly acceptable to go to 3.0.0 of this lib and drop Node v4 support. I'm saying 3.0.0 as I assume you would like to adhere by semver spec since you went from 2.0.3 to 2.0.4 for fixing a breaking bug, however bumping major version and introducing breaking API changes is perfectly acceptable.

I use your library in a React project. It runs just fine, and I quite fond of it.

Hovever I get an error message when I want to make a production build.

./node_modules/didyoumean2/dist/index.mjs
Can't import the named export 'distance' from non EcmaScript module (only default export is available)

I made a search and it seems that the react cli tools create-react-app could not handle a certain export type. I tried a suggested solution to add react-app-rewired and make a configuration change, but it is not working for me.

Now I stranded here.

Installation fails when installing with npm version 10.4.0. The npm install command runs the postinstall script, which attempts to run husky but fails as this is not listed as a package dependency. This does not occur when using npm version 10.3.0.

Output when using npm 10.3.0:

$ npm --version
10.3.0
$ npm install [email protected]

added 5 packages, and audited 6 packages in 3s

found 0 vulnerabilities

Output when using npm 10.4.0:

$ npm --version
10.4.0
$ npm install [email protected]
npm ERR! code 127
npm ERR! path /home/kjots/Development/Projects/didyoumean2-postinstall-issue/node_modules/didyoumean2
npm ERR! command failed
npm ERR! command sh -c husky install
npm ERR! sh: 1: husky: not found

I am using this package for a discord bot, but I have an array of my command names and when I try to sort through the array with this package it doesn't return a similar value.
here is a code example.

const didYouMean = require("didyoumean2").default;

let command_names = [ 'block',
  'stats',
  'config',
  'disable',
  'enable',
  'prefix',
  'user-config',
  'help',
  'invite',
  'ping',
  'server-perms',
  'guild-info',
  'info',
  'role-info',
  'notes',
  'enable-devmode',
  'guild-language',
  'toggle-dnd',
  'toggle-language-override',
  'toggle-ocr',
  'user-language',
  'regexes',
  'words' ];
const maybe = didYouMean('re', command_names, { // should find and return `regexes` since it is the closest value to `re` instead returns `help` because it comes before the value `regexes`
    threshold: 5,
    thresholdType: 'edit-distance',
    returnType: 'all-closest-matches'
});
console.log(maybe);

Neat stuff! I am a user of https://github.com/dcporter/didyoumean.js and was looking for a TypeScript version.

What I like about that version is the browser support and 1 file. Easy to copy/paste it into a larger library without requiring a dependency.

Just wanted to offer that feedback that might be useful to build for some browser targets in your "dist/" as well. Could also then build a web page with a demo.

Hi, I was using this package during a CJS->ESM migration and typescript stopped working.

I realized the fix for this was actually implemented a while back! Almost a year ago: 734187d

However it is not published to npm, which is still sitting at 5.0.0 and is over 2 years old! f011011

A lot has happened since then: v5.0.0...master and it would be great to finally release those changes to consumers