Comments (3)
Hi @janwalther thanks for your interest in Foil and the detailed issue.
And sorry for the trouble.
I think this is a regression bug that has been introduced with a section handling change I did in a previous release to fix a another bug. And it was not catched because missing test...
Can you please test if the bus is still there if you use stop()
/ replace()
instead of append()
?
An unrelated thing:
you could replace your:
<?php $this->section('content'); $this->stop(); ?>
with
<?php $this->supply('content') ?>
The reason to be of supply()
is just that: render section content if it exists, or do nothing if not.
from foil.
Same result with the following partial code (JS files get included twice):
<?php $this->section('end-body') ?>
<script src="/jquery.min.js"></script>
<script src="/intercooler.js"></script>
<?php $this->stop() ?>
<div ic-get-from="<url>" ic-trigger-on="scrolled-into-view"></div>
And also with $this->replace().
And in the end I would have to use append because there could be multiple partials which all want to append JS file embedding to "end-body" section.
Thanks for mentioning $this->supply(). I replaced all $this->section('name');$this->stop() with $this->supply('name'); but as said the JS files get included twice.
from foil.
Thank.
And yes, supply('name')
is just a shorcut for $this->section('name'); $this->stop()
won't solve the issue.
It definetively worked before, so it is a regression bug, I'll try to fix as soon as possible.
from foil.
Related Issues (20)
- SectionInterface::MODE_REPLACE causes child template inheritance to fail HOT 4
- `supply()` template method does not work when same engine instance is used to render more templates HOT 8
- Nested Blocks Fail HOT 4
- 0.6.4 is now repeating content sections within a loop HOT 8
- Some issues when creating custom helpers HOT 1
- Engine option to echo rendered output HOT 6
- Retrieve Data Inside Templates: loops HOT 14
- Code in overwritten sections runs HOT 2
- Option to not arraize some data HOT 1
- Arraization(?) is turning my Eloquent collections into strings (not arrays) HOT 1
- Trimming output? HOT 5
- New line in doRender of Engine class HOT 3
- Markdown Block HOT 2
- Link to blog post has no content HOT 2
- is not a valid template name HOT 1
- Development roadmap HOT 1
- Documentation website not working HOT 3
- Multiple section replace don't work HOT 2
- Post calls not working on PHP 7.1 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foil.