`supply()` template method does not work when same engine instance is used to render more templates about foil HOT 8 CLOSED

Hi @brad-jones and thanks for your interest in Foil!

Sorry, but I tested your exact example and supply() works as expected.

I think your problem is in <?php $T->layout('layouts/master') ?>

Using layouts/master and having instantiated the engine with 'folders' => ['/views'], Foil will search for views/layouts/master.php, are you sure that is the right path?

from foil.

I created a Gist with all the files I used to test this issue https://gist.github.com/Giuseppe-Mazzapica/6e3ae0aeb8e9fce54818 You can download it, and after composer install you can see that the rendered content is what expected...

from foil.

Hi @Giuseppe-Mazzapica,

Ok I got to the bottom of it, I knew I wasn't crazy.
Have a look at: https://gist.github.com/brad-jones/6279ce76cbedc2584675

Let me know what you think. For now my quick fix is to make sure the Foil engine is newed up each time it is requested from my DI container.

Cheers Brad

from foil.

@brad-jones Ok, I see the issue. This is something that was noted already and fixed when sections are rendered using template inheritance (see #25), but was not fixed when sections are used with supply().

I'll fix this as soon as possible.

from foil.

@brad-jones it should be fixed now.

Can you please require Foil from dev-master and give it a try? If it works I'll release 0.6.4 including this change.

I ran the test in your Gist (https://gist.github.com/brad-jones/6279ce76cbedc2584675) replacing

"require": {
    "foil/foil": "*"
 }

with

"require": {
    "foil/foil": "dev-master"
}

in composer.json and it works, but some tests in real world project would be nice.

Thanks for reporting!

from foil.

@Giuseppe-Mazzapica mate you are a legend!

I just got into the office, I will get back to you in the next few hours with some real world testing in my wordpress theme.

from foil.

@Giuseppe-Mazzapica feel free to release v0.6.4.

Seems to be working fine for me

Thanks again.

from foil.

@brad-jones thanks a lot for reporting and testing.

from foil.