fluidgroup / brightroom Goto Github PK

Error message

Undefined symbols for architecture x86_64:
"Brightroom.EditingStack.State.Loaded.currentEdit.setter : Brightroom.EditingStack.Edit", referenced from:
key path setter for Brightroom.EditingStack.State.Loaded.currentEdit : Brightroom.EditingStack.Edit : Brightroom.EditingStack.State.Loaded in BlurryMaskingView.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@muukii

How do I properly use and add the filters from the Demo to my project and use them?

is there a way to edit the Gaussian Blur effect like the Vignette effect ?

adds unit tests that compare result image and expected image.

How do I compare images?

Metrics:

• Color space, wide-color
• Orientation
• Performance
• Cropping
• loading MTLTexture
• resizing

@muukii

after select an image and then present PhotosCropViewController, the image with a default filter. and image resize bar is not showing

After applying filters with LUT, the controller is not loading images on scroll. I think issue of reusable cells. Can you please look into this? or can any one suggest which file to change?

Any help would be appreciated.
Thanks

Can we use gif in CIImage and write it through CIContext?

Version of Pixel: 0.0.9
Xcode: 11.0 beta 6
iOS: 13 beta

As in attached screenshoot there is an issue with previewing images with filters on newest iOS 13 beta.

Overview

Details

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKitCore/UIView.h> may also be helpful.
2021-04-08 23:55:01.887331+0700 statusWhatsapp[59403:5844925] [Unknown process name] CGBitmapContextInfoCreate: CGColorSpace doesn't support output
Fatal error: Unexpectedly found nil while unwrapping an Optional value: file Brightroom/ImageSource.swift, line 64
2021-04-08 23:55:01.888192+0700 statusWhatsapp[59403:5844925] Fatal error: Unexpectedly found nil while unwrapping an Optional value: file Brightroom/ImageSource.swift, line 64

Reproduce version

Add ColorCube filter is throwing me this error. Is there a work around?

Also what is the identifier and lutimage property in the :
let filter = FilterColorCube( name: "Filter Name", identifier: "Filter Identifier", lutImage: lutImage, dimension: 64 )

after pod installation xcode says no such module while importing PixelEngine or Pixel Editior

i m using xcode 10 and swift 4.2

@muukii For large images cgContext.draw(cgImage, in: CGRect(origin: .zero, size: canvasSize)) in public func render(resolution: Resolution = .full) -> UIImage takes too long, about a minute.
Can you please suggest how this can be fixed?

Hi there!

Few days I am trying to disable "cube cropping" to display image at it is (with same aspect ratio), but can't find correct lines at framework.

Can you please explain me where is this function.

Hello All,

Now my question is how to add Text in this library.

Any suggestion

Is support for Xcode 12's "Swift Package Manager" coming?

Thanks

A long time has passed from the first release.
And we've got many feature requests and some issues. Thank you for trying to use this library out.

Currently, I don't have enough time to maintain this lib but I'm thinking of how we could make it to be better than now.

Now I have followings:

• Recently, handling media software contains so many features and user interfaces, it seems the one application that can be released as a product. That's why I think it needs something good state-management (like Verge)
• The UI to modify image differs from each use-case in products. So it should be easy to switch with other types of UI. That's why I architected PixelEngine and PixelEditor.

When i present controller like this

let image2=UIImage.init(named: "22")
let controller = PixelEditViewController(image: image2!)
self.navigationController?.pushViewController(controller, animated: true)

it does not show filters list however editing image works perfectly.

it show output like

Untitled.trace.zip

Hi,
How to generate lut.png files e.g. from Lightroom presets?

For example, the following chart

Hello, @muukii .

Environment

Pixel: 0.2.1
Xcode: 10.3 or 11.0_GM
build by Carthage

Summary

Dependency library of Pixel require sdk12.2 or higher version building by Carthage.
Our product support ios10.x yet. We can not continue to use Pixel.
Can you reduce minimum version of your dependency library when building by Carthage?

ScreenShot

Additional information(9/18/2019)

When building by Cocoapods, successed.
I can continue to use PixelEngine with no problem.
But hopefully I want to use charthage version.

Overview

I have added in my Podfile:

pod 'Brightroom/Engine', '2.0.0-alpha.9'
pod 'Brightroom/UI-Classic', '2.0.0-alpha.9'
pod 'Brightroom/UI-Crop', '2.0.0-alpha.9'

And when adding:

import BrightroomUI
import BrightroomEngine

It gives me No such module 'BrightroomUI'

Details

Here is my complete Podfile:

source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '13.0'
use_frameworks!

target 'project-ios' do
	pod 'Alamofire', '~> 5.2'
	pod 'Kingfisher', '~> 6.0'
	pod 'KeychainAccess'
	pod 'Instabug'
	pod "PromiseKit", "~> 6.8"
	pod 'Brightroom/Engine', '2.0.0-alpha.9'
	pod 'Brightroom/UI-Classic', '2.0.0-alpha.9'
	pod 'Brightroom/UI-Crop', '2.0.0-alpha.9'
end

Would any of you have any solutions for me?

Example :

It's slow that CIImage from MTLTexture in UIImage embedded in UIScrollView

Why is the code indentation two spaces?
This is not a standard code format. I tried to format the code, but it didn't work. What changed in the project?

Hello, when I open pixeleditor with rectangular image, it does not fit in ImagePreviewView. Is there any way that I can also use rectangualr image? It works well when I open with square image.

How can I make the editor controls view shorter so there's less white space, and I can make the image view larger?

will you add support for a format other than square?

How to add dark mode support for PixelEditViewController?

Thanks/

Is there any way to apply any filter to multiple images at once?

I have a requirement where multiple images can be picked and passed to a scene which should be able to apply a filter by clicking any of the available filters. It's similar as how the multiple selection for Instagram works. I'm attaching a photo for easy understanding:

The code written here https://gist.github.com/JoshuaSullivan/b575d96bfd8a4177d8d46352e5f36458 to apply a LUT to an image using CIColorCube works really well.

But I'm having one problem, when I use a black & white LUT the result isn't the expected.

This is the LUT I'm using:

This is the result:

I want to make control view smaller, as I don't see why is has to be so high, but I can't figure out how to do that.

Red square is what it is now
Green square is what I want it to be

Thank you

When I download your repo and do pod install I receive the following error
_Error installing MosaiqueAssetsPicker
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists._

Do you know how to fix this permissions error

P.S.
Thanks for your great work

please add a filter category and the ability to set opacity for the filter

Hi,
I want to remove some of the options which are provided in edit options, so can anyone let me know how can I remove unwanted options?
For e.g, I need to remove the edit option 'Mask' and 'Adjust'.

Thanks

I want to show full image in edit or filter view but at the moment I only get cropped image if image size is too large.
Any idea how to do this?

I'm already on the PixelEditViewController page, but I don't want to pop back, how do I switch or change to a new photo?

When we open PixelEditorViewController, memory usage is very high that can see with Instruments.
It seems that ImageTool.resize cause this.

https://developer.apple.com/videos/play/wwdc2018/416/

I want to get which filter is applied to image in "PixelEditViewController"