flowrey / youtube-bz Goto Github PK

Problem to solve

We need to check if tests works in older python versions.

Proposal

Use matrix in GitHub action.

Further details

https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs

Summary

When can't install youtube-bz with poetry

Steps to reproduce

Run poetry install

What is the current bug behavior?

Unable to install the software

What is the expected correct behavior?

Install the software

Relevant logs and/or screenshots

Note: This error originates from the build backend, and is likely not a problem with poetry but with aiohttp (3.8.5) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "aiohttp (==3.8.5)"'.

Problem to solve

The Dockerfile is using pip to install the youtube-bz.

Proposal

Use poetry instead.

Problem to solve

We could add a way for user to add or download release from their collections

Proposal

Use the collections API of musicbrainz

Further details

We may need to add authentication

Problem to solve

There is no way to choose the output directory when downloading a release

Proposal

Add a --destination option to choose a destination directory

Further details

By default keep downloading to current directory

Problem to solve

Imports are not sorted

Proposal

Create a github action to check if import are sorted with isort

Further details

Use isort with the black profile: https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#isort
https://pycqa.github.io/isort/docs/configuration/github_action.html

Problem to solve

Currently, there is no indication of the progression of a download

Proposal

Add a progress bar to see the progression

Summary

Getting the error:

    def _lookup(self, entity_type: str, mbid: str) -> dict[str, Any]:
TypeError: 'type' object is not subscriptable

Any youtube-bz call produces the same error. Any ideas?

Problem to solve

The documentation is very poor actually.

Proposal

Include API doc and use RTD theme.

Problem to solve

Remove the dependencies to pydantic, it's overkill to use it for our needs

Proposal

Use typed dict or custom class instead.

Problem to solve

Currently to find a release we need to go to MusicBrainz website. It would be nice to be able to search for a release directly from the CLI.

Proposal

Add a search command to find a release.