Code Monkey home page Code Monkey logo

Comments (5)

floklimm avatar floklimm commented on July 17, 2024

That the checksum is zero means that all your p-values are in (0,1]. That your optimization fails indicates that the p-values don't follow the beta-uniform model (BUM).

Maybe inspect your p-value distribution in a histogram and check whether you see any unexpected behavior.

If you don't see anything obviously wrong you can always create node-weights from p-values in a less statistically rigorous (but still reasonable) way:

node score = log(p-value) + X
where X in (-Inf,+Inf) is an offset, which varies the size of the functional module you will get. The smaller the offset, the smaller the module you obtain.

A good starting point to play around with X is around -1. (At least in some experiments we did for our data.)

from scppin.

deevdevil88 avatar deevdevil88 commented on July 17, 2024

Thanks for getting back. I think you are right there is something wrong with the pvalue distribution. As i was using the multiple test corrected p-values, and i guess for some cell types the distribution was more heavily inclined to very low p-values than 1s and perhaps thats why the pvalues dont follow the BUM . When i reran the process for these cell types using the uncorrected pvalues it ran fine. I was wondering, in the paper and the tutorial are you using the corrected or un-corrected pvalues?
I will rerun the analysis by playing around with the X.

Thanks,
Devika

from scppin.

floklimm avatar floklimm commented on July 17, 2024

It is best if you use uncorrected p-values to ensure that they are all in (0,1]. That's what we did in the paper, too.

Glad to hear that it works with the uncorrected p-values.

from scppin.

deevdevil88 avatar deevdevil88 commented on July 17, 2024

Thanks Florian.
another question did you always get a high (> 0.05) p-value so that you could accept the null hypothesis of the KS test that the distributions are similar. Because i dont always get a p> 0.05 ,but get a low D statistic.

Example using un-corrected pvalues

One-sample Kolmogorov-Smirnov test

data: AT_DAT_H_pValues
D = 0.030435, p-value = 2.15e-09
alternative hypothesis: two-sided

image

from scppin.

floklimm avatar floklimm commented on July 17, 2024

In the example we discuss in the SI of our paper we do:
"The BUM is in decent agreement with the observed p-values (a one-sample Kolmogorov–Smirnov test yields a statistic of D ≈ 0.014 and a p-value of 0.086)."

We got similar results for other data we analysed.

To be honest, I wouldn't worry too much if the KS-test is not significant: you still can use the scPPIN pipeline and the scoring function. But you probably shouldn't completely trust the false discovery rates that we specify.

from scppin.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.