floatdrop / express-error-with-sources Goto Github PK

Express error should gracefully show other kind of errors, instead it failing with:

TypeError: Cannot call method 'split' of undefined

Все ошибки возвращаются с 200 кодом

https://github.com/floatdrop/express-error-with-sources/blob/master/lib/expressError.js#L15

Приходится так писать

var errorHandler = require('express-error-with-sources')();

app.use(function (err, req, res, next) {
    res.status(500);
    errorHandler(err, req, res, next);
});

It feels like we missing node-stack-trace-parser module, which will support source code in stack trace. Also some code can be done with util.format alike module (prepending line numbers with spaces and stuff).

In this module I will left only html generation (and will fix error line highlighting).

• Use parsetrace module
• Hightlight error line

If a middleware calls next(new Error('Foobar')) then this module throws an exception. You should probable check if err.stack is defined before calling parsetrace(err).

Here's my workaround FYI:

    fn = require('express-error-with-sources') contextSize: 3
    app.use (err, req, res, next)->
      if err.stack
        fn err, req, res, next
      else
        next err