Code Monkey home page Code Monkey logo

Comments (13)

Jeehut avatar Jeehut commented on July 28, 2024

Thank you for reporting the issue @superandrew. I can see a few potential problems from your screenshots:

  1. Your nowr-LaunchScreen.storyboard is not localized in Italian (nowr-LaunchScreen.strings is missing in it.lproj
  2. LoginViewController.xib is not String-localized, meaning in it.lproj there should be a LoginViewController.strings file instead of a .xib file
  3. Same is true for SignupViewController.xib

Please make sure you always localize all localizable files in all the languages you support in your project. Otherwise BartyCrouch might not work as expected. If you don't need to localize a Storyboard (like the nowr-LaunchScreen) then you should simply unlocalize the screen entirely so it doesn't appear even in Base.lproj.

from bartycrouch.

Jeehut avatar Jeehut commented on July 28, 2024

I'm closing this due to inactivity.

from bartycrouch.

tirrorex avatar tirrorex commented on July 28, 2024

You should add that to the documentation imo (the fact that if we don't localize we need the storyboard in dev language not base langauge).

from bartycrouch.

Jeehut avatar Jeehut commented on July 28, 2024

@tirrorex I'm not sure what you mean, but feel free to post a PR with your improvement in the README. :)

from bartycrouch.

tirrorex avatar tirrorex commented on July 28, 2024

"Please make sure you always localize all localizable files in all the languages you support in your project. Otherwise BartyCrouch might not work as expected. If you don't need to localize a Storyboard (like the nowr-LaunchScreen) then you should simply unlocalize the screen entirely so it doesn't appear even in Base.lproj."

This should be in the documentation

from bartycrouch.

Jeehut avatar Jeehut commented on July 28, 2024

Thank you @tirrorex for the text. That's not exactly a PR but I've included it into the README myself nearly as is (just removed the "nowr-" in front of "LaunchScreen") via 3b5b084. 🙂

from bartycrouch.

jameshays avatar jameshays commented on July 28, 2024

Alright, I know this is closed and old, but a nice addition would be to generate the file that is missing. I know, PRs are always welcome. :)

from bartycrouch.

Jeehut avatar Jeehut commented on July 28, 2024

Alright, reopening. ;)

from bartycrouch.

Jeehut avatar Jeehut commented on July 28, 2024

Is this still an issue with version 4? I feel like I tackled this in #114. So closing for now until someone reports otherwise.

from bartycrouch.

thejeff77 avatar thejeff77 commented on July 28, 2024

I'm seeing this currently. If you go to the base project and remove a localization, and bartycrouch runs the build script outlined in the documentation, it still tries to find that localization. Not sure why that is but it would be awesome if someone could fix this!

from bartycrouch.

Jeehut avatar Jeehut commented on July 28, 2024

@thejeff77 Thank you for reporting this. Can you please give me some further information to understand the problem better:

  1. What do you mean by "go to the base project"? Do you mean the Base.lproj directory? Or do you mean a target in Xcode where you remove a language?
  2. How do you know that BartyCrouch is trying to find that localization still? Can you try to run the two commands from the build script manually and give me the full output?

from bartycrouch.

thejeff77 avatar thejeff77 commented on July 28, 2024

@Jeehut Hey there, thanks for the quick reply!

I'll keep this notification email unread and reply again with error messages next time I enable the bartycrouch update in my build scripts.

For now, to unblock the story, I'll give you what I can right now:

What do you mean by "go to the base project"? -> Your second answer is correct: "... a target in Xcode where you remove a language"

Yeah its the top level target with the xcode icon on it - where you set supported languages for the whole project.

How do you know that BartyCrouch is trying to find that localization still?

After clearing all Derived Data, clearing the Project Data, restarting XCode, rebuilding, deleting & re-installing the app, I still received an error about the removed language not found by bartycrouch from the "bartycrouch update -x" command in the run script phase of the build.

Can you try to run the two commands from the build script manually and give me the full output?

Yes. Stay tuned. For now you should have enough info to see if it is reproducible and unblock the bug. I'm curious if you see the same behavior!

Thanks, and let me know if you have any additional questions.

from bartycrouch.

thejeff77 avatar thejeff77 commented on July 28, 2024

Turns out removing that localization from the main target doesn't delete the folder.

If the folder isn't deleted, bartycrouch won't ignore it. In my case it was vi.lproj

Might be something to take a look at? I.E. check the target languages instead of the physical file system - as the master of the languages is the target, not the filesystem.

from bartycrouch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.