flauschbaellchen / atheme-ruby Goto Github PK

If you change one or more attributes of an entity, e.g. a channel, it won't be synced with the object itself.
Example:

@session.chanserv.info("#opers") do |channel|
  channel.url                     #=> nil
  channel.url!("www.example.com") #=> Sets an url for the channel
  channel.url                     #=> nil
end

# or

channel = @session.chanserv.info("#opers")
channel.url                     #=> nil
channel.url!("www.example.com")
channel.url                     #=> nil

# but (as the object is fetched and initialized again):

@session.chanserv.info("#opers").url #=> nil
@session.chanserv.info("#opers").url!("www.example.com")
@session.chanserv.info("#opers").url #=> www.example.com

Sure, there are some workarounds which would fix this..
But they would mess up the code.
I'll leave it as it is until I have a really good idea or decide to put up one of the workarounds. (Ideas welcome!)

Allow developers to assign hooks to particular methods like:

hook_on :chanserv, :info do
  log "Someone asked for the info of channel X"
end

Currently all service-calls are simple fallbacks to a #method_missing which handles the call to the API.
In addition the parser-blocks are called with #instance_eval.
This is slow and not really a code someone would really love.

Solution:
Get rid of it and implement all methods to the respective service-classes.
Use method_missing only as the last fallback.
This will allow us to:

• get an improvement in performance and in code-style
• write a better documentation for each method
• implement different return values and handlings of parsers more easily
• implement aliases like chanserv#info, chanserv#channel
• implement #2 easier