flashflashrevolution / rrr Goto Github PK

https://gafferongames.com/post/fix_your_timestep/
https://github.com/tuzz/game-loop

xml-rs is Unmaintained

xml-rs is a XML parser has open issues around parsing including integer
overflows / panics that may or may not be an issue with untrusted data.

Together with these open issues with Unmaintained status xml-rs
may or may not be suited to parse untrusted data.

Alternatives

• quick-xml

See advisory page for additional details.

Currently in crates\core\src\play\mod.rs

• When a note has an associated judgement, it should not be rendered.

https://github.com/DioxusLabs/dioxus

• Transparent div
• Button (log "Hello World!")
• Validate Desktop pixels rendering path (get window, create draw surface)
• Validate web rendering (get canvas, create draw surface)

Success Condition:

• See buttons and pixels output rendering beneath them.

Libraries

• Fetcher Library
  • Responsible for streaming http and disk resources.
  • Caching layer (Local storage)
  • Not sure how the typing will work here.
• Data Library
  • Responsible for populated Playlist, Song, Player, and Leaderboard data. (etc...)
• Chart Simulator
  • Iterated with a ms delta to simulate a view into a chart. (Record, Turntable, etc...)
• Renderer
  • Blitting or wgpu rendering library, takes note metadata and a noteskin and renders it to a render target.
• Audio Library
  • Iterated with a ms delta to play back an audio file. (Essentially dependency isolation.)

Heads

• Web Library
  • Exposes each of the above libraries to typescript, so the UI can interface with each of them as it sees fit.
  • I believe for simplicity we may want to have the Typescript code orchestrate the game loop. Since the majority of the "game" is in the UI, it makes sense for that component to be in the web. (As many functionalities as possible can be migrated to WASM so that native versions can be created with as little duplicated code as possible.)
• UI Library (Native optional)
• RRR Executable (Native optional)
  • Integrates all of the libraries and runs the loop.

• Receptors
• Misses
• Sane judge window

Reference: ChartStepmania

Rewrite judgement to use song_progress - note_ms == 0, and view to use [song_progress - receptor_offset .. song_progress + some_ms].

Currently I am calculating judge zero with note height offset, screen height, and a "time on screen" value.
Instead I should be:

• Calculating the render position of notes and receptors using those values.
• Judge zero should be at receptors.
• To render past judge zero, extend the view behind song_progress by some_milliseconds calculated at start using the same screen values.

Reasoning:

• Easier logic for judge.
• Judgement can happen in headless using exact ms values with no care for offsets or screenspace.
• All "adjustments" happen in the HEAD and never survive in core or as a setting.

stdweb is unmaintained

The author of the stdweb crate is unresponsive.

Maintained alternatives:

• wasm-bindgen
• js-sys
• web-sys

See advisory page for additional details.

• Add MONO to STEREO mp3 conversion capability.

https://github.com/webrtc-rs/webrtc

Javascript example:
https://mitxela.com/pong/
https://mitxela.com/projects/webrtc-pong

Use STUN for connection initialization

Reference: ChartFFR

• ChartLegacy

@fizzybuzz made a theoretical rework of the module hierarchy.
https://tree.nathanfriend.io/?s=(%27options!(%27fancy5~fullPath!false~trailingSlash5~rootDot5)~7(%277%27audioBoutput06yer0resampler-chart*bpm03note0paAer*2bincode02swf-8B6ylist-mathBlerp-6tformBnative40web4-6y*actions0judge0mod-lib-record-settings-turntable-%27)~veAion!%271%27)*92-.A90.A*2%20%203mod04*2802time5!true6pla7source!8fetch9%5CnArsB*3%01BA987654320-*

Adopt it entirely or partially after review.

Either add dependabot-auto-merge or switch to renovate.

https://github.com/marketplace/actions/dependabot-auto-merge
https://github.com/renovatebot/renovate

anymap is unmaintained.

The anymap crate does not appear to be maintained, and the most recent
published version 0.12.1 includes a soundness bug. This has been
fixed a few years ago, but
was never released.

See advisory page for additional details.

rrr as a stateful struct.

• Turntable seek-able position
  • Test: Get view at any progress
  • Test: Test Judgment at any progress
• Test: Action playback (manual delta progression)

At exactly 118 - offset ms late misses are realized and no further judgements can be made.

What version of RRR are you using?

d762eec

What operating system are you using RRR on?

Web

Describe your bug.

It's impossible to hit the minijack in the tested song.
~31500ms-ish
Blue 8th followed by Yellow 16th
The 2nd '16th yellow note' in the minijack misses everytime with no boo or any other judgement

What are the steps to reproduce the behavior?

Play song, hit notes, miss.

What is the expected behavior?

Should hit the note.

Reported by Goldstinger https://discord.com/channels/196381154880782336/693641317636505629/1024860773803106465

Calculate judge window zero at these moments:
- [ ] Game Instantiation
- [ ] Screen Resize
- [] Scroll Speed setting change event

• Song start