fivemods / fivemods.net Goto Github PK

Add fivemods management mail as BCC to payment mails

Add automatic issue creation feature to the discord bot
e.g.

-bugreport bug
needs to get confirmed
if so create issue on github

move all legal pages into /legal/
change design
improve legal pages based on german law

The dropdown menu will not close when pressing the button, only open

Fix error pages

Please go though the FiveMods pages and search for missing translations / wrong translations (German)

The line above is an example of the type of thing that needs to be fixed. Storing all of these session variables on login and relying on them to be present will create a handful of unintended bugs down the line. Yes, it is easier to access information, but it will come back to stab you in the back later down the road. Do the proper thing and request what you need from the database when you need it.

On the about us page (https://fivemods.net/about-us/) several images are still with the old logo, those need to be changed.

Create own mailserver to send and receive mails

In the description preview, the formatting markdowns are shown.
https://i.imgur.com/7544YY7.png

• Upload Policy
• Ban Policy
• Billing agreement

e.g. user id is not 1, 2, 3, its 1, 324 ,423

there's a big gap

Prepare repo and code to go public

• Remove tokens
• Remove secrets if still in code
• Remove sensitive stuff

Lets see

Geo IP check is overwriting chosen language.
Add language cookie and profile preference.

Send mail to seller if product was bought!

Fix mobile issues e.g. on partner page or the background

Still not changing whitespace to underscore, major issue!
Causing multiple display issues.

Replace Placeholders with real text

e. g. https://media.discordapp.net/attachments/761302247052673105/832980752719151134/Desktop_Screenshot_2021.04.17_-_21.57.30.49.png

Fix ad placing

Add static ads and remove dynamic ads

Rework profile and mod interface

• Change the current profile layout and design
• Change the current mod edit layout and design

• API
• Implement "Developer Settings" Tab in User with API token (maybe oauth id?) & secret
• Should be Editable (e. g. GitHub, Discord and Google login should be controlable via ACP (DB)
• Improve the status page

Add pagination enhancement

Change from
https://ext-cdn.fivemods.net/img/333173cf6614fb9abfec0ad77b079fb1.png

to something like this
https://ext-cdn.fivemods.net/img/a0f4a86dbfd44dc0839b73070b4d9730.png

Add a Price Suggestion
User that are not part of the Partner Program: up to 5 euros
User that are part of the Partner Program: unlimited

Should be approved seperately in ACP (!)

• Dashboard (Mod uploads, user registrations,
• User -> See IP, see login provider

Rework / enhance deferral system
(Maybe task for @AwesomeCore1)

Ideas:

• Connect to DB with list of blocked domains
• Enhance list of blocked domains
• Check for inlink urls
• Maybe add dynamic system with detecting outgoing links

Please stop creating PDO sessions everywhere. I estimate that there are roughly 15-20 mysql connections/request. You can prepare more than one statement per PDO session. None of these PDOs are closed properly after being used, so all throughout the duration of the request, there's just dangling PDO sessions.

$pdo = new PDO("mysql:host=$servername;dbname=$dbname", $username, $password);
$pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);

...

$insertDB = $pdo->prepare("INSERT INTO user (sid, uuid, oauth_uid, oauth_provider, email, picture, locale, description, main_ip) VALUES (:sid, '$v5uuid', :id, 'Discord Inc.', :email, :picture, :locale, :description, :mainip)");
      $insertDB->execute(array('sid' => $sid, 'email' => $email, 'picture' => $fileName, 'description' => "No Description Set.", 'mainip' => $main_ip, 'id' => $uid, 'locale' => "-"));

    	$servernameP = $mysqlPayment['servername'];
      $usernameP = $mysqlPayment['username'];
      $passwordP = $mysqlPayment['password'];
      $dbnameP = $mysqlPayment['dbname'];

      $pdoPayment = new PDO("mysql:host=$servernameP;dbname=$dbnameP", $usernameP, $passwordP);
      $insertUser = $pdoPayment->prepare("INSERT INTO payment_user (oauth_provider, oauth_id, uuid, username, email, country_code) VALUES (:provider, :id, :uuid, :username, :email, :country)");
      $insertUser->execute(array('provider' => "Discord", 'id' => $uid, 'uuid' => $v5uuid, 'username' => $_SESSION['user_username'], 'email' => $email, 'country' => $user->locale));

    	$select = $pdo->prepare("SELECT * FROM user WHERE uuid = :uuid");
      $select->execute(array('uuid' => $v5uuid));

Add dynamic redirect to the main website.
E.g. on login and logout

Once you press submit, you get another mail with a delete token

Add and design new error messages.
Remove this: https://ext-cdn.fivemods.net/img/96ed725ffa870dd23ec79d738014a980.png

Change to something more modern.

@Fredneyy please create create some design layouts on Figma :)

Fix word suggestions array

https://cdn.oetkher.de/u/3f24c2af9c228d40f97ecfbfc4cd4d68.png

should show a "Preview" of the mod

https://cdn.fivemods.net/a435cdbd1f7c803016128a7fe1b0c49b.png

https://cdn.skyfs.net/go/c078b61640ce7351272682f330100791.png

e. g. https://cdn.oetkher.de/u/192eb72ed76defd935e26b051e093a7c.png

Test issue to check if discord webhook will notice

Enable feature that its actually possible to buy mods (balance system)

Add dynamic redirect to the main website.
E.g. on login and logout

• (Remove Deposit / buy mods function)
• Download button huge when logged in on every fm related page
• Change username doesnt work
• API Token logs you out (maybe remove this function?)
• Delete Account sends you a second mail when you confirm removal (with a remove token, not a confirmation)
• Income history should show estimate income with every mod
• Ads
• Affiliate
• Language change in footer still not working
• Only use existing tags in categories (maybe have a list with allowed tags)
• Rework partner program benefits
• remove unused code (!!!!)
• implement status into control panel
• yeet help center (or change it idk)
• upload issues

Add dynamic redirect to the main website.
E.g. on login and logout

Add payment success page

e.g. https://cdn.fivemods.net/c48a1d7fa88b58f1c700471b8c16d533.png

When clicking on an image in the carousel it should expand and blur the background.