fishgretel / fasd Goto Github PK

It'd be great to be able to do (from the fasd man page) vim d,ngin,conf<Tab> or at least vim nginx,conf<Alt-Z> How possible would that be?

Strange I know, not sure how else to explain other than to show:

Please let me know what other information that I can provide that would help.

Judging from the link, it seems that it is not a public asciinema link. Maybe you should consider making it public. Thank you.

when __fasd_run.fish is in effect, piping from aws resulted in the command being piped not the content

debian@debian10 ~/.c/f/conf.d> aws --version > /t/c
debian@debian10 ~/.c/f/conf.d> cat /t/c
aws --version
debian@debian10 ~/.c/f/conf.d> file (which aws)
/home/debian/.local/bin/aws: Python script, ASCII text executable

it works fine after I remove the file.

debian@debian10 ~/.c/fish> rm conf.d/__fasd_run.fish
debian@debian10 ~/.c/fish> fish
Welcome to fish, the friendly interactive shell
debian@debian10 ~/.c/fish> aws --version > /t/c
debian@debian10 ~/.c/fish> cat /t/c
aws-cli/1.18.211 Python/3.7.3 Linux/4.19.0-13-amd64 botocore/1.19.51
debian@debian10 ~/.c/fish>

I'm not sure if this is a problem with my configuration or something.
I've a hunch that it might be related to the fact that aws is a python script.
Anyway, I'm running in tmux under byobu in debian10 in a virtual machine with vmplayer.
it's a relatively new machine.

debian@debian10 ~/.c/fish> fish --version
fish, version 3.0.2

Looks like #20 introduced a dependency on GNU grep (FreeBSD grep doesn't support the -P flag, see e.g. Homebrew/legacy-homebrew#35848). This is easily fixed by installing GNU grep (brew install grep && set -U fish_user_paths /usr/local/opt/grep/libexec/gnubin $fish_user_paths). Another option is switching to perl. Wasn't sure what you prefer so I didn't create a PR.

In any case, thanks for maintaining this!

The function in conf.d/__fasd_run.fish break the pipe and redirections

Reproduction steps

Unexpected behavior

# install fasd
fisher install fishgretel/fasd

# load a file to clipboard
❯ cat .editorconfig | pbcopy

# clipboard content
❯ pbpaste
❯ cat .editorconfig | pbcopy⏎

Expected behavior

# remove the config function
rm ~/.config/fish/conf.d/__fasd_run.fish

# load a file to clipboard
❯ cat .editorconfig | pbcopy

# clipboard content
❯ pbpaste
# editorconfig.org
root = true

[*]
indent_style = space
indent_size = 2

Infos

❯ fish --version
fish, version 3.1.2

❯ uname -a
Darwin pro.local 20.2.0 Darwin Kernel Version 20.2.0: Wed Dec  2 20:39:59 PST 2020; root:xnu-7195.60.75~1/RELEASE_X86_64 x86_64

Any steps needed for fish to get working in version 3.3.1?

fasd on zsh/bash also takes care of figuring out files used in the arguments to commands.

See example

❯ fish -v
fish, version 3.1.2

❯ fasd --version
1.0.1

~/workspace/fasd
❯ ls
a.log  b.log  c.log

~/workspace/fasd
❯ rm -rf *log
~/.config/fish/conf.d/__fasd_run.fish (line 1): No matches for wildcard '*log'. See `help expand`.
echo rm -rf *log
            ^
in command substitution
	called on line 1 of file ~/.config/fish/conf.d/__fasd_run.fish
in command substitution
	called on line 4 of file ~/.config/fish/conf.d/__fasd_run.fish
in function '__fasd_run' with arguments 'rm\ -rf\ \*log'
in event handler: handler for generic event 'fish_postexec'

~/workspace/fasd
❯ ls
(files were removed)

When jumping to directories or editing files with a leading ~ the plugin won't recognize it and furthermore won't add it to the ~/.fasd file.

Example:
cd /home/<user>/Documents results in a line in the .fasd
cd ~/Documents won't result in a line

same for file manipulation

nano /home/<user>/.Xresources will result in a line
nano ~/.Xresources won't

This behaviour isn't happening in bash or zsh (both tested ✅ ). Perhaps due to the fact of putting 'eval "$(fasd --init auto)' in their rc files.

I am encountering the above error with the following simple example:

$ set foo 1
$ echo $foo
1
string replace: Regular expression substitute error: unknown substring

I have pinpointed the problem to happen only after I install fishgretel/fasd via fisher. This happens on fish version 3.2.0. Happy to provide additional info if necessary, thanks!