fippo / webrtc-dump-importer Goto Github PK

It would be nice to be able to see what string value certain stats had, e.g. qualityLimitationReason, even though these are not numbers.

Suggestion 1: Value. Show a snapshot of the latest value readable as a string somewhere instead of filtering it out like it doesn't exist.
Suggestion 2: Graph. Map values to numbers so that they can be plotted on the graph, with a legend that shows which string each number maps to, or if you can tell my hovering the mouse over it. So you can see which point in time on the graph it had a particular value.
Suggestion 3: Pie chart. Show what % of time (i.e. how many stats samples compared to the total number of stats samples) the metric had each particular value that it had.

Now that Chrome can no longer generate legacy stats reports as of M122
https://bugs.chromium.org/p/chromium/issues/detail?id=822696#c37
we can remove support here as well. Ideally with some detection similar to what is done for createLegacyCandidateTable which can suggest "checkout an old version of this repo"

Delete! Delete!

https://code.google.com/p/webrtc/issues/detail?id=5040#c1 made me want to expand the trace of a loaded file at a certain location and highlight a certain piece of text.

Probably using something like #peerconnectionid:traceindex:text-to-highlight;...
Bonus points for generating this

There is a line of code var client = JSON.parse(lines.shift()); that is generating errors:

Uncaught SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at FileReader.<anonymous> (bitrate.html:44)

Uncaught SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at FileReader.<anonymous> (rtcstats.html:97)

I just ran the tests from https://test.webrtc.org/ to generate the dump, using Chrome 80.0.3987.149 (Official Build) (64-bit). Breakpointing and inspecting the lines array, it looks fine (as in, there are the same number of array entries as lines of text in the source file), but I'm not familiar enough with JavaScript to know why the JSON parser might fail like this. I tried manually adding blank lines to the end of the file in case there was a weirdy with the last line - same result.

I checked the file for JSON validity using jsonlint.com and it validated fine.

I tried it in Safari 13.0.5 (15608.5.11) and get a different error from the same line(s) of code:

SyntaxError: JSON Parse error: Expected '}'
parse — bitrate.html:44
(anonymous function) — bitrate.html:44

Firefox 71.0 (64-bit):

SyntaxError: JSON.parse: end of data while reading object contents at line 1 column 2 of the JSON data

All this on macOS 10.15.3.

Thanks in advance for any assistance or thoughts.

Cheers - Robert...

If I'm looking for how much packet loss occurred on a call I have to individually turn off all the things which influence the scale so that I can't see the little things like NACK, packet loss etc.

It would be nice to have an option somewhere at the top to turn off all graphs and then only turn back on for example NackCount in all graphs.

Most of the time the graphs for ICE candidates and ports etc are just noise. So it would be helpful to filter by default down to anything related to RTP. Maybe with the option to include the ICE graphs later.